Skip to content

Commit f13ab1d

Browse files
committed
Make Registration an Interface and DeviceRegistration concrete class
1 parent a35a656 commit f13ab1d

16 files changed

Lines changed: 664 additions & 486 deletions

File tree

leshan-integration-tests/src/test/java/org/eclipse/leshan/integration/tests/server/redis/RedisRegistrationStoreTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
import org.eclipse.leshan.server.endpoint.EffectiveEndpointUriProvider;
5656
import org.eclipse.leshan.server.observation.LwM2mNotificationReceiver;
5757
import org.eclipse.leshan.server.profile.ClientProfile;
58+
import org.eclipse.leshan.server.registration.DeviceRegistration;
5859
import org.eclipse.leshan.server.registration.Registration;
5960
import org.eclipse.leshan.server.registration.RegistrationStore;
6061
import org.eclipse.leshan.transport.californium.ObserveUtil;
@@ -185,7 +186,7 @@ public void remove_observation() {
185186
}
186187

187188
private void givenASimpleRegistration(Long lifetime) {
188-
Registration.Builder builder = new Registration.Builder(registrationId, ep,
189+
DeviceRegistration.Builder builder = new DeviceRegistration.Builder(registrationId, ep,
189190
new IpPeer(new InetSocketAddress(address, port)), uriHandler.createUri("coap://localhost:5683"));
190191

191192
registration = builder.lifeTimeInSec(lifetime).smsNumber(sms).bindingMode(binding).objectLinks(objectLinks)

leshan-lwm2m-server-redis/src/main/java/org/eclipse/leshan/server/redis/serialization/RegistrationSerDes.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import org.eclipse.leshan.core.node.LwM2mPath;
4646
import org.eclipse.leshan.core.request.BindingMode;
4747
import org.eclipse.leshan.core.request.ContentFormat;
48+
import org.eclipse.leshan.server.registration.DeviceRegistration;
4849
import org.eclipse.leshan.server.registration.Registration;
4950

5051
import com.fasterxml.jackson.core.JsonProcessingException;
@@ -180,8 +181,8 @@ public Registration deserialize(JsonNode jObj) {
180181
jObj.get("epUri").asText(), jObj.get("regId").asText(), jObj.get("ep").asText()));
181182
}
182183

183-
Registration.Builder b = new Registration.Builder(jObj.get("regId").asText(), jObj.get("ep").asText(),
184-
peerSerDes.deserialize(jObj.get("transportdata")), endpointUri);
184+
DeviceRegistration.Builder b = new DeviceRegistration.Builder(jObj.get("regId").asText(),
185+
jObj.get("ep").asText(), peerSerDes.deserialize(jObj.get("transportdata")), endpointUri);
185186

186187
b.bindingMode(BindingMode.parse(jObj.get("bnd").asText()));
187188
if (jObj.get("qm") != null)

leshan-lwm2m-server-redis/src/test/java/org/eclipse/leshan/server/redis/serialization/RegistrationSerDesTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.eclipse.leshan.core.peer.IpPeer;
3737
import org.eclipse.leshan.core.request.ContentFormat;
3838
import org.eclipse.leshan.server.registration.DefaultRegistrationDataExtractor;
39+
import org.eclipse.leshan.server.registration.DeviceRegistration;
3940
import org.eclipse.leshan.server.registration.Registration;
4041
import org.eclipse.leshan.server.registration.RegistrationDataExtractor.RegistrationData;
4142
import org.junit.jupiter.api.Test;
@@ -56,7 +57,7 @@ void ser_and_des_are_equals() {
5657
objs[0] = new Link("/0/1024/2", attrs);
5758
objs[1] = new Link("/0/2");
5859

59-
Registration.Builder builder = new Registration.Builder("registrationId", "endpoint",
60+
DeviceRegistration.Builder builder = new DeviceRegistration.Builder("registrationId", "endpoint",
6061
new IpPeer(new InetSocketAddress(Inet4Address.getLoopbackAddress(), 1)),
6162
uriHandler.createUri("coap://localhost:5683")).objectLinks(objs).rootPath("/")
6263
.supportedContentFormats(ContentFormat.TLV, ContentFormat.TEXT);
@@ -94,7 +95,7 @@ void ser_and_des_are_equals_with_app_data() {
9495
appData.put("string", "string test");
9596
appData.put("null", null);
9697

97-
Registration.Builder builder = new Registration.Builder("registrationId", "endpoint",
98+
DeviceRegistration.Builder builder = new DeviceRegistration.Builder("registrationId", "endpoint",
9899
new IpPeer(new InetSocketAddress(Inet4Address.getLoopbackAddress(), 1)),
99100
uriHandler.createUri("coap://localhost:5683")).objectLinks(objs).rootPath("/")
100101
.supportedContentFormats(ContentFormat.TLV, ContentFormat.TEXT).customRegistrationData(appData);

0 commit comments

Comments
 (0)