fix(identifier): forceRun() resumes backfill after server restart mid-migration

Previously forceRun() returned false once idx_identifier_base_type existed,
permanently abandoning millions of NULL base_type rows if the server restarted
mid-backfill.

Fix: also return true when hasPendingRows() detects identifier rows with
null base_type and non-null asset_subtype. DDL uses IF NOT EXISTS so
re-running executeUpgrade() is always safe.

Tests: replace incorrect false-when-index-exists assertion with two cases:
- returns false only when index exists AND no pending rows remain
- returns true when index exists but backfill is incomplete (restart scenario)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: wezell

dotCMS/src/main/java/com/dotmarketing/startup/runonce/Task260331AddBaseTypeColumnToIdentifier.java

@@ -25,16 +25,20 @@ public class Task260331AddBaseTypeColumnToIdentifier implements StartupTask {
 
     @Override
     public boolean forceRun() {
-
-        // only run if the index has not been built yet
         try {
+            // Run if the index has not been created yet
             final List<Map<String, Object>> result = new DotConnect()
                     .setSQL("SELECT 1 FROM pg_indexes WHERE tablename = 'identifier' AND indexname = ?")
                     .addParam(INDEX_NAME)
                     .loadObjectResults();
-            return result.isEmpty();
+            if (result.isEmpty()) {
+                return true;
+            }
+            // Also run if the backfill is incomplete — handles server restarts mid-migration.
+            // DDL uses IF NOT EXISTS so re-running executeUpgrade() is always safe.
+            return PopulateIdentifierBaseTypeJob.hasPendingRows();
         } catch (final DotDataException e) {
-            Logger.error(this, "Error checking for index " + INDEX_NAME + ": " + e.getMessage(), e);
+            Logger.error(this, "Error in forceRun() for " + INDEX_NAME + ": " + e.getMessage(), e);
             return false;
         }
     }

dotcms-integration/src/test/java/com/dotmarketing/startup/runonce/Task260331AddBaseTypeColumnToIdentifierTest.java

@@ -63,17 +63,49 @@ public void test_executeUpgrade_addsColumnAndIndex() throws SQLException, DotDat
 
     /**
      * Method to test: {@link Task260331AddBaseTypeColumnToIdentifier#forceRun()}
-     * When: Index already exists
-     * Should: Return false (task should not re-run)
+     * When: Index exists AND all rows are already populated (migration complete)
+     * Should: Return false — no work to do
      */
     @Test
-    public void test_forceRun_returnsFalseWhenIndexExists() throws DotDataException, SQLException {
+    public void test_forceRun_returnsFalseWhenMigrationComplete() throws DotDataException, SQLException {
         cleanUp();
 
         final var task = new Task260331AddBaseTypeColumnToIdentifier();
         task.executeUpgrade();
 
-        assertFalse("forceRun() should return false when index already exists", task.forceRun());
+        // Ensure no pending rows remain
+        new DotConnect().executeStatement(
+                "UPDATE identifier SET base_type = 1 WHERE base_type IS NULL AND asset_subtype IS NOT NULL");
+
+        try {
+            assertFalse("forceRun() should return false when index exists and no pending rows remain",
+                    task.forceRun());
+        } finally {
+            new DotConnect().executeStatement(
+                    "UPDATE identifier SET base_type = NULL WHERE base_type = 1 AND asset_subtype IS NOT NULL");
+        }
+    }
+
+    /**
+     * Method to test: {@link Task260331AddBaseTypeColumnToIdentifier#forceRun()}
+     * When: Index exists BUT rows still have null base_type (server restarted mid-backfill)
+     * Should: Return true so the backfill job is re-scheduled
+     */
+    @Test
+    public void test_forceRun_returnsTrueWhenBackfillIncomplete() throws DotDataException, SQLException {
+        cleanUp();
+
+        final var task = new Task260331AddBaseTypeColumnToIdentifier();
+        task.executeUpgrade();
+
+        // Simulate mid-backfill restart: index exists but some rows are still NULL
+        new DotConnect().executeStatement(
+                "UPDATE identifier SET base_type = NULL " +
+                "WHERE asset_subtype IS NOT NULL AND id = (" +
+                "  SELECT id FROM identifier WHERE asset_subtype IS NOT NULL LIMIT 1)");
+
+        assertTrue("forceRun() should return true when index exists but backfill is incomplete",
+                task.forceRun());
     }
 
     /**