chore: remove RxJS 7 migration plan and clean up unused DotPropertiesService references

Author: nicobytes

.cursor/plans/rxjs_7_migration_plan_c65e7afc.plan.md

@@ -21,7 +21,6 @@ import {
     DotMessageDisplayService,
     DotPageTypesService,
     DotPageWorkflowsActionsService,
-    DotPropertiesService,
     DotRenderMode,
     DotRouterService,
     DotWizardService,
@@ -141,7 +140,6 @@ describe('DotPageStore', () => {
     let dotHttpErrorManagerService: DotHttpErrorManagerService;
     let dotFavoritePageService: DotFavoritePageService;
     let dotLocalstorageService: DotLocalstorageService;
-    let dotPropertiesService: DotPropertiesService;
     let dotPushPublishDialogService: DotPushPublishDialogService;
 
     beforeEach(() => {
@@ -163,7 +161,6 @@ describe('DotPageStore', () => {
                 StringUtils,
                 DotFavoritePageService,
                 DotLocalstorageService,
-                DotPropertiesService,
                 DotPushPublishDialogService,
                 { provide: DialogService, useClass: DialogServiceMock },
                 { provide: DotcmsEventsService, useClass: DotcmsEventsServiceMock },
@@ -196,14 +193,11 @@ describe('DotPageStore', () => {
         dotWorkflowActionsFireService = TestBed.inject(DotWorkflowActionsFireService);
         dotFavoritePageService = TestBed.inject(DotFavoritePageService);
         dotLocalstorageService = TestBed.inject(DotLocalstorageService);
-        dotPropertiesService = TestBed.inject(DotPropertiesService);
         dotPushPublishDialogService = TestBed.inject(DotPushPublishDialogService);
 
         jest.spyOn(dialogService, 'open');
         jest.spyOn(dotHttpErrorManagerService, 'handle');
         jest.spyOn(dotLocalstorageService, 'getItem').mockReturnValue(`true`);
-        jest.spyOn(dotPropertiesService, 'getKey').mockReturnValue(of('*'));
-        jest.spyOn(dotPropertiesService, 'getFeatureFlag').mockReturnValue(of(false));
 
         dotPageStore.setInitialStateData(5);
         dotPageStore.setKeyword('test');

core-web/apps/dotcms-ui/src/app/portlets/dot-pages/dot-pages-store/dot-pages.store.spec.ts

@@ -23,7 +23,6 @@ import {
     DotMessageService,
     DotPageTypesService,
     DotPageWorkflowsActionsService,
-    DotPropertiesService,
     DotRenderMode,
     DotRouterService,
     DotWorkflowActionsFireService,
@@ -45,7 +44,6 @@ import {
     DotLanguage,
     DotPermissionsType,
     ESContent,
-    FeaturedFlags,
     PermissionsType,
     UserPermissions
 } from '@dotcms/dotcms-models';
@@ -154,7 +152,6 @@ export class DotPageStore extends ComponentStore<DotPagesState> {
     private siteService = inject(SiteService);
     private dotFavoritePageService = inject(DotFavoritePageService);
     private dotLocalstorageService = inject(DotLocalstorageService);
-    private dotPropertiesService = inject(DotPropertiesService);
 
     readonly getStatus$ = this.select((state) => state?.pages?.status || ComponentStatus.INIT);
 
@@ -508,13 +505,7 @@ export class DotPageStore extends ComponentStore<DotPagesState> {
                 .getEnvironments()
                 .pipe(map((environments: DotEnvironment[]) => !!environments.length)),
             this.getSessionStorageFilterParams(),
-            this.getLocalStorageFavoritePanelParams(),
-            this.dotPropertiesService.getFeatureFlag(
-                FeaturedFlags.FEATURE_FLAG_CONTENT_EDITOR2_ENABLED
-            ),
-            this.dotPropertiesService
-                .getKey(FeaturedFlags.FEATURE_FLAG_CONTENT_EDITOR2_CONTENT_TYPE)
-                .pipe(map((contentTypes) => contentTypes.split(',')))
+            this.getLocalStorageFavoritePanelParams()
         ])
             .pipe(
                 take(1),
@@ -526,18 +517,15 @@ export class DotPageStore extends ComponentStore<DotPagesState> {
                         isEnterprise,
                         environments,
                         filterParams,
-                        collapsedParam,
-                        ,
+                        collapsedParam
                     ]: [
                         ESContent,
                         DotCurrentUser,
                         DotLanguage[],
                         boolean,
                         boolean,
                         DotSessionStorageFilter,
-                        boolean,
-                        boolean,
-                        string[]
+                        boolean
                     ]) => {
                         return this.dotCurrentUser
                             .getUserPermissions(