Skip to content

Commit 0b5f911

Browse files
Fix driver not cleaned up (#517)
* chore: remove did-content from environment variable * fix: find and cleanup orphaned deployment
1 parent 4a304cb commit 0b5f911

2 files changed

Lines changed: 20 additions & 2 deletions

File tree

ci/deploy-k8s-aws/scripts/deploy-services.sh

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,12 @@ cat services.json | jq -c '.' | while read -r service; do
240240
if [ "$current_image" != "$image" ]; then
241241
echo "⚠ Image mismatch detected!"
242242
echo " Updating deployment with new image..."
243-
kubectl set image deployment/"$name" "$name=$image" -n "$NAMESPACE"
243+
244+
# Generate full deployment manifest (includes managed-by label)
245+
create_deployment_yaml "$name" "$image" "$ports" "$env_vars" "$env_file"
246+
247+
# Apply deployment manifest (this updates labels too)
248+
kubectl apply -f "deployment-${name}.yaml"
244249

245250
echo " Waiting for rollout to complete (timeout: 5 minutes)..."
246251
if kubectl rollout status deployment/"$name" -n "$NAMESPACE" --timeout=300s; then
@@ -251,6 +256,20 @@ cat services.json | jq -c '.' | while read -r service; do
251256
fi
252257
else
253258
echo "✓ Image is up to date, no action needed"
259+
260+
# Ensure deployment has proper labels even if image hasn't changed
261+
echo " Ensuring deployment has proper labels..."
262+
create_deployment_yaml "$name" "$image" "$ports" "$env_vars" "$env_file"
263+
kubectl apply -f "deployment-${name}.yaml"
264+
echo "✓ Labels synchronized"
265+
fi
266+
267+
# Ensure service exists and has proper configuration (ports may have changed)
268+
if [ ! -z "$ports" ] && [ "$ports" != "null" ]; then
269+
echo " Ensuring service exists with correct ports..."
270+
create_service_yaml "$name" "$ports"
271+
kubectl apply -f "service-${name}.yaml"
272+
echo "✓ Service synchronized"
254273
fi
255274
else
256275
echo "⚡ Deployment '$name' does not exist, creating new deployment..."

docker-compose.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ services:
7373
uniresolver_web_driver_url_did_evrc:
7474
uniresolver_web_driver_url_did_keri:
7575
uniresolver_web_driver_url_did_webs:
76-
uniresolver_web_driver_url_did_content:
7776
uniresolver_web_driver_url_did_prism:
7877
uniresolver_web_driver_url_did_iden3:
7978
uniresolver_web_driver_url_did_cndid:

0 commit comments

Comments
 (0)