feat: shell portability fixes and bun lockfile#2114
Open
Skippy-the-Magnificent-one wants to merge 1 commit into
Open
feat: shell portability fixes and bun lockfile#2114Skippy-the-Magnificent-one wants to merge 1 commit into
Skippy-the-Magnificent-one wants to merge 1 commit into
Conversation
- shebangs: #!/bin/bash -> #!/usr/bin/env bash across shell scripts - web: move pnpm.overrides to top-level overrides (bun compat) - web: replace pnpm-lock.yaml with bun.lock - docs: remove empty voices README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#!/bin/bash→#!/usr/bin/env bashacross shell scripts for portability (nix, macOS, non-standard bash paths)scripts/installer/install.shinternal/plugins/template/Examples/remote-security-report.shinternal/plugins/template/Examples/security-report.shinternal/plugins/template/Examples/track_packages.shbun.lockfor bun users (bun doesn't use pnpm-lock.yaml)pnpm-lock.yaml(redundant withpackage-lock.jsonalready in repo)docs/voices/README.mdWhy
The
#!/bin/bashshebang assumes bash lives at/bin/bash, which isn't true on NixOS, some BSDs, or custom installs.#!/usr/bin/env bashis the portable standard.The web directory now has both
package-lock.json(npm) andpnpm-lock.yaml-- having abun.lockas well supports all three package managers. Sincepnpm-lock.yamlis redundant with the existing npm lockfile, this swaps it for bun support.