Skip to content

Commit 618b133

Browse files
committed
aa: adopt upstream-recommended regularization defaults
Switch AA_REGULARIZATION_TYPE_1 from 1e-6 to 1e-8 and AA_REGULARIZATION_TYPE_2 from 1e-10 to 1e-12, matching the values recommended by the upstream aa package. Benchmark sweep on hs21_tiny_qp / rob_gauss_cov_est / max_ent at eps in {1e-8, 1e-10, 1e-12, 1e-14} shows the new defaults are ≥ the old ones on 10/12 rows; the two losses are cases that hit max_iters under all settings.
1 parent ca9e147 commit 618b133

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

include/glbopts.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ static inline void *scs_calloc(size_t count, size_t size) {
220220

221221
/* --- Anderson Acceleration (AA) parameters --- */
222222
#define AA_RELAXATION (1.0)
223-
#define AA_REGULARIZATION_TYPE_1 (1e-6)
224-
#define AA_REGULARIZATION_TYPE_2 (1e-10)
223+
#define AA_REGULARIZATION_TYPE_1 (1e-8)
224+
#define AA_REGULARIZATION_TYPE_2 (1e-12)
225225
/* Reject AA steps when the output norm exceeds this multiple of the input
226226
* norm. 1.0 means the AA step must not increase the iterate norm. */
227227
#define AA_SAFEGUARD_FACTOR (1.)

0 commit comments

Comments
 (0)