Adding nethack 5.0.0#33219
Draft
tdejager wants to merge 2 commits intoconda-forge:mainfrom
Draft
Conversation
NetHack is a classic terminal roguelike. The recipe builds with the upstream linux/macOS hints files; lua 5.4.8 and ncurses come from conda-forge, with stub static archives standing in for NetHack's bundled lua build so its makefile dependency resolution still works. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Move the compiler.500 CFLAGS-assignment fix and the Makefile.src LUALIBS change out of build.sh and into source patches applied via the recipe's source.patches list. Easier to review, easier to maintain, and matches how upstream-patching is normally done in conda-forge recipes. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds NetHack 5.0.0, the classic terminal roguelike,
as a new conda-forge package.
sys/unixhints files (linux.500/macOS.500)lua 5.4.8andncurses 6.6rather than vendoringwinhack-driven and wouldneed its own recipe pass
$PREFIX/bin/nethack(a small wrapper) plus$PREFIX/share/nethack/for game data, matching the conda layout
The build script patches one
=to+=incompiler.500so the conda env'sCFLAGSsurvive, and patchesMakefile.srcto add-lluatoLUALIBSso thereal lua symbols come from
$PREFIX/lib. NetHack's makefile still wants astatic
liblua.ato satisfy a make dependency; we materialize a tiny stubarchive instead of fetching and building the bundled lua source.
Verified locally on osx-arm64:
nethack --versionandnethack --showpathsboth work;
otool -Lshows the binary linking only against@rpath/libncurses.6.dylib,@rpath/liblua.5.4.dylib, andlibSystem.Checklist
dat/license, NGPL)