Closed mint connections are not handled.

[nduitz]

Environment

• Pigeon version: main (unreleased)

Current behavior

If the FCM adapter is alive for a while lib/pigeon/fcm.ex:150 won't match since the socket closes and that is never handled properly

Expected behavior

  def handle_info({:closed, _}, %{config: config} = state) do
    case connect_socket(config) do
      {:ok, socket} ->
        Configurable.schedule_ping(config)
        {:noreply, %{state | socket: socket}}

      {:error, reason} ->
        {:stop, reason}
    end
  end

should handle closed connections.

[mccraigmccraig]

I'm seeing this error with the FCM backend which looks like this issue

it's not always - some pushes are sent just fine

does this mean that on OTP28 FCM backends are currently unreliable and there isn't yet a fix ?

#300 seems to fix the issue - even if it's not 100% reliable

• occasional lost FCM pushes is better than no FCM pushes
• as long as an error is returned, then our Oban-based push-batching approach will mean pushes are never actually lost

[error] GenServer #PID<0.1433.0> terminating
** (MatchError) no match of right hand side value:

    {:error,
     %Mint.HTTP2{
       transport: Mint.Core.Transport.SSL,
       socket: {:sslsocket, #Port<0.52>, #PID<0.1436.0>, #PID<0.1435.0>, :gen_tcp,
        :tls_gen_connection, #Reference<0.2069026957.3109683204.12628>, :undefined},
       mode: :active,
       hostname: "fcm.googleapis.com",
       port: 443,
       scheme: "https",
       authority: "fcm.googleapis.com",
       state: :closed,
       buffer: "",
       window_size: 1048576,
       encode_table: %HPAX.Table{
         protocol_max_table_size: 4096,
         max_table_size: 4096,
         huffman_encoding: :never,
         entries: [],
         size: 0,
         length: 0,
         pending_minimum_resize: nil
       },
       decode_table: %HPAX.Table{
         protocol_max_table_size: 4096,
         max_table_size: 4096,
         huffman_encoding: :never,
         entries: [],
         size: 0,
         length: 0,
         pending_minimum_resize: nil
       },
       ping_queue: {[], []},
       client_settings_queue: {[], []},
       next_stream_id: 3,
       streams: %{},
       open_client_stream_count: 0,
       open_server_stream_count: 0,
       ref_to_stream_id: %{},
       server_settings: %{
         enable_push: true,
         max_concurrent_streams: 100,
         initial_window_size: 1048576,
         max_frame_size: 16384,
         max_header_list_size: 65536,
         enable_connect_protocol: false
       },
       client_settings: %{
         enable_push: true,
         max_concurrent_streams: 100,
         initial_window_size: 2147483647,
         max_frame_size: 16777215,
         max_header_list_size: :infinity
       },
       headers_being_processed: nil,
       proxy_headers: [],
       private: %{},
       log: false
     }, %Mint.HTTPError{reason: :closed, module: Mint.HTTP2}}

    (pigeon 2.1.0) lib/pigeon/fcm.ex:150: Pigeon.FCM.handle_push/2
    (pigeon 2.1.0) lib/pigeon/dispatcher_worker.ex:28: Pigeon.DispatcherWorker.handle_info/2
    (stdlib 7.1) gen_server.erl:2434: :gen_server.try_handle_info/3
    (stdlib 7.1) gen_server.erl:2420: :gen_server.handle_msg/3
    (stdlib 7.1) proc_lib.erl:333: :proc_lib.init_p_do_apply/3
Last message: {:"$push", %Pigeon.FCM.Notification{__meta__: %Pigeon.Metadata{on_response: #Function<1.35817644/1 in Pigeon.push_sync/3>}, android: nil, apns: nil, data: %{}, error: nil, fcm_options: nil, name: nil, notification: %{"body" => "Mr. Android", "title" => "hi there"}, response: nil, target: {:token, "fFPUQ4QQRGGDGZrph542jn:APA91bFqAHpTXg7i4NDau7HAFvzBZ-a4cKd0c8uwWldw-XwZwwTTH52nQnoouaqyUWFbGfE8t84DbOHlsM4iU2q6r-B1yku8PbdCbXCcgTASLIul8a8Owik"}, validate_only: nil, webpush: nil}}
State: %{state: %Pigeon.FCM{config: %Pigeon.FCM.Config{auth: Backend.Goth, project_id: "sona-staging-and-review", uri: ~c"fcm.googleapis.com", port: 443}, queue: %Pigeon.HTTP.RequestQueue{requests: %{}}, retries: 3, socket: %Mint.HTTP2{transport: Mint.Core.Transport.SSL, socket: {:sslsocket, #Port<0.52>, #PID<0.1436.0>, #PID<0.1435.0>, :gen_tcp, :tls_gen_connection, #Reference<0.2069026957.3109683204.12628>, :undefined}, mode: :active, hostname: "fcm.googleapis.com", port: 443, scheme: "https", authority: "fcm.googleapis.com", state: :closed, buffer: "", window_size: 1048576, encode_table: %HPAX.Table{protocol_max_table_size: 4096, max_table_size: 4096, huffman_encoding: :never, entries: [], size: 0, length: 0, pending_minimum_resize: nil}, decode_table: %HPAX.Table{protocol_max_table_size: 4096, max_table_size: 4096, huffman_encoding: :never, entries: [], size: 0, length: 0, pending_minimum_resize: nil}, ping_queue: {[], []}, client_settings_queue: {[], []}, next_stream_id: 3, streams: %{}, open_client_stream_count: 0, open_server_stream_count: 0, ref_to_stream_id: %{}, server_settings: %{enable_push: true, max_concurrent_streams: 100, initial_window_size: 1048576, max_frame_size: 16384, max_header_list_size: 65536, enable_connect_protocol: false}, client_settings: %{enable_push: true, max_concurrent_streams: 100, initial_window_size: 2147483647, max_frame_size: 16777215, max_header_list_size: :infinity}, headers_being_processed: nil, proxy_headers: [], private: %{}, log: false}}, adapter: Pigeon.FCM}
[info] Elixir.Backend.Engagement.PushNotifications.PigeonSendPushNotifications.send_notification - Firebase (sona-staging-and-review):
notification: %{"body" => "Mr. Android", "data" => %{}, "title" => "hi there", "token" => "fFPUQ4QQRGGDGZrph542jn:APA91bFqAHpTXg7i4NDau7HAFvzBZ-a4cKd0c8uwWldw-XwZwwTTH52nQnoouaqyUWFbGfE8t84DbOHlsM4iU2q6r-B1yku8PbdCbXCcgTASLIul8a8Owik", "type" => "firebase"}
result: %Pigeon.FCM.Notification{__meta__: %Pigeon.Metadata{on_response: #Function<1.35817644/1 in Pigeon.push_sync/3>}, android: nil, apns: nil, data: %{}, error: nil, fcm_options: nil, name: nil, notification: %{"body" => "Mr. Android", "title" => "hi there"}, response: :timeout, target: {:token, "fFPUQ4QQRGGDGZrph542jn:APA91bFqAHpTXg7i4NDau7HAFvzBZ-a4cKd0c8uwWldw-XwZwwTTH52nQnoouaqyUWFbGfE8t84DbOHlsM4iU2q6r-B1yku8PbdCbXCcgTASLIul8a8Owik"}, validate_only: nil, webpush: nil}