fix(Cluster): update PositionSource assignment logic

chemodun · chemodun · commit 7e5f5f1a4952 · 2025-09-22T22:16:31.000+03:00
Class Cluster: ~update PositionSource assignment to prioritize XML attribute if available; ~ensure source is only set if PositionSource is empty
diff --git a/src/X4DataLoader/Cluster.cs b/src/X4DataLoader/Cluster.cs
@@ -124,10 +124,11 @@ public void SetPosition(
       if (positionXML != null)
       {
         PositionXML = positionXML;
+        PositionSource = XmlHelper.GetAttribute(PositionXML, "_source") ?? PositionSource;
       }
-      if (!string.IsNullOrEmpty(source))
+      if (string.IsNullOrEmpty(PositionSource) && !string.IsNullOrEmpty(source))
       {
-        PositionSource = XmlHelper.GetAttribute(PositionXML, "_source") ?? source;
+        PositionSource = source;
       }
       if (!string.IsNullOrEmpty(fileName))
       {

Original file line number	Diff line number	Diff line change
`@@ -124,10 +124,11 @@ public void SetPosition(`
`124`	`124`	`if (positionXML != null)`
`125`	`125`	`{`
`126`	`126`	`PositionXML = positionXML;`
	`127`	`+ PositionSource = XmlHelper.GetAttribute(PositionXML, "_source") ?? PositionSource;`
`127`	`128`	`}`
`128`		`- if (!string.IsNullOrEmpty(source))`
	`129`	`+ if (string.IsNullOrEmpty(PositionSource) && !string.IsNullOrEmpty(source))`
`129`	`130`	`{`
`130`		`- PositionSource = XmlHelper.GetAttribute(PositionXML, "_source") ?? source;`
	`131`	`+ PositionSource = source;`
`131`	`132`	`}`
`132`	`133`	`if (!string.IsNullOrEmpty(fileName))`
`133`	`134`	`{`