Skip to content

Commit 23e75a1

Browse files
committed
fix: use explicit futuresMarket endpoint in shared WS functions and fix flaky checkFields test
Shared functions (candles, ticker, allTickers, aggTrades) now explicitly route futures variator to endpoints.futuresMarket instead of relying on endpoints.futures coincidentally pointing to /market/ws. Also fix checkFields to use `field in object` instead of `t.truthy(value)` so fields with valid falsy values like `trades: 0` don't cause failures.
1 parent c34d72b commit 23e75a1

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

src/websocket.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,11 @@ const candles = (payload, interval, cb, transform = true, variator) => {
222222
const cache = (Array.isArray(payload) ? payload : [payload]).map(symbol => {
223223
const w = openWebSocket(
224224
`${
225-
variator ? endpoints[variator] : endpoints.base
225+
variator === 'futures'
226+
? endpoints.futuresMarket
227+
: variator === 'delivery'
228+
? endpoints.delivery
229+
: endpoints.base
226230
}/${symbol.toLowerCase()}@kline_${interval}`,
227231
)
228232
w.onmessage = msg => {
@@ -378,7 +382,7 @@ const ticker = (payload, cb, transform = true, variator) => {
378382
const w = openWebSocket(
379383
`${
380384
variator === 'futures'
381-
? endpoints.futures
385+
? endpoints.futuresMarket
382386
: variator === 'delivery'
383387
? endpoints.delivery
384388
: endpoints.base
@@ -411,7 +415,7 @@ const allTickers = (cb, transform = true, variator) => {
411415
const w = new openWebSocket(
412416
`${
413417
variator === 'futures'
414-
? endpoints.futures
418+
? endpoints.futuresMarket
415419
: variator === 'delivery'
416420
? endpoints.delivery
417421
: endpoints.base
@@ -561,7 +565,7 @@ const aggTrades = (payload, cb, transform = true, variator) => {
561565
const w = openWebSocket(
562566
`${
563567
variator === 'futures'
564-
? endpoints.futures
568+
? endpoints.futuresMarket
565569
: variator === 'delivery'
566570
? endpoints.delivery
567571
: endpoints.base

test/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import http from 'http'
22

33
export const checkFields = (t, object, fields) => {
44
fields.forEach(field => {
5-
t.truthy(object[field])
5+
t.truthy(field in object)
66
})
77
}
88

0 commit comments

Comments
 (0)