Merge branch 'main' into feature/hyperv-api-backend-virtual-machine

Author: xmkg

.github/workflows/cli-tests.yml

@@ -52,7 +52,7 @@ jobs:
       has_targets: ${{ steps.neo.outputs.has_targets }}
     steps:
       - id: neo
-        uses: actions/github-script@v8
+        uses: actions/github-script@v9
         with:
           script: |
             const crypto = require('crypto');

.github/workflows/close-inactive-issues.yml

@@ -15,7 +15,7 @@ jobs:
           days-before-issue-stale: 30
           days-before-issue-close: 14
           stale-issue-label: "stale"
-          stale-issue-message: "This issue was marked stale because it has been labelled with \"question\" for 30 days."
+          stale-issue-message: "This issue was marked stale because it has been labelled with \"needs-info\" for 30 days."
           close-issue-message: "This issue was closed because it has been 14 days since being marked as stale."
 
           # Leave PRs alone

.github/workflows/dynamic-ci.yml

@@ -45,7 +45,8 @@ jobs:
               - 'docs/**'
             code:
               - ".github/workflows/linux*"
-              - ".github/workflows/windows-macos.yml"
+              - ".github/workflows/macos.yml"
+              - ".github/workflows/windows.yml"
               - ".github/.codecov.yml"
               - "3rd-party/**"
               - "completions/**"
@@ -83,11 +84,18 @@ jobs:
     uses: "./.github/workflows/linux.yml"
     secrets: inherit
 
-  windows-macos:
-    name: Windows/macOS
+  macos:
+    name: macOS
     needs: filter
     if: needs.filter.outputs.code == 'true'
-    uses: "./.github/workflows/windows-macos.yml"
+    uses: "./.github/workflows/macos.yml"
+    secrets: inherit
+
+  windows:
+    name: Windows
+    needs: filter
+    if: needs.filter.outputs.code == 'true'
+    uses: "./.github/workflows/windows.yml"
     secrets: inherit
 
   hooks:
@@ -100,7 +108,7 @@ jobs:
     name: Finalize
     runs-on: ubuntu-latest
     if: ${{ always() }}
-    needs: [docs, lint, linux, windows-macos, hooks]
+    needs: [docs, lint, linux, windows, macos, hooks]
     steps:
       - name: Docs failure check
         if: ${{
@@ -112,7 +120,8 @@ jobs:
         if: ${{
           needs.lint.result == 'failure' || needs.lint.result == 'cancelled' ||
           needs.linux.result == 'failure' || needs.linux.result == 'cancelled' ||
-          needs.windows-macos.result == 'failure' || needs.windows-macos.result == 'cancelled'
+          needs.windows.result == 'failure' || needs.windows.result == 'cancelled' ||
+          needs.macos.result == 'failure' || needs.macos.result == 'cancelled'
           }}
         run: exit 1
 

.github/workflows/lint.yml

@@ -91,3 +91,9 @@ jobs:
             echo "Run '3rd-party/flutter/bin/dart format' to fix formatting."
             exit 1
           fi
+
+      - name: Check gui-less snapcraft.yaml is up to date
+        shell: bash
+        run: |
+          pip install --quiet -r git-hooks/requirements.txt
+          packaging/gui-less/generate-snapcraft.py --check

.github/workflows/linux.yml

@@ -23,7 +23,7 @@ jobs:
     steps:
     - name: Determine job matrix
       id: set-matrix
-      uses: actions/github-script@v8
+      uses: actions/github-script@v9
       with:
         script: |
           const matrix = { include: [] };

.github/workflows/windows-macos.yml .github/workflows/macos.yml.github/workflows/windows-macos.yml renamed to .github/workflows/macos.yml

@@ -1,4 +1,4 @@
-name: WindowsMacOS
+name: MacOS
 
 on:
   workflow_call:
@@ -10,7 +10,7 @@ permissions:
   contents: read
 
 concurrency:
-  group: windows-macos-${{ github.workflow }}-${{ github.event.number && format('pr{0}', github.event.number) || github.run_id }}
+  group: macos-${{ github.workflow }}-${{ github.event.number && format('pr{0}', github.event.number) || github.run_id }}
   cancel-in-progress: true
 
 env:
@@ -33,18 +33,11 @@ jobs:
     steps:
     - name: Determine build matrix
       id: set-matrix
-      uses: actions/github-script@v8
+      uses: actions/github-script@v9
       with:
         script: |
           const matrix = { include: [] };
 
-          // Windows targets
-          matrix.include.push({
-              "name": "Windows Server 2025",
-              "runs-on": "windows-2025"
-          });
-
-          // macOS targets
           matrix.include.push({
             "name": "macOS Latest (Apple Silicon)",
             "runs-on": "macos-latest"
@@ -75,7 +68,6 @@ jobs:
       mac-arm-package-artifact-name: ${{ steps.publish-data.outputs.macos-latest-package-artifact-name }}
       mac-x86-package-file-name: ${{ steps.publish-data.outputs.macos-15-intel-package-file-name }}
       mac-arm-package-file-name: ${{ steps.publish-data.outputs.macos-latest-package-file-name }}
-      windows-pkg-url: ${{ steps.publish-data.outputs.windows-2025-s3-url }}
 
     name: Build and Test (${{ matrix.name }})
     runs-on: ${{ matrix.runs-on }}
@@ -101,20 +93,11 @@ jobs:
       with:
         xcode-version: '16.2'
 
-    - name: Enable symlinks
-      if: ${{ runner.os == 'Windows' }}
-      run: git config --local core.symlinks true
-
-    - name: Disable auto CRLF on Windows
-      if: ${{ runner.os == 'Windows' }}
-      run: git config --local core.autocrlf false
-
     - name: Determine build parameters
       id: build-params
       uses: ./.github/actions/build-params
 
     - name: Set preferred tar
-      if: ${{ runner.os == 'macOS' }}
       id: preferred-tar
       run: |
         # Prepend gnu-tar's (future) location to the path, to prioritize it over system tar
@@ -123,13 +106,11 @@ jobs:
 
       # TODO: find a friendlier approach for installing pip packages on GitHub runners
     - name: Force pip to allow break-system-packages via pip.conf
-      if: ${{ runner.os == 'macOS' }}
       run: |
         mkdir -p ~/.pip
         echo -e "[install]\nbreak-system-packages = true" > ~/.pip/pip.conf
 
     - name: Install dependencies from brew
-      if: ${{ runner.os == 'macOS' }}
       run: |
         # Avoid reinstalling cmake
         brew list cmake > /dev/null || brew install cmake
@@ -158,22 +139,9 @@ jobs:
         brew link --overwrite nuget
 
     - name: Install dependencies from pip
-      if: ${{ runner.os == 'macOS' }}
       run: |
         python3 -m pip install --user --upgrade distlib
 
-    - name: Install specific QEMU from Choco
-      if: ${{ runner.os == 'Windows' }}
-      uses: crazy-max/ghaction-chocolatey@v4
-      with:
-        args: install --yes qemu --version=2023.4.24
-
-    - name: Install other packages from Choco
-      if: ${{ runner.os == 'Windows' }}
-      uses: crazy-max/ghaction-chocolatey@v4
-      with:
-        args: install --yes wget unzip
-
     - name: Set up vcpkg
       id: setup-vcpkg
       uses: lukka/run-vcpkg@v11
@@ -192,13 +160,12 @@ jobs:
         NUGET_PATH="$($VCPKG_ROOT/vcpkg fetch nuget | tail -n 1)"
         MONO_WRAPPER=""
 
-        if [[ "$RUNNER_OS" == "macOS" ]]; then
-            # Check if we actually need to call NuGet through mono.
-            # That would be the case if NuGet is the real PE32 executable
-            # instead of a shim.
-            if file "$NUGET_PATH" | grep -q "PE32"; then
-                MONO_WRAPPER="mono"
-            fi
+
+        # Check if we actually need to call NuGet through mono.
+        # That would be the case if NuGet is the real PE32 executable
+        # instead of a shim.
+        if file "$NUGET_PATH" | grep -q "PE32"; then
+            MONO_WRAPPER="mono"
         fi
 
         $MONO_WRAPPER "$NUGET_PATH" \
@@ -248,20 +215,6 @@ jobs:
       with:
         version: "v0.12.0"
 
-    - name: Install Windows ADK
-      if: ${{ runner.os == 'Windows' }}
-      uses: crazy-max/ghaction-chocolatey@v4
-      with:
-        args: install --yes windows-adk-deploy
-
-    - name: Install cmake
-      if: ${{ runner.os == 'Windows' }}
-      uses: lukka/[email protected]
-
-    - name: Set up MSVC
-      if: ${{ runner.os == 'Windows' }}
-      uses: ilammy/msvc-dev-cmd@v1
-
     - name: Configure
       run: >
         cmake
@@ -270,42 +223,67 @@ jobs:
         -GNinja
         -DMULTIPASS_UPSTREAM=origin
         -DMULTIPASS_BUILD_LABEL=${{ steps.build-params.outputs.label }}
-        ${{ runner.os == 'Windows' && '-DCMAKE_C_COMPILER=cl.exe -DCMAKE_CXX_COMPILER=cl.exe' || '' }}
         ${{ github.event_name == 'schedule' && '-DMP_ALLOW_OPTIONAL_FEATURES=OFF' || '' }}
         ${{ github.workspace }}
 
     - name: Build
       run: cmake --build ${{ env.BUILD_DIR }}
 
+    - name: Enable core dump generation
+      working-directory: ${{ env.BUILD_DIR }}
+      shell: bash
+      run : |
+        # Allow core dumps
+        sudo sysctl -w kern.coredump=1
+        # This entitlement is needed for a proc to produce a coredump
+        /usr/libexec/PlistBuddy -c "Add :com.apple.security.get-task-allow bool true" segv.entitlements
+        # Code-sign the test executable to grant core dump entitlement
+        codesign -s - -f --entitlements segv.entitlements bin/multipass_tests
+        # Ensure destination exists and is writable
+        sudo mkdir -p /cores || true
+        sudo chmod 1777 /cores
+        # Print syctl coredump parameters
+        sysctl kern.coredump kern.corefile
+        ulimit -a
+        ulimit -Hc
+
     - name: Run unit tests
       working-directory: ${{ env.BUILD_DIR }}
       run: |
+        # Catch and save the test executable's exit code
+        trap 'echo "MULTIPASS_TESTS_EXIT_CODE=$?" >> $GITHUB_ENV' EXIT
+        # Set soft limit for the core file size (512MiB)
+        ulimit -c 1048576
         bin/multipass_tests
 
     - name: Run integration tests
       working-directory: ${{ env.BUILD_DIR }}
       run: |
         bin/multipass_integration_tests
 
+    - name: Upload test coredump
+      uses: actions/upload-artifact@v7
+      if: ${{ failure() && env.MULTIPASS_TESTS_EXIT_CODE != '0' }}
+      with:
+        name: buildandtest-test-crash-${{ matrix.runs-on }}-${{ matrix.build-type }}
+        retention-days: 7
+        path: |
+          /cores/**
+          ${{ env.BUILD_DIR }}/bin/multipass_tests
+
     - name: Package
       id: cmake-package
       working-directory: ${{ env.BUILD_DIR }}
       run: >
         cmake --build . --target package
 
-        echo "name=$( ${{ runner.os != 'Windows' && 'basename *.pkg' ||
-        '( Get-ChildItem .\packages\en-US\multipass-*.msi ).Name' }} ) " >>
-        ${{ runner.os != 'Windows' && '$GITHUB_OUTPUT' || '$env:GITHUB_OUTPUT' }}
+        echo "name=$( basename *.pkg )" >> $GITHUB_OUTPUT
 
-        echo "path=$( ${{ runner.os != 'Windows' && 'greadlink -f *.pkg' ||
-        '( Get-ChildItem .\packages\en-US\multipass-*.msi ).FullName' }} )" >>
-        ${{ runner.os != 'Windows' && '$GITHUB_OUTPUT' || '$env:GITHUB_OUTPUT' }}
+        echo "path=$( greadlink -f *.pkg )" >> $GITHUB_OUTPUT
 
     - name: Get package logs
       if: ${{ failure() && steps.cmake-package.outcome == 'failure' }}
-      run: >
-        ${{ format('cat {0}/_CPack_Packages/{1}', env.BUILD_DIR,
-        runner.os == 'Windows' && 'win64/External/WiXOutput.log' || 'Darwin/productbuild/InstallOutput.log') }}
+      run: cat ${{ env.BUILD_DIR }}/_CPack_Packages/Darwin/productbuild/InstallOutput.log
 
     - name: Upload package
       uses: actions/upload-artifact@v7
@@ -371,7 +349,6 @@ jobs:
 
       # TODO: find a friendlier approach for installing pip packages on GitHub runners
     - name: Force pip to allow break-system-packages via pip.conf
-      if: ${{ runner.os == 'macOS' }}
       run: |
         mkdir -p ~/.pip
         echo -e "[install]\nbreak-system-packages = true" > ~/.pip/pip.conf
@@ -435,21 +412,7 @@ jobs:
       run: |
         echo "##[warning] Public URL: ${{ steps.s3-upload.outputs.url }}"
 
-  DispatchCLITestsWorkflowWin:
-    name: "Dispatch CLI Tests (Windows)"
-    permissions:
-      contents: read
-      actions: read
-      checks:  write
-    secrets: inherit
-    needs:
-      - BuildAndTest
-    uses: ./.github/workflows/cli-tests.yml
-    with:
-      windows-pkg-url: ${{ needs.BuildAndTest.outputs.windows-pkg-url }}
-      backend-driver: hyperv_api
-
-  DispatchCLITestsWorkflowMac:
+  DispatchCLITestsWorkflow:
     name: "Dispatch CLI Tests (macOS)"
     permissions:
       contents: read
@@ -492,6 +455,6 @@ jobs:
         MATTERMOST_CHANNEL: multipass
         TEXT: |
           :red_circle: @mp
-          Scheduled [WindowsMacOS](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) workflow exited before completing.
+          Scheduled [MacOS](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) workflow exited before completing.
         MATTERMOST_USERNAME: ${{ github.triggering_actor }}
         MATTERMOST_ICON_URL: https://www.flaticon.com/free-icon/github-logo_25231

.github/workflows/prune-packages.yml

@@ -21,7 +21,7 @@ jobs:
     steps:
       - name: Collect package names
         id: collect
-        uses: actions/github-script@v8
+        uses: actions/github-script@v9
         with:
           script: |
             const owner = context.repo.owner;