Skip to content

Commit 0c55037

Browse files
committed
improve test in task_processor_test
Signed-off-by: fimanishi <[email protected]>
1 parent bdb3d5b commit 0c55037

1 file changed

Lines changed: 20 additions & 2 deletions

File tree

service/history/replication/task_processor_test.go

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,16 @@ func (s *taskProcessorSuite) TestProcessorLoop_TaskExecuteFailed_PutDLQSuccess()
262262
s.mockDomainCache.EXPECT().GetDomainName(testDomainID).Return(testDomainName, nil).AnyTimes()
263263

264264
// task will be put into dlq
265-
s.mockShard.Resource.ExecutionMgr.On("PutReplicationTaskToDLQ", mock.Anything, mock.Anything).Return(nil).Times(1)
265+
s.mockShard.Resource.ExecutionMgr.On("PutReplicationTaskToDLQ", mock.Anything, mock.MatchedBy(func(req *persistence.PutReplicationTaskToDLQRequest) bool {
266+
return req.SourceClusterName == "standby" &&
267+
req.TaskInfo.DomainID == testDomainID &&
268+
req.TaskInfo.WorkflowID == testWorkflowID &&
269+
req.TaskInfo.RunID == testRunID &&
270+
req.TaskInfo.TaskType == persistence.ReplicationTaskTypeSyncActivity &&
271+
req.TaskInfo.ScheduledID == testScheduleID &&
272+
req.DomainName == testDomainName &&
273+
req.Task != nil
274+
})).Return(nil).Times(1)
266275

267276
// start the process loop
268277
s.taskProcessor.wg.Add(1)
@@ -304,7 +313,16 @@ func (s *taskProcessorSuite) TestProcessorLoop_TaskExecuteFailed_PutDLQFailed()
304313
dqlRetryPolicy.SetMaximumAttempts(2)
305314
s.taskProcessor.dlqRetryPolicy = dqlRetryPolicy
306315
s.mockShard.Resource.ExecutionMgr.
307-
On("PutReplicationTaskToDLQ", mock.Anything, mock.Anything).
316+
On("PutReplicationTaskToDLQ", mock.Anything, mock.MatchedBy(func(req *persistence.PutReplicationTaskToDLQRequest) bool {
317+
return req.SourceClusterName == "standby" &&
318+
req.TaskInfo.DomainID == testDomainID &&
319+
req.TaskInfo.WorkflowID == testWorkflowID &&
320+
req.TaskInfo.RunID == testRunID &&
321+
req.TaskInfo.TaskType == persistence.ReplicationTaskTypeSyncActivity &&
322+
req.TaskInfo.ScheduledID == testScheduleID &&
323+
req.DomainName == testDomainName &&
324+
req.Task != nil
325+
})).
308326
Return(errors.New("failed to put to dlq")).
309327
Times(3)
310328

0 commit comments

Comments
 (0)