Skip to content

Commit c527efa

Browse files
authored
add_basic_filter → set_basic_filter, remove_basic_filter → clear_basic_filter (#749)
Change `Worksheet` method names to align them with respective Sheets API request names (SetBasicFilterRequest, ClearBasicFilterRequest): * add_basic_filter -> set_basic_filter * remove_basic_filter -> clear_basic_filter
1 parent a612a49 commit c527efa

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

gspread/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1670,7 +1670,7 @@ def freeze(self, rows=None, cols=None):
16701670
return self.spreadsheet.batch_update(body)
16711671

16721672
@cast_to_a1_notation
1673-
def add_basic_filter(self, name=None):
1673+
def set_basic_filter(self, name=None):
16741674
"""Add a basic filter to the worksheet. If a range or bundaries
16751675
are passed, the filter will be limited to the given range.
16761676
@@ -1714,7 +1714,7 @@ def add_basic_filter(self, name=None):
17141714

17151715
return self.spreadsheet.batch_update(body)
17161716

1717-
def remove_basic_filter(self):
1717+
def clear_basic_filter(self):
17181718
"""Remove the basic filter from a worksheet.
17191719
17201720
.. versionadded:: 3.4

0 commit comments

Comments
 (0)