Skip to content

Commit 9bea276

Browse files
committed
- Added deprecation notices for render_settings and re_render_settings methods in Collection and SmartEntities classes, recommending the use of env.render_component('collection_settings', this) instead.
- Updated the `re_render_settings` logic in `SmartEntities` to directly call the new rendering method.
1 parent 5deccae commit 9bea276

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

smart-collections/collection.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -423,6 +423,7 @@ export class Collection {
423423

424424
/**
425425
* Renders the settings for the collection into a given container.
426+
* @deprecated use env.render_component('collection_settings', this) instead (2025-05-25: decouple UI from collections)
426427
* @param {HTMLElement} [container=this.settings_container]
427428
* @param {Object} opts
428429
* @returns {Promise<HTMLElement>}
@@ -433,6 +434,7 @@ export class Collection {
433434

434435
/**
435436
* Helper function to render collection settings.
437+
* @deprecated use env.render_component('collection_settings', this) instead (2025-05-25: decouple UI from collections)
436438
* @param {HTMLElement} [container=this.settings_container]
437439
* @param {Object} opts
438440
* @returns {Promise<HTMLElement>}

smart-entities/smart_entities.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export class SmartEntities extends Collection {
121121
if (!this.env._embed_model && this.env.opts.modules.smart_embed_model?.class) this.env._embed_model = new this.env.opts.modules.smart_embed_model.class({
122122
settings: this.settings.embed_model,
123123
adapters: this.env.opts.modules.smart_embed_model?.adapters,
124-
re_render_settings: this.re_render_settings.bind(this),
124+
re_render_settings: () => this.env.render_component('collection_settings', this, {settings_container: this.settings_container}),
125125
reload_model: this.reload_embed_model.bind(this),
126126
});
127127
return this.env._embed_model;
@@ -132,10 +132,6 @@ export class SmartEntities extends Collection {
132132
this.embed_model.unload();
133133
this.env._embed_model = null;
134134
}
135-
re_render_settings() {
136-
this.env.smart_view.empty(this.settings_container);
137-
this.render_settings();
138-
}
139135

140136
/**
141137
* Finds the nearest entities to a given entity.
@@ -319,6 +315,9 @@ export class SmartEntities extends Collection {
319315
get settings_config() {
320316
return settings_config;
321317
}
318+
/**
319+
* @deprecated use env.render_component('collection_settings', this) instead (2025-05-25: decouple UI from collections)
320+
*/
322321
async render_settings(container=this.settings_container, opts = {}) {
323322
container = await this.render_collection_settings(container, opts);
324323
const embed_model_settings_frag = await this.env.render_component('settings', this.embed_model, opts);

smart-environment/smart_env.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class SmartEnv {
4343
* If a newer version is loaded into a runtime that already has an older environment,
4444
* an automatic reload of all existing mains will occur.
4545
*/
46-
static version = 2.139134;
46+
static version = 2.139136;
4747
scope_name = 'smart_env';
4848
static global_ref = ROOT_SCOPE;
4949
global_ref = this.constructor.global_ref;

smart-sources/smart_sources.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@ export class SmartSources extends SmartEntities {
323323
const _settings_config = {
324324
...super.settings_config,
325325
...this.process_settings_config(settings_config),
326+
...this.process_settings_config(this.embed_model.settings_config, 'embed_model'),
326327
...Object.entries(this.source_adapters).reduce((acc, [file_extension, adapter_constructor]) => {
327328
if(acc[adapter_constructor]) return acc; // Skip if already added same adapter_constructor
328329
const item = this.items[Object.keys(this.items).find(i => i.endsWith(file_extension))];

0 commit comments

Comments
 (0)