Enhance null-safe checks in SmartEnv and SmartNotices

- Update SmartEnv to improve null-safe checks for the 'smart-connections' plugin, ensuring proper handling of older environments.
- Modify SmartNotices constructor to use optional chaining for environment getter, enhancing robustness.
- Maintain existing comments and methods unrelated to the changes.

Author: brianpetro

obsidian-smart-env/smart_env.js

@@ -11,7 +11,10 @@ export class SmartEnv extends BaseSmartEnv {
   static async create(plugin, main_env_opts = {}) {
     // Special handling for old Obsidian smart environments
     // Detect if environment has 'init_main'
-    if (plugin.app.plugins.plugins['smart-connections'] && !plugin.app.plugins.plugins['smart-connections']?.env?.constructor?.version) {
+    if (plugin.app.plugins.plugins['smart-connections']
+        && plugin.app.plugins.plugins['smart-connections'].env
+        && !plugin.app.plugins.plugins['smart-connections'].env.constructor.version
+    ) {
       const update_notice = "Detected older SmartEnv with 'init_main'. Reloading without the outdated plugin. Please update Smart Connections.";
       // Attempt a user-visible notice if Obsidian's Notice is in scope, otherwise warn:
       console.warn(update_notice);

smart-notices/smart_notices.js

@@ -79,8 +79,7 @@ export class SmartNotices {
    * @param {Object} scope - The main plugin instance
    */
   constructor(env, adapter=null) {
-    this.env = env;
-    this.env.create_env_getter(this); // sets this.env
+    env?.create_env_getter(this); // sets this.env
     this.active = {};
     this.adapter = adapter || this.env.config.modules.smart_notices.adapter;
     // Make sure each notice entry has a .create() method