`ResourceCollection.limit(0)` yields one item

[T90REAL]

Describe the bug

Calling limit(0) on a ResourceCollection yields one item instead of none.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

[]

Current Behavior

['first']

Reproduction Steps

from boto3.resources.collection import ResourceCollection

class DummyCollection(ResourceCollection):
    def __init__(self, limit):
        self._params = {"limit": limit}
    def pages(self):
        yield ["first", "second"]

items = list(DummyCollection(0))
print(items)

Possible Solution

No response

Additional Information/Context

Note: This issue was identified by an automated testing tool for academic research and manually checked. If you have any concerns about this type of reporting, please let me know, and I will adjust my workflow accordingly. Thanks.

SDK version used

1.40.64

Environment details (OS name and version, etc.)

Linux | Python3.12

[RyanFitzSimmonsAK]

Hi @T90REAL, thanks for reaching out. I might be misunderstanding, but I believe that with real operations, pages will be empty when limit is 0, avoiding this behavior. Are you able to reproduce this with a real operation?

[T90REAL]

Thanks for the response. I retested with a real resource call and it returns [], so it can not be reproduced with a real operation. It seems to only show up in a synthetic ResourceCollection subclass where pages() yields data.

[RyanFitzSimmonsAK]

Thanks for confirming that. Closing this issue.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.