Bug: job result tracking incorrect — completed jobs shown as FAIL, COMPLETED counter stays at 0

[STRRL]

Description

The dashboard shows incorrect job result status:

1. COMPLETED counter is always 00 — even though GitHub Actions shows multiple successful workflow runs (golangci-lint, Unit Test, etc. all with green checkmarks).
2. RECENT JOBS all show FAIL — the list is full of red FAIL results, but GitHub Actions clearly shows successful runs. Only a few entries show RUN (which appears to mean "currently running"), and none show a success/completed state.

Screenshots

• Dashboard: COMPLETED 00, FAILED 16, RECENT JOBS all FAIL
• GitHub Actions: multiple green ✅ successful runs (golangci-lint #85, Unit Test feat: track job execution history and resource consumption metrics #17, etc.)

Expected

• COMPLETED counter should reflect actually completed (successful) jobs
• RECENT JOBS should show correct result per job (SUCCESS / FAIL / RUN)
• The job result should come from the actual GitHub Actions workflow run conclusion, not just the runner lifecycle

[STRRL]

Root Cause Analysis

Investigated the API response by calling ListJobRecords directly:

{
    "id": "4bfc14d5-e214-5535-8328-70645b663c9d",
    "runnerName": "fruit-runner-linux-arm64-d6dce",
    "runnerSetName": "fruit-runner-linux-arm64",
    "startedAt": "2026-04-07T05:59:12.417702Z",
    "completedAt": "2026-04-07T06:00:16.785831Z"
}

Completed jobs are missing the result field entirely. This means the backend's toProtoJobResult() in internal/api/server.go:154 is returning JOB_RESULT_UNSPECIFIED (enum value 0), which protobuf JSON serialization omits by default.

Chain of events

1. GitHub Actions Scale Set API sends a result string when a job completes (e.g., "Succeeded", "Failed")
2. RecordJobCompleted() in internal/management/jobs.go:57 stores the result as-is in SQLite
3. toProtoJobResult() has a switch on "running", "Succeeded", "Failed" — but if the actual stored value doesn't match any of these (different casing, different string, empty, etc.), it falls through to JOB_RESULT_UNSPECIFIED
4. Protobuf JSON serialization omits enum value 0, so result is missing from the API response
5. Frontend fallback in dashboard/src/api/fetchers.ts:120:

   result: JOB_RESULT_MAP[j.result] ?? (j.completedAt ? 'failure' : 'running')

   Since j.result is undefined (missing field), JOB_RESULT_MAP[undefined] returns undefined, and the fallback treats all completed jobs as 'failure'

Fix needed

1. Investigate what result strings are actually stored in SQLite — might be different from "Succeeded"/"Failed" (e.g. lowercase, or a different enum from GitHub API)
2. Backend: Make toProtoJobResult() more robust (case-insensitive matching, or normalize on write)
3. Frontend: Don't default completed jobs to 'failure' when result is unknown — use 'unknown' or similar

[STRRL]

Fixed in commit 90f9e15.

Root cause: GitHub Actions API sends job results in lowercase ("succeeded", "failed"), but toProtoJobResult() in internal/api/server.go was matching Title Case ("Succeeded", "Failed"). This caused all completed jobs to map to JOB_RESULT_UNSPECIFIED and display as FAIL in the dashboard.

Fix: Changed toProtoJobResult() to use strings.ToLower(r) before the switch, and updated knownJobResults in internal/management/jobs.go to include both lowercase and Title Case variants (the latter kept for backward compatibility).