Skip to content

Inconsistency/duplication: SoftwareVersion and SoftwareVersions #2327

@yarikoptic

Description

@yarikoptic

Came up while reviewing paper for BEP020 (atten @bids-standard/bep020), claude picked up inconsistency of having SoftwareVersion whenever BIDS has SoftwareVersions. Well - the surprise is that we have both! :-/

❯ git grep '\<SoftwareVersions\>'
src/CHANGES.md:-   Added `SoftwareVersions`.
src/modality-specific-files/magnetoencephalography.md:   "SoftwareVersions": "Acq 5.4.2-linux-20070507",
src/pregh-changes.md:-   Added `SoftwareVersions`.
src/schema/objects/metadata.yaml:SoftwareVersions:
src/schema/objects/metadata.yaml:  name: SoftwareVersions
src/schema/rules/sidecars/continuous.yaml:    SoftwareVersions: recommended
src/schema/rules/sidecars/eeg.yaml:    SoftwareVersions: recommended
src/schema/rules/sidecars/ieeg.yaml:    SoftwareVersions: recommended
src/schema/rules/sidecars/meg.yaml:    SoftwareVersions: recommended
src/schema/rules/sidecars/micr.yaml:    SoftwareVersions: recommended
src/schema/rules/sidecars/motion.yaml:    SoftwareVersions: recommended
src/schema/rules/sidecars/mri.yaml:    SoftwareVersions:
src/schema/rules/sidecars/mrs.yaml:    SoftwareVersions: recommended
src/schema/rules/sidecars/nirs.yaml:    SoftwareVersions: recommended
❯ git grep '\<SoftwareVersion\>'
src/modality-agnostic-files/events.md:        "SoftwareVersion": "3.0.14",
src/schema/objects/metadata.yaml:SoftwareVersion:
src/schema/objects/metadata.yaml:  name: SoftwareVersion
src/schema/objects/metadata.yaml:    - SoftwareVersion
src/schema/objects/metadata.yaml:    SoftwareVersion:
src/schema/objects/metadata.yaml:      $ref: objects.metadata.SoftwareVersion

with master gaining 1 more hit

src/modality-specific-files/physiological-recordings.md:    "SoftwareVersion": "SREB1.10.1630 WIN32 LID:F2AE011 Mod:2017.04.21 15:19 CEST",

with plural form used more and singular, even as of current master (hence having bep020 merged) having singular form described as

SoftwareVersion:
  name: SoftwareVersion
  display_name: Software Version
  description: |
    Version of the software that was used to present the stimuli.
  type: string

thus pointing only to stimuli ...

There is also another singular

❯ git grep '[a-z]SoftwareVersions*\>'
src/schema/objects/metadata.yaml:HardcopyDeviceSoftwareVersion:
src/schema/objects/metadata.yaml:  name: HardcopyDeviceSoftwareVersion
src/schema/rules/sidecars/mri.yaml:    HardcopyDeviceSoftwareVersion: deprecated

which was deprecated.

So, overall, I think

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions