Avoid endless loop in modal inline edit submit

Ensure that the submit event has a defined submitter property to avoid an
endless loop between the form submit event listener, submitInlineEdit, and
htmx.trigger.

Author: bkembreeBPS

share/static/js/util.js

@@ -1978,20 +1978,24 @@ jQuery(function () {
                     jQuery(this).closest('form').data('changed', true);
                 });
                 document.querySelector('#dynamic-modal form').addEventListener('submit', function(evt) {
-                    evt.preventDefault();
-
-                    document.querySelectorAll('#dynamic-modal form textarea.richtext').forEach((textarea) => {
-                        const name = textarea.name;
-                        if ( RT.CKEditor.instances[name] ) {
-                            if ( RT.CKEditor.instances[name].getData() !== textarea.value ) {
-                                RT.CKEditor.instances[name].updateSourceElement();
-                                jQuery(textarea.closest('form')).data('changed', true);
+                    // if form was submitted using htmx.trigger in submitInlineEdit evt.submitter is undefined
+                    // in that case allow default form submit otherwise it creates an endless loop:
+                    if ( evt.submitter !== undefined ) {
+                        evt.preventDefault();
+
+                        document.querySelectorAll('#dynamic-modal form textarea.richtext').forEach((textarea) => {
+                            const name = textarea.name;
+                            if ( RT.CKEditor.instances[name] ) {
+                                if ( RT.CKEditor.instances[name].getData() !== textarea.value ) {
+                                    RT.CKEditor.instances[name].updateSourceElement();
+                                    jQuery(textarea.closest('form')).data('changed', true);
+                                }
                             }
+                        });
+                        if ( jQuery('#dynamic-modal form').data('changed') ) {
+                            cell.addClass('editing');
+                            submitInlineEdit(jQuery('#dynamic-modal form'), cell);
                         }
-                    });
-                    if ( jQuery('#dynamic-modal form').data('changed') ) {
-                        cell.addClass('editing');
-                        submitInlineEdit(jQuery('#dynamic-modal form'), cell);
                     }
                 });
             });