[Test] Tolerate intermittent dcvsessionlauncher crash on g5g instances.#7350
Draft
gmarciani wants to merge 3 commits intoaws:developfrom
Draft
[Test] Tolerate intermittent dcvsessionlauncher crash on g5g instances.#7350gmarciani wants to merge 3 commits intoaws:developfrom
gmarciani wants to merge 3 commits intoaws:developfrom
Conversation
…tack trace (form 100 lines to 500 lines).
gmarciani
added
skip-changelog-update
Tolerate the known dcvsessionlauncher SEGV (g_subprocess_send_signal -> on_read_startup_string_ready) on g5g instances. This crash has an impact only on the creation of the first dcv session. Such failure is not even visible to the end user, thanks to the retries made by dcv-connect. Also, any following dcv session is not impacted.
pytest.mark.usefixtures applied to fixture functions is an error in pytest 8+. Replace with direct fixture parameters, which is functionally equivalent.
gmarciani
force-pushed
the
wip/mgiacomo/3160/test-dcv-0422-3
branch
from
7b6a534 to
df9a730
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7350 +/- ##
===========================================
- Coverage 90.08% 90.07% -0.01%
===========================================
Files 182 182
Lines 16730 16732 +2
===========================================
+ Hits 15071 15072 +1
- Misses 1659 1660 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tolerate intermittent dcvsessionlauncher crash on g5g instances.
Tolerate the known dcvsessionlauncher SEGV (g_subprocess_send_signal -> on_read_startup_string_ready) on g5g instances.
This crash has an impact only on the creation of the first dcv session. Such failure is not even visible to the end user, thanks to the retries made by dcv-connect. Also, any following dcv session is not impacted.
Tests
ONGOING
test_dcv_configurationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.