Skip to content

[integ-tests] Check there is no defunct Slurm parameters#7342

Closed
hanwen-cluster wants to merge 3 commits intoaws:developfrom
hanwen-cluster:developapr15
Closed

[integ-tests] Check there is no defunct Slurm parameters#7342
hanwen-cluster wants to merge 3 commits intoaws:developfrom
hanwen-cluster:developapr15

Conversation

@hanwen-cluster
Copy link
Copy Markdown
Contributor

@hanwen-cluster hanwen-cluster commented Apr 16, 2026

Description of changes

  • This check is added to Slurm accounting tests, because they contain more Slurm parameters than other tests

Tests

The following tests have passed

{%- import 'common.jinja2' as common with context -%}
{{- common.OSS_COMMERCIAL_X86.append("rocky8") or "" -}}
{{- common.OSS_COMMERCIAL_X86.append("rocky9") or "" -}}
---
test-suites:
  schedulers:
    test_slurm_accounting.py::test_slurm_accounting:
      dimensions:
        - regions: ["ap-south-1"]
          instances:  {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["alinux2023"]
          schedulers: ["slurm"]
    test_slurm_accounting.py::test_slurm_accounting_external_dbd:
      dimensions:
        - regions: [ "ap-south-1" ]
          instances: {{ common.INSTANCES_DEFAULT_X86 }}
          oss: ["ubuntu2404"]
          schedulers: ["slurm"]

References

aws/aws-parallelcluster-cookbook#3165 should be merged before this PR

Github issue: #7319

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This check is added to Slurm accounting tests, because they contain more Slurm parameters than other tests
gmarciani
gmarciani previously approved these changes Apr 16, 2026
Copy link
Copy Markdown
Contributor

@gmarciani gmarciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job adding this check!

@hehe7318 hehe7318 added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Apr 22, 2026
@gmarciani gmarciani enabled auto-merge (rebase) April 22, 2026 23:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (a1e1583) to head (dda405e).
⚠️ Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7342      +/-   ##
===========================================
- Coverage    90.08%   90.07%   -0.01%     
===========================================
  Files          182      182              
  Lines        16730    16732       +2     
===========================================
+ Hits         15071    15072       +1     
- Misses        1659     1660       +1     
Flag Coverage Δ
unittests 90.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmarciani gmarciani closed this Apr 22, 2026
auto-merge was automatically disabled April 22, 2026 23:50

Pull request was closed

@gmarciani gmarciani reopened this Apr 22, 2026
@gmarciani gmarciani enabled auto-merge (rebase) April 22, 2026 23:51
@gmarciani gmarciani disabled auto-merge April 22, 2026 23:51
@gmarciani
Copy link
Copy Markdown
Contributor

Took over to unblock the merge: #7351

@gmarciani gmarciani closed this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants