[integ-tests] Check there is no defunct Slurm parameters#7342
Closed
hanwen-cluster wants to merge 3 commits intoaws:developfrom
Closed
[integ-tests] Check there is no defunct Slurm parameters#7342hanwen-cluster wants to merge 3 commits intoaws:developfrom
hanwen-cluster wants to merge 3 commits intoaws:developfrom
Conversation
This check is added to Slurm accounting tests, because they contain more Slurm parameters than other tests
gmarciani
previously approved these changes
Apr 16, 2026
Contributor
gmarciani
left a comment
There was a problem hiding this comment.
Good job adding this check!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7342 +/- ##
===========================================
- Coverage 90.08% 90.07% -0.01%
===========================================
Files 182 182
Lines 16730 16732 +2
===========================================
+ Hits 15071 15072 +1
- Misses 1659 1660 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Took over to unblock the merge: #7351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
The following tests have passed
References
aws/aws-parallelcluster-cookbook#3165 should be merged before this PR
Github issue: #7319
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.