Create a schema manager for non resource schemas (#4131)

* Create a schema manager for non resource schemas

Author: kddejong

src/cfnlint/rules/functions/Base64.py

@@ -3,9 +3,8 @@
 SPDX-License-Identifier: MIT-0
 """
 
-import cfnlint.data.schemas.other.functions
 from cfnlint.helpers import FUNCTIONS_SINGLE
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails
+from cfnlint.rules.functions._BaseFn import BaseFn
 
 
 class Base64(BaseFn):
@@ -22,8 +21,5 @@ def __init__(self) -> None:
             "Fn::Base64",
             ("string",),
             tuple(FUNCTIONS_SINGLE),
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "base64.json"
-            ),
         )
         self.fn_base64 = self.validate

src/cfnlint/rules/functions/Cidr.py

@@ -5,8 +5,7 @@
 
 from __future__ import annotations
 
-import cfnlint.data.schemas.other.functions
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails
+from cfnlint.rules.functions._BaseFn import BaseFn
 
 
 class Cidr(BaseFn):
@@ -23,8 +22,5 @@ def __init__(self) -> None:
             "Fn::Cidr",
             ("array",),
             None,
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "cidr.json"
-            ),
         )
         self.fn_cidr = self.validate

src/cfnlint/rules/functions/FindInMap.py

@@ -5,8 +5,7 @@
 
 from __future__ import annotations
 
-import cfnlint.data.schemas.other.functions
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails, singular_types
+from cfnlint.rules.functions._BaseFn import BaseFn, singular_types
 
 
 class FindInMap(BaseFn):
@@ -22,9 +21,6 @@ def __init__(self) -> None:
         super().__init__(
             "Fn::FindInMap",
             ("array",) + singular_types,
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "findinmap.json"
-            ),
             resolved_rule="W1034",
         )
         self.fn_findinmap = self.validate

src/cfnlint/rules/functions/GetAtt.py

@@ -10,10 +10,9 @@
 
 import regex as re
 
-import cfnlint.data.schemas.other.functions
 from cfnlint.helpers import ensure_list, is_types_compatible
 from cfnlint.jsonschema import ValidationError, ValidationResult, Validator
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails, all_types
+from cfnlint.rules.functions._BaseFn import BaseFn, all_types
 from cfnlint.schema import PROVIDER_SCHEMA_MANAGER
 
 
@@ -33,9 +32,6 @@ def __init__(self) -> None:
         super().__init__(
             "Fn::GetAtt",
             all_types,
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "getatt.json"
-            ),
         )
 
     def _resolve_getatt(

src/cfnlint/rules/functions/If.py

@@ -8,10 +8,9 @@
 from collections import deque
 from typing import Any
 
-import cfnlint.data.schemas.other.functions
 from cfnlint.context.conditions.exceptions import Unsatisfiable
 from cfnlint.jsonschema import ValidationError, ValidationResult, Validator
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails, all_types
+from cfnlint.rules.functions._BaseFn import BaseFn, all_types
 
 
 class If(BaseFn):
@@ -27,9 +26,6 @@ def __init__(self) -> None:
         super().__init__(
             "Fn::If",
             all_types,
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "if.json"
-            ),
         )
         self.child_rules["W1028"] = None
 

src/cfnlint/rules/functions/ImportValue.py

@@ -5,9 +5,8 @@
 
 from typing import Any, Iterator
 
-import cfnlint.data.schemas.other.functions
 from cfnlint.jsonschema import ValidationError, Validator
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails, singular_types
+from cfnlint.rules.functions._BaseFn import BaseFn, singular_types
 
 
 class ImportValue(BaseFn):
@@ -23,9 +22,6 @@ def __init__(self) -> None:
         super().__init__(
             "Fn::ImportValue",
             singular_types,
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "importvalue.json"
-            ),
         )
         self.child_rules = {
             "W6001": None,

src/cfnlint/rules/functions/Join.py

@@ -7,10 +7,9 @@
 
 from typing import Any
 
-import cfnlint.data.schemas.other.functions
 from cfnlint.jsonschema import ValidationResult
 from cfnlint.jsonschema.protocols import Validator
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails
+from cfnlint.rules.functions._BaseFn import BaseFn
 
 
 class Join(BaseFn):
@@ -27,9 +26,6 @@ def __init__(self) -> None:
             "Fn::Join",
             ("string",),
             resolved_rule="W1032",
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "join.json"
-            ),
         )
         self.child_rules.update(
             {

src/cfnlint/rules/functions/Length.py

@@ -7,9 +7,8 @@
 
 from typing import Any
 
-import cfnlint.data.schemas.other.functions
 from cfnlint.jsonschema import ValidationError, ValidationResult, Validator
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails
+from cfnlint.rules.functions._BaseFn import BaseFn
 
 
 class Length(BaseFn):
@@ -25,9 +24,6 @@ def __init__(self) -> None:
         super().__init__(
             "Fn::Length",
             ("integer",),
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "length.json"
-            ),
         )
 
     def fn_length(

src/cfnlint/rules/functions/Ref.py

@@ -7,10 +7,9 @@
 
 from typing import Any
 
-import cfnlint.data.schemas.other.functions
 from cfnlint.helpers import VALID_PARAMETER_TYPES, VALID_PARAMETER_TYPES_LIST
 from cfnlint.jsonschema import ValidationError, Validator
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails, all_types
+from cfnlint.rules.functions._BaseFn import BaseFn, all_types
 
 
 class Ref(BaseFn):
@@ -27,9 +26,6 @@ def __init__(self) -> None:
             "Ref",
             all_types,
             resolved_rule="W1030",
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "ref.json"
-            ),
         )
         self._all_refs = [
             "W2010",

src/cfnlint/rules/functions/Select.py

@@ -5,8 +5,7 @@
 
 from __future__ import annotations
 
-import cfnlint.data.schemas.other.functions
-from cfnlint.rules.functions._BaseFn import BaseFn, SchemaDetails, all_types
+from cfnlint.rules.functions._BaseFn import BaseFn, all_types
 
 
 class Select(BaseFn):
@@ -22,9 +21,6 @@ def __init__(self) -> None:
         super().__init__(
             "Fn::Select",
             all_types,
-            schema_details=SchemaDetails(
-                cfnlint.data.schemas.other.functions, "select.json"
-            ),
             resolved_rule="W1035",
         )
         self.fn_select = self.validate