Unable to use dual stack endpoint with self-hosted runners

[tophercullen]

Describe the bug
Enabling the dual stack endpoints on a self-hosted runner results in a non-existent API endpoint being used.

To Reproduce
Steps to reproduce the behavior:

1. Setup self-hosted runners in EKS
2. Enable dual stack endpoints with either env variable AWS_USE_DUALSTACK_ENDPOINT: true or a step with aws configure set default.ecr.use_dualstack_endpoint true
3. Use the action
4. See "getaddrinfo ENOTFOUND api.ecr.<region>.api.aws"

Expected behavior
ECR login action uses the ecr.<region>.api.aws endpoint when dual stack is enable

Screenshots

Desktop (please complete the following information):

• OS: Fedora42 container running on self-hosted actions runner on AL2023 in EKS.
• Version: latest

Additional context
I cannot repo this locally or on a scratch EC2 instance, even when using the same Fedora 42 builder image.
Dual stack endpoint format is ecr.<region>.api.aws
non-dual stack endpoint is: api.ecr.<region>.amazonaws.com
This seems to be a mix of the two with api being prepended to the ecr.<region>.api.aws endpoint by something.

Its unclear to me how or where this is getting incorrectly constructed, but most likely seems like it would be downstream in the JS AWS SDK.

[nairb774]

I saw the same behavior on hosted GitHub Actions runners so this isn't specific to self-hosted. I did a quick look and it looks like ECR dualstack support was added around 3.800.0 of the node ECR client package¹. The latest version of this action (v2.0.1), is running with version 3.418.0².

It looks like the actual code for this action is checked into the dist folder on release, so this might not be fixed till a new release is cut. This repo also looks fairly un-touched in the last 2 years.

Footnotes

1. https://github.com/aws/aws-sdk-js-v3/commits/v3.800.0/clients/client-ecr ↩

2. https://github.com/aws-actions/amazon-ecr-login/blob/v2.0.1/package-lock.json#L169-L170 ↩

[tophercullen]

Good find.

It looks dependabot is still making updates (See: #828) and the main branch of this repo is already 3.8+ https://github.com/aws-actions/amazon-ecr-login/blob/main/package-lock.json#L194

So it appears all that needs to happen, is for there to be a new release.

[tophercullen]

@mattsb42-aws Could you help route this issue? Given there hasn't been anything but minor bot commits to this repo in years, its unclear who, if anyone, responsible for maintaining this project.