Fix YAML serialization for placement constraints (#202)

* Fix build

* Fix tests

Author: trejjam

src/DockerComposeBuilder.Tests/ComposeBuilderTests.cs

@@ -634,7 +634,8 @@ public void SerializeJaegerServiceTest()
                     max_attempts: 10
                     window: "120s"
                   placement:
-                    constraints: ["node.role == worker"]
+                    constraints:
+                    - "node.role == worker"
                     preferences:
                     - spread: "node.labels.zone"
                   resources:
@@ -776,7 +777,8 @@ public void TypedSerializeJaegerServiceTest()
                     max_attempts: 10
                     window: "120s"
                   placement:
-                    constraints: ["node.role == worker"]
+                    constraints:
+                    - "node.role == worker"
                     preferences:
                     - spread: "node.labels.zone"
                   resources:
@@ -1561,7 +1563,9 @@ public void ServiceWithTypedDeployPlacementTest()
                 image: "myapp:latest"
                 deploy:
                   placement:
-                    constraints: ["node.role == worker", "node.labels.zone == us-east"]
+                    constraints:
+                    - "node.role == worker"
+                    - "node.labels.zone == us-east"
                     preferences:
                     - spread: "node.labels.zone"
                     max_replicas_per_node: 2
@@ -1712,7 +1716,8 @@ public void ServiceWithFullTypedDeployConfigTest()
                     delay: "5s"
                     max_attempts: 3
                   placement:
-                    constraints: ["node.role == worker"]
+                    constraints:
+                    - "node.role == worker"
                   resources:
                     limits:
                       cpus: "1"

src/DockerComposeBuilder/Builders/DeployBuilder.cs

@@ -212,7 +212,7 @@ private static Placement MapToPlacement(Map map)
 
         if (map.TryGetValue("constraints", out var c) && c is IEnumerable<object> constraints)
         {
-            placement.Constraints = constraints.Select(x => x.ToString()!).ToArray();
+            placement.Constraints = constraints.Select(x => x.ToString()!).ToList();
         }
 
         if (map.TryGetValue("preferences", out var p) && p is IEnumerable<object> prefs)

src/DockerComposeBuilder/Builders/PlacementBuilder.cs

@@ -11,15 +11,15 @@ internal PlacementBuilder()
     {
     }
 
-    public PlacementBuilder WithConstraints(params IReadOnlyList<string> constraints)
+    public PlacementBuilder WithConstraints(params IReadOnlyCollection<string> constraints)
     {
         if (WorkingObject.Constraints == null)
         {
-            WorkingObject.Constraints = constraints;
+            WorkingObject.Constraints = [.. constraints];
         }
         else
         {
-            WorkingObject.Constraints = WorkingObject.Constraints.Concat(constraints).ToArray();
+            WorkingObject.Constraints = WorkingObject.Constraints.Concat(constraints).ToList();
         }
 
         return this;

src/DockerComposeBuilder/Model/Services/Placement.cs

@@ -8,10 +8,10 @@ namespace DockerComposeBuilder.Model.Services;
 public class Placement
 {
     [YamlMember(Alias = "constraints")]
-    public IReadOnlyList<string>? Constraints { get; set; }
+    public List<string>? Constraints { get; set; }
 
     [YamlMember(Alias = "preferences")]
-    public ICollection<PlacementPreference>? Preferences { get; set; }
+    public List<PlacementPreference>? Preferences { get; set; }
 
     [YamlMember(Alias = "max_replicas_per_node")]
     public int? MaxReplicasPerNode { get; set; }