fix: update remaining references to privatized domain methods in har_recorder and tests

Author: thalissonvs

pydoll/browser/requests/har_recorder.py

@@ -89,8 +89,8 @@ async def start(self) -> None:
         Enables network events if not already on, and registers callbacks
         for the 7 CDP events needed to build HAR entries.
         """
-        if not self._tab.network_events_enabled:
-            await self._tab.enable_network_events()
+        if not self._tab._network_events_enabled:
+            await self._tab._enable_network_events()
             self._network_was_enabled = True
             logger.debug('HAR recorder enabled network events')
 
@@ -130,7 +130,7 @@ async def stop(self) -> None:
         self._flush_pending()
 
         if self._network_was_enabled:
-            await self._tab.disable_network_events()
+            await self._tab._disable_network_events()
             self._network_was_enabled = False
 
         logger.info('HAR recorder stopped, captured %d entries', len(self._entries))

tests/test_browser/test_har_recorder.py

@@ -15,9 +15,9 @@
 async def mock_tab():
     """Create a mock Tab instance for testing."""
     tab = Mock()
-    tab.network_events_enabled = False
-    tab.enable_network_events = AsyncMock()
-    tab.disable_network_events = AsyncMock()
+    tab._network_events_enabled = False
+    tab._enable_network_events = AsyncMock()
+    tab._disable_network_events = AsyncMock()
     tab.on = AsyncMock(side_effect=lambda *a, **kw: len(tab.on.call_args_list))
     tab.remove_callback = AsyncMock()
     tab.clear_callbacks = AsyncMock()
@@ -195,16 +195,16 @@ async def test_start_stores_callback_ids(self, recorder, mock_tab):
 
     @pytest.mark.asyncio
     async def test_start_enables_network_events_if_not_enabled(self, recorder, mock_tab):
-        mock_tab.network_events_enabled = False
+        mock_tab._network_events_enabled = False
         await recorder.start()
-        mock_tab.enable_network_events.assert_called_once()
+        mock_tab._enable_network_events.assert_called_once()
         assert recorder._network_was_enabled is True
 
     @pytest.mark.asyncio
     async def test_start_skips_network_enable_if_already_enabled(self, recorder, mock_tab):
-        mock_tab.network_events_enabled = True
+        mock_tab._network_events_enabled = True
         await recorder.start()
-        mock_tab.enable_network_events.assert_not_called()
+        mock_tab._enable_network_events.assert_not_called()
         assert recorder._network_was_enabled is False
 
     @pytest.mark.asyncio
@@ -243,17 +243,17 @@ async def test_stop_clears_callback_ids(self, recorder, mock_tab):
 
     @pytest.mark.asyncio
     async def test_stop_disables_network_events_if_we_enabled(self, recorder, mock_tab):
-        mock_tab.network_events_enabled = False
+        mock_tab._network_events_enabled = False
         await recorder.start()
         await recorder.stop()
-        mock_tab.disable_network_events.assert_called_once()
+        mock_tab._disable_network_events.assert_called_once()
 
     @pytest.mark.asyncio
     async def test_stop_does_not_disable_network_events_if_not_ours(self, recorder, mock_tab):
-        mock_tab.network_events_enabled = True
+        mock_tab._network_events_enabled = True
         await recorder.start()
         await recorder.stop()
-        mock_tab.disable_network_events.assert_not_called()
+        mock_tab._disable_network_events.assert_not_called()
 
     @pytest.mark.asyncio
     async def test_stop_flushes_pending_entries(self, recorder, mock_tab):
@@ -748,10 +748,10 @@ async def test_record_yields_har_recording(self, request_instance):
 
     @pytest.mark.asyncio
     async def test_record_enables_network_events(self, request_instance, mock_tab):
-        mock_tab.network_events_enabled = False
+        mock_tab._network_events_enabled = False
         async with request_instance.record():
             pass
-        mock_tab.enable_network_events.assert_called_once()
+        mock_tab._enable_network_events.assert_called_once()
 
     @pytest.mark.asyncio
     async def test_record_registers_and_removes_callbacks(self, request_instance, mock_tab):
@@ -771,19 +771,19 @@ async def test_record_cleans_up_on_exception(self, request_instance, mock_tab):
     async def test_record_disables_network_events_if_enabled_by_recorder(
         self, request_instance, mock_tab
     ):
-        mock_tab.network_events_enabled = False
+        mock_tab._network_events_enabled = False
         async with request_instance.record():
             pass
-        mock_tab.disable_network_events.assert_called_once()
+        mock_tab._disable_network_events.assert_called_once()
 
     @pytest.mark.asyncio
     async def test_record_does_not_disable_network_events_if_already_enabled(
         self, request_instance, mock_tab
     ):
-        mock_tab.network_events_enabled = True
+        mock_tab._network_events_enabled = True
         async with request_instance.record():
             pass
-        mock_tab.disable_network_events.assert_not_called()
+        mock_tab._disable_network_events.assert_not_called()
 
 
 class TestResourceTypeFiltering:

tests/test_browser/test_requests_request.py

@@ -20,9 +20,9 @@
 async def mock_tab():
     """Create a mock Tab instance for testing."""
     tab = Mock()
-    tab.network_events_enabled = False
-    tab.enable_network_events = AsyncMock()
-    tab.disable_network_events = AsyncMock()
+    tab._network_events_enabled = False
+    tab._enable_network_events = AsyncMock()
+    tab._disable_network_events = AsyncMock()
     tab.remove_callback = AsyncMock()
     tab.on = AsyncMock(side_effect=lambda *a, **kw: len(tab.on.call_args_list))
     tab._execute_command = AsyncMock()
@@ -366,21 +366,21 @@ class TestRequestCallbackManagement:
     @pytest.mark.asyncio
     async def test_register_callbacks_enables_network_events(self, request_instance, mock_tab):
         """Test that registering callbacks enables network events."""
-        mock_tab.network_events_enabled = False
+        mock_tab._network_events_enabled = False
 
         await request_instance._register_callbacks()
 
-        mock_tab.enable_network_events.assert_called_once()
+        mock_tab._enable_network_events.assert_called_once()
         assert request_instance._network_events_enabled is True
 
     @pytest.mark.asyncio
     async def test_register_callbacks_skips_if_already_enabled(self, request_instance, mock_tab):
         """Test that network events are not re-enabled if already active."""
-        mock_tab.network_events_enabled = True
+        mock_tab._network_events_enabled = True
 
         await request_instance._register_callbacks()
 
-        mock_tab.enable_network_events.assert_not_called()
+        mock_tab._enable_network_events.assert_not_called()
         assert request_instance._network_events_enabled is False
 
     @pytest.mark.asyncio
@@ -409,7 +409,7 @@ async def test_clear_callbacks_disables_network_events(self, request_instance, m
 
         await request_instance._clear_callbacks()
 
-        mock_tab.disable_network_events.assert_called_once()
+        mock_tab._disable_network_events.assert_called_once()
         assert mock_tab.remove_callback.call_count == 4
         assert request_instance._network_events_enabled is False
         assert request_instance._callback_ids == []
@@ -422,7 +422,7 @@ async def test_clear_callbacks_skips_disable_if_not_enabled(self, request_instan
 
         await request_instance._clear_callbacks()
 
-        mock_tab.disable_network_events.assert_not_called()
+        mock_tab._disable_network_events.assert_not_called()
         assert mock_tab.remove_callback.call_count == 2
         assert request_instance._callback_ids == []