ci: fixing mypy issues

Author: LucasAlvws

pydoll/browser/firefox/base.py

@@ -6,9 +6,10 @@
 import tempfile
 from abc import ABC, abstractmethod
 from random import randint
-from typing import TYPE_CHECKING, Any, Awaitable, Callable, Optional, overload
+from typing import Any, Awaitable, Callable, Optional, overload
 
 from pydoll.browser.firefox.tab import FirefoxTab
+from pydoll.browser.interfaces import BrowserOptionsManager, Options
 from pydoll.browser.managers import BrowserProcessManager, TempDirectoryManager
 from pydoll.connection.bidi_connection_handler import BiDiConnectionHandler
 from pydoll.exceptions import (
@@ -18,10 +19,6 @@
 )
 from pydoll.protocol.bidi import browsing_context, script, session
 
-if TYPE_CHECKING:
-    from pydoll.browser.firefox_options import FirefoxOptions
-    from pydoll.browser.interfaces import BrowserOptionsManager
-
 logger = logging.getLogger(__name__)
 
 
@@ -46,7 +43,7 @@ def __init__(
             connection_port: BiDi WebSocket port. Random port (9223-9322) if None.
         """
         self._validate_connection_port(connection_port)
-        self.options: FirefoxOptions = options_manager.initialize_options()
+        self.options: Options = options_manager.initialize_options()
         self._connection_port = connection_port if connection_port else randint(9223, 9322)
         self._browser_process_manager = BrowserProcessManager()
         self._temp_directory_manager = TempDirectoryManager()
@@ -99,7 +96,7 @@ async def start(self) -> FirefoxTab:
         })
         await self._hide_automation_signals()
 
-        response = await self._connection_handler.execute_command(browsing_context.get_tree())
+        response: dict = await self._connection_handler.execute_command(browsing_context.get_tree())
         contexts = response.get('result', {}).get('contexts', [])
         if not contexts:
             raise FailedToStartBrowser('No browsing contexts found after start')
@@ -140,7 +137,7 @@ async def new_tab(self, url: str = '') -> FirefoxTab:
             New FirefoxTab instance.
         """
         logger.info('Creating new Firefox tab')
-        response = await self._connection_handler.execute_command(browsing_context.create())
+        response: dict = await self._connection_handler.execute_command(browsing_context.create())
         context_id = response['result']['context']
         tab = FirefoxTab(context_id, self._connection_handler)
         self._tabs[context_id] = tab
@@ -155,7 +152,7 @@ async def get_opened_tabs(self) -> list[FirefoxTab]:
         Returns:
             List of FirefoxTab instances.
         """
-        response = await self._connection_handler.execute_command(browsing_context.get_tree())
+        response: dict = await self._connection_handler.execute_command(browsing_context.get_tree())
         contexts = response.get('result', {}).get('contexts', [])
         tabs = []
         for ctx in contexts:
@@ -345,14 +342,11 @@ def _write_user_js(profile_dir: str) -> None:
             ('marionette.enabled', False),
             ('toolkit.legacyUserProfileCustomizations.stylesheets', True),
             ('devtools.debugger.prompt-connection', False),
-            # Disable automation/testing-specific UI and features
             ('browser.aboutConfig.showWarning', False),
             ('browser.shell.checkDefaultBrowser', False),
             ('browser.startup.homepage_override.mstone', 'ignore'),
-            # Reduce fingerprinting surface without breaking functionality
             ('privacy.resistFingerprinting', False),
             ('privacy.trackingprotection.enabled', False),
-            # Suppress first-run dialogs and telemetry
             ('datareporting.healthreport.uploadEnabled', False),
             ('datareporting.policy.dataSubmissionEnabled', False),
             ('toolkit.telemetry.enabled', False),

pydoll/browser/firefox/element.py

@@ -11,7 +11,6 @@
 
 logger = logging.getLogger(__name__)
 
-# WebDriver special key values (Unicode private use area)
 KEYS = {
     'ctrl': '\ue009',
     'shift': '\ue008',
@@ -211,7 +210,7 @@ async def inner_html(self) -> str:
 
     async def _call_function(self, function_declaration: str) -> Any:
         """Call a JS function with this element as the first argument."""
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             script.call_function(
                 function_declaration=function_declaration,
                 context=self._context_id,

pydoll/browser/firefox/firefox.py

@@ -51,9 +51,6 @@ def _get_default_binary_location() -> str:
                 r'C:\Program Files (x86)\Mozilla Firefox\firefox.exe',
             ],
             'Linux': [
-                # Prefer the real snap binary over the wrapper scripts —
-                # the wrappers (/usr/bin/firefox, /snap/bin/firefox) silently
-                # drop unknown flags like --remote-debugging-port.
                 '/snap/firefox/current/usr/lib/firefox/firefox',
                 '/usr/lib/firefox/firefox',
                 '/usr/bin/firefox-esr',

pydoll/browser/firefox/tab.py

@@ -8,7 +8,7 @@
 from pydoll.browser.firefox.element import KEYS, FirefoxElement
 from pydoll.protocol.bidi import browsing_context, network, script, session, storage
 from pydoll.protocol.bidi import input as bidi_input
-from pydoll.protocol.bidi.network import InterceptPhase, NetworkEvent
+from pydoll.protocol.bidi.network import Header, InterceptPhase, NetworkEvent
 
 if TYPE_CHECKING:
     from pydoll.connection.bidi_connection_handler import BiDiConnectionHandler
@@ -54,7 +54,7 @@ async def go_to(self, url: str, wait: str = 'complete') -> dict:
             Navigation result dict with 'url' key.
         """
         logger.info(f'Navigating to {url} (context={self._context_id})')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             browsing_context.navigate(self._context_id, url, wait)
         )
         return response['result']
@@ -71,7 +71,7 @@ async def evaluate(self, expression: str, await_promise: bool = True) -> Any:
             The JavaScript result value.
         """
         logger.debug(f'Evaluating expression in context={self._context_id}')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             script.evaluate(expression, self._context_id, await_promise)
         )
         result = response.get('result', {})
@@ -100,7 +100,7 @@ async def find(
             f'Finding nodes: selector={selector!r}, type={selector_type}, '
             f'context={self._context_id}'
         )
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             browsing_context.locate_nodes(self._context_id, locator, max_node_count)
         )
         nodes = response.get('result', {}).get('nodes', [])
@@ -114,7 +114,7 @@ async def take_screenshot(self) -> bytes:
             PNG screenshot as bytes.
         """
         logger.debug(f'Taking screenshot: context={self._context_id}')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             browsing_context.capture_screenshot(self._context_id)
         )
         data = response.get('result', {}).get('data', '')
@@ -209,7 +209,7 @@ async def get_cookies(self) -> list[dict]:
             httpOnly, secure, sameSite, expiry, etc.
         """
         logger.debug(f'Getting cookies: context={self._context_id}')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             storage.get_cookies(self._context_id)
         )
         return response.get('result', {}).get('cookies', [])
@@ -314,7 +314,7 @@ async def refresh(self, wait: str = 'complete') -> dict:
             Reload result dict with 'url' key.
         """
         logger.info(f'Refreshing context={self._context_id}')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             browsing_context.reload(self._context_id, wait)
         )
         return response.get('result', {})
@@ -327,7 +327,7 @@ async def go_back(self) -> dict:
             TraverseHistory result dict.
         """
         logger.info(f'Going back: context={self._context_id}')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             browsing_context.traverse_history(self._context_id, delta=-1)
         )
         return response.get('result', {})
@@ -340,7 +340,7 @@ async def go_forward(self) -> dict:
             TraverseHistory result dict.
         """
         logger.info(f'Going forward: context={self._context_id}')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             browsing_context.traverse_history(self._context_id, delta=1)
         )
         return response.get('result', {})
@@ -388,7 +388,7 @@ async def add_intercept(
         if phases is None:
             phases = [InterceptPhase.BEFORE_REQUEST_SENT]
         logger.info(f'Adding intercept phases={phases}: context={self._context_id}')
-        response = await self._connection_handler.execute_command(
+        response: dict = await self._connection_handler.execute_command(
             network.add_intercept(
                 phases=phases,
                 contexts=[self._context_id],
@@ -407,7 +407,7 @@ async def continue_request(
         request_id: str,
         url: Optional[str] = None,
         method: Optional[str] = None,
-        headers: Optional[list[dict]] = None,
+        headers: Optional[list[Header]] = None,
         body: Optional[str] = None,
     ) -> None:
         """
@@ -440,7 +440,7 @@ async def provide_response(
         self,
         request_id: str,
         status_code: int = 200,
-        headers: Optional[list[dict]] = None,
+        headers: Optional[list[Header]] = None,
         body: Optional[str] = None,
         reason_phrase: Optional[str] = None,
     ) -> None:
@@ -468,7 +468,7 @@ async def continue_response(
         self,
         request_id: str,
         status_code: Optional[int] = None,
-        headers: Optional[list[dict]] = None,
+        headers: Optional[list[Header]] = None,
         reason_phrase: Optional[str] = None,
     ) -> None:
         """
@@ -526,7 +526,7 @@ async def new_tab(self, url: str = '') -> FirefoxTab:
             New FirefoxTab instance.
         """
         logger.info('Creating new tab')
-        response = await self._connection_handler.execute_command(browsing_context.create())
+        response: dict = await self._connection_handler.execute_command(browsing_context.create())
         context_id = response['result']['context']
         tab = FirefoxTab(context_id, self._connection_handler)
         if url:

pydoll/connection/bidi_connection_handler.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import logging
-from typing import TYPE_CHECKING, Optional
+from typing import TYPE_CHECKING, Any, Optional
 
 from pydoll.connection.connection_handler import ConnectionHandler
 from pydoll.exceptions import BiDiCommandError
@@ -43,7 +43,7 @@ async def execute_command(
         Raises:
             BiDiCommandError: If the browser returns a BiDi error response.
         """
-        response = await super().execute_command(command, timeout)
+        response: Any = await super().execute_command(command, timeout)
         if response.get('type') == 'error':
             error = response.get('error', 'unknown')
             message = response.get('message', '')
@@ -64,7 +64,7 @@ async def new_session(self, capabilities: Optional[dict] = None) -> dict:
             Full response dict from the browser.
         """
         command = session_module.new_session(capabilities)
-        response = await self.execute_command(command)
+        response: dict = await self.execute_command(command)
         self._session_id = response.get('result', {}).get('sessionId')
         logger.info(f'BiDi session established: sessionId={self._session_id}')
         return response

pydoll/protocol/bidi/network.py

@@ -6,9 +6,10 @@
 
 from pydoll.protocol.base import Command, EmptyResponse, Response
 
-# ---------------------------------------------------------------------------
-# Shared types
-# ---------------------------------------------------------------------------
+
+class BytesValue(TypedDict):
+    type: str
+    value: str
 
 
 class Header(TypedDict):
@@ -22,26 +23,16 @@ def make_header(name: str, value: str) -> Header:
 
 
 class UrlPatternString(TypedDict):
-    type: str  # 'string'
+    type: str
     pattern: str
 
 
-class BytesValue(TypedDict):
-    type: str  # 'string' | 'base64'
-    value: str
-
-
 class AuthCredentials(TypedDict):
-    type: str  # 'password'
+    type: str
     username: str
     password: str
 
 
-# ---------------------------------------------------------------------------
-# Command params
-# ---------------------------------------------------------------------------
-
-
 class AddInterceptParams(TypedDict):
     phases: list[str]
     contexts: NotRequired[list[str]]
@@ -69,7 +60,7 @@ class ContinueResponseParams(TypedDict):
 
 class ContinueWithAuthParams(TypedDict):
     request: str
-    action: str  # 'provideCredentials' | 'default' | 'cancel'
+    action: str
     credentials: NotRequired[AuthCredentials]
 
 
@@ -85,19 +76,10 @@ class ProvideResponseParams(TypedDict):
     statusCode: NotRequired[int]
 
 
-# ---------------------------------------------------------------------------
-# Result types
-# ---------------------------------------------------------------------------
-
-
 class AddInterceptResult(TypedDict):
     intercept: str
 
 
-# ---------------------------------------------------------------------------
-# Response / Command aliases
-# ---------------------------------------------------------------------------
-
 AddInterceptResponse = Response[AddInterceptResult]
 RemoveInterceptResponse = Response[EmptyResponse]
 ContinueRequestResponse = Response[EmptyResponse]
@@ -115,11 +97,6 @@ class AddInterceptResult(TypedDict):
 ProvideResponseCommand = Command[ProvideResponseParams, ProvideResponseResponse]
 
 
-# ---------------------------------------------------------------------------
-# Event name constants
-# ---------------------------------------------------------------------------
-
-
 class NetworkEvent:
     """BiDi network event name constants."""
 
@@ -138,22 +115,14 @@ class NetworkEvent:
     ]
 
 
-# ---------------------------------------------------------------------------
-# Intercept phases
-# ---------------------------------------------------------------------------
-
-
 class InterceptPhase:
+    """BiDi network intercept phase constants."""
+
     BEFORE_REQUEST_SENT = 'beforeRequestSent'
     RESPONSE_STARTED = 'responseStarted'
     AUTH_REQUIRED = 'authRequired'
 
 
-# ---------------------------------------------------------------------------
-# Factory functions
-# ---------------------------------------------------------------------------
-
-
 def add_intercept(
     phases: list[str],
     contexts: Optional[list[str]] = None,
@@ -163,9 +132,9 @@ def add_intercept(
     Register a network intercept.
 
     Args:
-        phases: List of phases to intercept. Use ``InterceptPhase`` constants.
-        contexts: Browsing context IDs to scope the intercept to (tab-level).
-        url_patterns: Optional URL glob patterns to match (e.g. '*://example.com/*').
+        phases: Phases to intercept. Use ``InterceptPhase`` constants.
+        contexts: Browsing context IDs to scope the intercept to.
+        url_patterns: URL patterns to match (must be valid URL pattern strings).
 
     Returns:
         Command dict for ``network.addIntercept``.
@@ -226,6 +195,10 @@ def continue_with_auth(
     username: Optional[str] = None,
     password: Optional[str] = None,
 ) -> ContinueWithAuthCommand:
+    """
+    Args:
+        action: ``'provideCredentials'``, ``'default'``, or ``'cancel'``.
+    """
     params = ContinueWithAuthParams(request=request_id, action=action)
     if action == 'provideCredentials' and username is not None and password is not None:
         params['credentials'] = AuthCredentials(