Result of Generator::evaluate_condition()

[Kijewski]

If the result is EvaluatedResult::AlwaysTrue, then what is the meaning of the returned Expr? Isn't it bound to be the literal true? AlwaysFalse vice versa.

[GuillaumeGomez]

Not necessarily. It could be if x is defined || y is not defined. Since is defined is known at compile time, we can evaluate it at compile time. So for now, is defined and true/false are the only cases as far as I can remember. They can be intricated though as demonstrated, hence why it goes recursively.

[Kijewski]

But can the result be the tuple (EvaluatedResult::AlwaysFalse, Expr::NotABoolean)?

[GuillaumeGomez]

Ah ok I got your question. So no, if EvaluatedResult is AlwaysTrue or AlwaysFalse, then the Expr is always a boolean.

[Kijewski]

Exactly! :) Maybe the Enum could be converted to AlwaysTrue | AlwaysFalse | Unknown(Expr)?

[GuillaumeGomez]

Sounds good to me!

[Kijewski]

I'll give it a try! :)