Add CI workflows for Python and Chrome extension unit tests

- Introduced a new GitHub Actions workflow for Python unit tests, including setup for dependencies and test execution.
- Added a separate workflow for Chrome extension unit tests using Vitest, with appropriate setup and test commands.
- Updated the create-release workflow to exclude test files and unnecessary directories from the release packages.
- Added configuration files for Vitest and created initial test cases for the Chrome extension.
- Enhanced Docker ignore files to exclude test and cache directories for both API and worker services.

Author: asdfghj1237890

.github/workflows/ci.yml

@@ -9,6 +9,55 @@ on:
     branches: [main]
 
 jobs:
+  python-unit:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup uv
+        uses: astral-sh/setup-uv@v5
+
+      - name: Setup Python
+        run: uv python install 3.11
+
+      - name: Install Python test dependencies
+        run: |
+          uv venv --python 3.11
+          uv pip install pytest \
+            -r video-downloader/docker/worker/requirements.txt \
+            -r video-downloader/docker/api/requirements.txt
+
+      - name: Run Python unit tests (worker + api)
+        run: |
+          uv run pytest -q \
+            video-downloader/docker/worker/tests \
+            video-downloader/docker/api/tests
+
+  chrome-extension-unit:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash
+        working-directory: chrome-extension
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+
+      - name: Install dependencies
+        run: npm install
+
+      - name: Run unit tests
+        run: npm test
+
   api-smoke:
     runs-on: ubuntu-latest
     defaults:

.github/workflows/create-release.yml

@@ -45,12 +45,20 @@ jobs:
       - name: 'Create chrome-extension package'
         run: |
           cd chrome-extension
-          zip -r ../WebVideo2NAS-chrome-extension.zip .
+          zip -r ../WebVideo2NAS-chrome-extension.zip . \
+            -x "tests/*" "tests/**" \
+               "node_modules/*" "node_modules/**" \
+               "vitest.config.js" \
+               "package.json" "package-lock.json"
 
       - name: 'Create docker package'
         run: |
           cd video-downloader
-          zip -r ../WebVideo2NAS-downloader-docker.zip .
+          zip -r ../WebVideo2NAS-downloader-docker.zip . \
+            -x "docker/api/tests/*" "docker/api/tests/**" \
+               "docker/worker/tests/*" "docker/worker/tests/**" \
+               "**/__pycache__/**" "**/.pytest_cache/**" \
+               "*.pyc" "*.pyo" "*.pyd"
 
       - name: 'Create Release'
         uses: softprops/action-gh-release@v2

chrome-extension/package.json

@@ -0,0 +1,14 @@
+{
+  "name": "webvideo2nas-chrome-extension",
+  "private": true,
+  "version": "0.0.0",
+  "description": "Unit tests for WebVideo2NAS Chrome extension",
+  "devDependencies": {
+    "vitest": "^2.1.8",
+    "jsdom": "^25.0.1"
+  },
+  "scripts": {
+    "test": "vitest run",
+    "test:watch": "vitest"
+  }
+}

chrome-extension/sidepanel.js

@@ -673,7 +673,8 @@ function extractQualitiesFromUrl(url) {
   const found = new Set();
 
   // Common patterns: "...1080p...", "..._720p...", "/480p/", etc.
-  const pMatches = lower.matchAll(/(?:^|[^0-9])([0-9]{3,4})p(?:$|[^a-z0-9])/g);
+  // Use lookarounds so multiple adjacent matches (e.g. "...720p_1080p...") are not skipped.
+  const pMatches = lower.matchAll(/(?<![0-9])([0-9]{3,4})p(?![a-z0-9])/g);
   for (const m of pMatches) {
     const n = Number(m[1]);
     if (allowed.has(n)) found.add(n);

chrome-extension/tests/background.test.js

@@ -0,0 +1,152 @@
+import { describe, expect, it } from 'vitest';
+
+import { loadScriptIntoContext } from './helpers/load-script.js';
+
+function makeChromeStub() {
+  return {
+    runtime: {
+      sendMessage: () => {},
+      lastError: null,
+      onInstalled: { addListener: () => {} },
+      onMessage: { addListener: () => {} },
+      openOptionsPage: () => {},
+      getManifest: () => ({ version: '0.0.0' }),
+    },
+    storage: {
+      sync: {
+        get: (_keys, cb) => cb({}),
+        set: async () => {},
+      },
+      local: {
+        set: async () => {},
+        get: async () => ({}),
+      },
+      onChanged: { addListener: () => {} },
+    },
+    webRequest: {
+      onBeforeRequest: { addListener: () => {} },
+      onSendHeaders: { addListener: () => {} },
+    },
+    action: {
+      setBadgeText: () => {},
+      setBadgeBackgroundColor: () => {},
+      onClicked: { addListener: () => {} },
+    },
+    tabs: {
+      onRemoved: { addListener: () => {} },
+      onUpdated: { addListener: () => {} },
+      onActivated: { addListener: () => {} },
+      query: (_q, cb) => cb([]),
+      get: (_id, cb) => cb(null),
+    },
+    webNavigation: {
+      onCommitted: { addListener: () => {} },
+    },
+    contextMenus: {
+      create: () => {},
+      onClicked: { addListener: () => {} },
+    },
+    notifications: {
+      create: () => {},
+    },
+    sidePanel: {
+      open: async () => {},
+    },
+    cookies: {
+      getAll: async () => [],
+    },
+  };
+}
+
+function withFixedNow(ctx, nowMs) {
+  ctx.Date = class extends Date {
+    static now() {
+      return nowMs;
+    }
+  };
+}
+
+describe('background.js pure helpers', () => {
+  it('isCandidateVideoUrl accepts m3u8/mp4 and rejects obvious non-video', () => {
+    const ctx = loadScriptIntoContext('background.js', {
+      chrome: makeChromeStub(),
+      fetch: async () => ({ ok: true, json: async () => ({}) }),
+    });
+
+    expect(ctx.isCandidateVideoUrl('https://a/b/c.m3u8')).toBe(true);
+    expect(ctx.isCandidateVideoUrl('https://a/b/c.mp4')).toBe(true);
+
+    // segments
+    expect(ctx.isCandidateVideoUrl('https://a/b/seg0001.ts')).toBe(false);
+    expect(ctx.isCandidateVideoUrl('https://a/b/seg0001.m4s')).toBe(false);
+
+    // false positives
+    expect(ctx.isCandidateVideoUrl('https://a/b/preview_720p.mp4.jpg')).toBe(false);
+    expect(ctx.isCandidateVideoUrl('https://a/b/playlist.m3u8.png')).toBe(false);
+    expect(ctx.isCandidateVideoUrl('https://a/b/app.js?video=1.mp4')).toBe(false);
+  });
+
+  it('scoreUrlInfo prefers recent + range hits + media type', () => {
+    const ctx = loadScriptIntoContext('background.js', {
+      chrome: makeChromeStub(),
+    });
+
+    const now = 1_000_000;
+    withFixedNow(ctx, now);
+
+    const base = {
+      url: 'https://cdn.example.com/v/video.mp4',
+      timestamp: now - 5_000,
+      requestType: 'media',
+      hitCount: 1,
+      rangeHitCount: 0,
+    };
+
+    const s1 = ctx.scoreUrlInfo(base);
+    const s2 = ctx.scoreUrlInfo({ ...base, rangeHitCount: 1 });
+    const s3 = ctx.scoreUrlInfo({ ...base, rangeHitCount: 1, hitCount: 10 });
+
+    expect(s2).toBeGreaterThan(s1);
+    expect(s3).toBeGreaterThan(s2);
+  });
+
+  it('getSortedUrlsForTab marks a clear winner as now playing', () => {
+    const ctx = loadScriptIntoContext('background.js', {
+      chrome: makeChromeStub(),
+    });
+
+    const now = 2_000_000;
+    withFixedNow(ctx, now);
+
+    const tabId = 123;
+    ctx.__eval(`currentTabUrls[${tabId}] = ${JSON.stringify([
+      {
+        url: 'https://cdn.example.com/v/low.m3u8',
+        timestamp: now - 60_000,
+        requestType: 'xmlhttprequest',
+        hitCount: 1,
+        rangeHitCount: 0,
+      },
+      {
+        url: 'https://cdn.example.com/v/high.mp4',
+        timestamp: now - 2_000,
+        requestType: 'media',
+        hitCount: 3,
+        rangeHitCount: 2,
+      },
+    ])};`);
+
+    const sorted = ctx.getSortedUrlsForTab(tabId);
+    expect(sorted[0].url).toContain('high.mp4');
+    expect(sorted[0].isNowPlaying).toBe(true);
+  });
+
+  it('safeOrigin returns null on invalid URL', () => {
+    const ctx = loadScriptIntoContext('background.js', {
+      chrome: makeChromeStub(),
+    });
+
+    expect(ctx.safeOrigin('https://example.com/a')).toBe('https://example.com');
+    expect(ctx.safeOrigin('not a url')).toBe(null);
+  });
+});

chrome-extension/tests/helpers/load-script.js

@@ -0,0 +1,27 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+
+export function loadScriptIntoContext(scriptPath, context = {}) {
+  const abs = path.isAbsolute(scriptPath) ? scriptPath : path.resolve(process.cwd(), scriptPath);
+  const code = fs.readFileSync(abs, 'utf-8');
+
+  const ctx = vm.createContext({
+    console,
+    URL,
+    setTimeout,
+    clearTimeout,
+    // Default: disable intervals unless test explicitly wants them
+    setInterval: () => 0,
+    clearInterval: () => {},
+    ...context,
+  });
+
+  // Execute as a script in the provided context.
+  vm.runInContext(code, ctx, { filename: abs });
+
+  // Allow tests to mutate top-level `let` variables inside the context
+  // (they are not exposed as properties on `ctx`).
+  ctx.__eval = (js) => vm.runInContext(String(js), ctx);
+  return ctx;
+}

chrome-extension/tests/sidepanel.test.js

@@ -0,0 +1,86 @@
+import { describe, expect, it } from 'vitest';
+
+import { loadScriptIntoContext } from './helpers/load-script.js';
+
+function makeChromeStub() {
+  return {
+    storage: {
+      sync: { get: async () => ({}) },
+      onChanged: { addListener: () => {} },
+    },
+    runtime: {
+      onMessage: { addListener: () => {} },
+      openOptionsPage: () => {},
+      sendMessage: (_msg, cb) => cb && cb({ urls: [] }),
+      lastError: null,
+    },
+    tabs: {
+      query: (_q, cb) => cb([{ id: 1, title: 't', url: 'https://example.com' }]),
+      onUpdated: { addListener: () => {} },
+      onActivated: { addListener: () => {} },
+    },
+  };
+}
+
+function makeDocumentStub() {
+  return {
+    addEventListener: () => {},
+    getElementById: () => null,
+    createElement: () => ({
+      textContent: '',
+      innerHTML: '',
+    }),
+    body: { appendChild: () => {} },
+  };
+}
+
+describe('sidepanel.js helper functions', () => {
+  it('extractQualitiesFromUrl finds and sorts unique qualities', () => {
+    const ctx = loadScriptIntoContext('sidepanel.js', {
+      chrome: makeChromeStub(),
+      document: makeDocumentStub(),
+      navigator: { clipboard: { writeText: async () => {} } },
+      fetch: async () => ({ ok: true, json: async () => ({}) }),
+      window: {},
+    });
+
+    const q = ctx.extractQualitiesFromUrl('https://a/b/video_720p_1080p.mp4?quality=720&res=2160');
+    expect(q).toEqual(['2160p', '1080p', '720p']);
+    expect(ctx.getMaxQualityNumber('https://a/b/480p/playlist.m3u8')).toBe(480);
+  });
+
+  it('formatDuration outputs mm:ss or hh:mm:ss', () => {
+    const ctx = loadScriptIntoContext('sidepanel.js', {
+      chrome: makeChromeStub(),
+      document: makeDocumentStub(),
+      window: {},
+    });
+
+    expect(ctx.formatDuration(59)).toBe('00:59');
+    expect(ctx.formatDuration(61)).toBe('01:01');
+    expect(ctx.formatDuration(3600)).toBe('01:00:00');
+  });
+
+  it('containsIpAddress detects ip= query parameter', () => {
+    const ctx = loadScriptIntoContext('sidepanel.js', {
+      chrome: makeChromeStub(),
+      document: makeDocumentStub(),
+      window: {},
+    });
+
+    expect(ctx.containsIpAddress('https://a/b/c?ip=114.24.18.78')).toBe(true);
+    expect(ctx.containsIpAddress('https://a/b/114.24.18.78/video.mp4')).toBe(false);
+  });
+
+  it('connectionReasonFromError maps AbortError to timeout key when i18n is missing', () => {
+    const ctx = loadScriptIntoContext('sidepanel.js', {
+      chrome: makeChromeStub(),
+      document: makeDocumentStub(),
+      window: {},
+    });
+
+    const err = new Error('x');
+    err.name = 'AbortError';
+    expect(ctx.connectionReasonFromError(err)).toBe('error.timeout.type');
+  });
+});

chrome-extension/vitest.config.js

@@ -0,0 +1,8 @@
+import { defineConfig } from 'vitest/config';
+
+export default defineConfig({
+  test: {
+    environment: 'jsdom',
+    include: ['tests/**/*.test.js'],
+  },
+});

video-downloader/docker/api/.dockerignore

@@ -0,0 +1,8 @@
+# Exclude tests and Python caches from image build context
+tests/
+__pycache__/
+.pytest_cache/
+*.pyc
+*.pyo
+*.pyd
+*.log

video-downloader/docker/api/tests/conftest.py

@@ -0,0 +1,7 @@
+import sys
+from pathlib import Path
+
+# Allow importing api modules that use flat imports.
+API_DIR = Path(__file__).resolve().parents[1]
+if str(API_DIR) not in sys.path:
+    sys.path.insert(0, str(API_DIR))