v2.1.2: pin video title to its source tab (fix multi-tab mismatch)

In a multi-tab session, clicking Send to NAS for a URL detected in tab A
could attach tab B's title if the user switched tabs before clicking —
the side panel was reading the active tab's title at click time. The
background service worker now stamps each detected URL's urlInfo with
the page title captured at detection time (chrome.tabs.get on the URL's
own tabId, not the active tab) and looks it up via getStoredPageTitle()
when handling sendToNAS. The side panel no longer queries the active
tab for the title.

Adds a Vitest regression test pinning the lookup behaviour: two URLs
registered under different tabIds resolve to their own page titles.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: asdfghj1237890

README.md

@@ -344,6 +344,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 <details>
 <summary><strong>Full Changelog (click to expand)</strong></summary>
 
+### [2.1.2] - 2026-04-27
+
+#### Fixed
+- **Multi-tab title mismatch**: when several tabs were open, sending a video to NAS could attach the wrong tab's title to the URL — the side panel was using the *active* tab's title at click time instead of the title of the tab where the URL was actually detected. The background service worker now records the page title at URL-detection time and uses that as the source of truth, so switching tabs before clicking *Send* no longer poisons the filename
+
 ### [2.1.1] - 2026-04-27
 
 #### Fixed
@@ -616,7 +621,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
-**Version**: 2.1.1  
+**Version**: 2.1.2  
 **Last Updated**: 2026-04-27  
 **Port**: 52052 (NAS host port → API container :8000)
 

chrome-extension/background.js

@@ -457,6 +457,22 @@ function isCandidateVideoUrl(rawUrl) {
   return true;
 }
 
+// Capture the tab's current title and stamp it onto the urlInfo. Async because
+// chrome.tabs.get is async — by the time we resolve, the urlInfo is already in
+// the store, so we mutate the live object. Best-effort; missing title is OK.
+function attachTabTitle(urlInfo, tabId) {
+  if (tabId == null || tabId < 0) return;
+  try {
+    chrome.tabs.get(tabId, (tab) => {
+      if (chrome.runtime.lastError || !tab) return;
+      const title = tab.title;
+      // Only overwrite if we got a real title — keeps a previously-captured
+      // good title if a later fetch races with a transient empty state.
+      if (title && title.trim()) urlInfo.pageTitle = title;
+    });
+  } catch (_) { /* ignore */ }
+}
+
 // Register a detected video URL into per-tab and orphan stores.
 // `extra` may carry additional fields like `detectedFormat`.
 function registerDetectedUrl(details, extra) {
@@ -467,6 +483,7 @@ function registerDetectedUrl(details, extra) {
     tabId: isRealTab ? details.tabId : -1,
     timestamp: Date.now(),
     pageUrl: details.initiator || details.documentUrl,
+    pageTitle: '',  // populated async by attachTabTitle below
     requestType: details.type,
     frameId: details.frameId,
     method: details.method,
@@ -488,6 +505,7 @@ function registerDetectedUrl(details, extra) {
     if (!currentTabUrlKeys[details.tabId].has(details.url)) {
       currentTabUrlKeys[details.tabId].add(details.url);
       currentTabUrls[details.tabId].push(urlInfo);
+      attachTabTitle(urlInfo, details.tabId);
     } else {
       const list = currentTabUrls[details.tabId];
       const existing = list.find(item => item && item.url === details.url);
@@ -501,6 +519,9 @@ function registerDetectedUrl(details, extra) {
         if (extra && extra.detectedFormat && !existing.detectedFormat) {
           existing.detectedFormat = extra.detectedFormat;
         }
+        // Refresh title in case the first capture raced with a transient
+        // empty-title state (loading SPA, etc).
+        if (!existing.pageTitle) attachTabTitle(existing, details.tabId);
         notifyDetectedUrlsUpdated(details.tabId);
       }
     }
@@ -740,6 +761,23 @@ function getDetectedFormat(url) {
   return null;
 }
 
+// Find the page title that was captured when a URL was first detected.
+// This is the source of truth for "what tab/page this URL came from" — using
+// it avoids the multi-tab bug where the active tab at click-time could be
+// different from the tab the URL was actually detected on.
+function getStoredPageTitle(url) {
+  for (const tabId of Object.keys(currentTabUrls)) {
+    const list = currentTabUrls[tabId];
+    if (!Array.isArray(list)) continue;
+    const item = list.find(x => x && x.url === url);
+    if (item && item.pageTitle) return item.pageTitle;
+  }
+  for (const item of orphanUrlInfos) {
+    if (item && item.url === url && item.pageTitle) return item.pageTitle;
+  }
+  return null;
+}
+
 // Send URL to NAS
 async function sendToNAS(url, pageTitle, pageUrl) {
   try {
@@ -1167,7 +1205,14 @@ chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {
   }
 
   if (request.action === 'sendToNAS') {
-    sendToNAS(request.url, request.title, request.pageUrl);
+    // Prefer the title that was captured when this URL was first detected —
+    // that pins the title to the URL's source tab and survives the user
+    // switching tabs before clicking Send. Fall back to whatever the caller
+    // sent (right-click context menu provides the correct tab.title), then
+    // to a generic placeholder.
+    const titleToUse =
+      getStoredPageTitle(request.url) || request.title || 'Untitled Video';
+    sendToNAS(request.url, titleToUse, request.pageUrl);
     sendResponse({ success: true });
   }
 

chrome-extension/manifest.json

@@ -1,7 +1,7 @@
 {
   "manifest_version": 3,
   "name": "WebVideo2NAS",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "description": "Send web videos (m3u8, mpd, mp4) to your NAS for download",
   "permissions": [
     "storage",

chrome-extension/sidepanel.js

@@ -817,14 +817,16 @@ async function sendToNAS(url, pageUrl) {
   }
 
   try {
-    const [tab] = await chrome.tabs.query({ active: true, currentWindow: true });
-    const title = tab.title || t('video.untitled');
-
+    // Don't pass the active tab's title — in a multi-tab session the active
+    // tab may not be the tab this URL came from, leading to mismatched titles.
+    // Background looks up the title that was captured when this URL was first
+    // detected (getStoredPageTitle) and falls back to a placeholder if
+    // missing. We still pass i18n-aware fallback so the language matches.
     chrome.runtime.sendMessage({
       action: 'sendToNAS',
       url: url,
-      title: title,
-      pageUrl: pageUrl || tab.url
+      title: t('video.untitled'),
+      pageUrl: pageUrl || ''
     });
 
     showToast(t('toast.sending'));

chrome-extension/tests/background.test.js

@@ -194,4 +194,29 @@ describe('background.js pure helpers', () => {
     expect(ctx.safeOrigin('https://example.com/a')).toBe('https://example.com');
     expect(ctx.safeOrigin('not a url')).toBe(null);
   });
+
+  it('getStoredPageTitle pins the title to the URL\'s source tab (multi-tab regression)', () => {
+    // Regression: previously the side panel passed the *active* tab's title
+    // when sending to NAS, so a URL detected in tab A would get tab B's
+    // title if the user switched tabs before clicking Send. Now background
+    // looks the title up from the urlInfo that was registered when the URL
+    // was first detected.
+    const ctx = loadScriptIntoContext('background.js', {
+      chrome: makeChromeStub(),
+    });
+
+    const tabA = 100;
+    const tabB = 200;
+    ctx.__eval(`currentTabUrls[${tabA}] = ${JSON.stringify([
+      { url: 'https://cdn.example.com/v/episode-1.m3u8', pageTitle: 'Anime · Episode 1', timestamp: 1000 },
+    ])};`);
+    ctx.__eval(`currentTabUrls[${tabB}] = ${JSON.stringify([
+      { url: 'https://cdn.example.com/v/episode-2.m3u8', pageTitle: 'News · Top Story', timestamp: 1000 },
+    ])};`);
+
+    expect(ctx.getStoredPageTitle('https://cdn.example.com/v/episode-1.m3u8')).toBe('Anime · Episode 1');
+    expect(ctx.getStoredPageTitle('https://cdn.example.com/v/episode-2.m3u8')).toBe('News · Top Story');
+    // Unknown URL → null (caller falls back to whatever the message had)
+    expect(ctx.getStoredPageTitle('https://cdn.example.com/v/unknown.m3u8')).toBe(null);
+  });
 });