Marksman version number is inconsistent with the release tag

[iamoeg]

Calling marksman --version yields 1.0.0-8299f11+8299f11dfad36a9162e010245b380ba25001b15c which I suspect is just 1.0.0 followed by the commit hash of the release. However, Marksman uses date-based tags for its releases. This inconsistency causes problems when the version number is used to verify that the correct version was installed, for example with mise (tool manager, see #4357).

@artempyanykh This is a minor issue, but I think it would generally be better if the version number followed the release tag.

P.S.: I would have sent a patch but I don't know how marksman --version's return value is set, and I'm not familiar with F# either.

[billf]

it's not always the git hash, an alternative version is used when make publishTo is called, used during the build

package managers could use this to append their own

❯ make publishTo DEST=$TMPDIR/ver VERSIONSTRING=4.3.2.1
dotnet publish -c Release -r osx-arm64 --self-contained true \
                -p:PublishSingleFile=true \
                -p:PublishTrimmed=true \
                -p:TrimMode=partial \
                -p:DebugType=embedded \
                -p:EnableCompressionInSingleFile=true \
                -p:VersionString="4.3.2.1" \
                -p:UseAppHost=true \
                Marksman/Marksman.fsproj
[.. some removed ]]

❯ $TMPDIR/ver/marksman --version
1.0.0-4.3.2.1+55c6c89d81dfb46a90086092548f6daeab64683d

in fact using -p:VersionString is precisely what homebrew does:

https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/m/marksman.rb#L35

i don't know anything about F# either, but https://dotnet.github.io/Nerdbank.GitVersioning/ appears to solve this problem more generally

c.f. #398

[artempyanykh]

Thanks for raising this! It's not really an F# thing, but rather dotnet/MSBuild. @billf explanation is on point. Also, a good pointer to https://dotnet.github.io/Nerdbank.GitVersioning/ - I'd be happy to take a PR that improves the versioning setup.