Refactor(eos_designs): Inserting the dhcp accept default route when mgmt_ip is dhcp (#6627)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Co-authored-by: Carl Baillargeon <carl.baillargeon@arista.com>

Author: 5 people

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/group_vars/FABRIC_MLAG_DUAL_PRIMARY_DHCP_MGMT_IP.yml

@@ -0,0 +1,22 @@
+---
+type: l3leaf
+
+l3leaf:
+  defaults:
+    loopback_ipv4_pool: 10.44.0.0/24
+    vtep_loopback_ipv4_pool: 10.45.0.0/24
+    mlag_interfaces: [Ethernet5, Ethernet6]
+    mlag_peer_ipv4_pool: 10.255.250.0/24
+    mlag_peer_l3_ipv4_pool: 10.255.249.0/24
+    mlag_dual_primary_detection: true
+
+  node_groups:
+    - group: mlag-dhcp-mgmt-ip
+      bgp_as: 65101
+      nodes:
+        - name: mlag-dhcp-mgmt-ip-1
+          id: 101
+          mgmt_ip: dhcp
+        - name: mlag-dhcp-mgmt-ip-2
+          id: 102
+          mgmt_ip: dhcp

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/dhcp-mgmt-ip-cvx-server-1.yml

@@ -0,0 +1,19 @@
+---
+type: cvxserver
+
+overlay_routing_protocol: CVX
+overlay_cvx_servers: [dhcp-mgmt-ip-cvx-server-1, dhcp-mgmt-ip-cvx-server-2]
+
+node_type_keys:
+  - key: cvxserver
+    type: cvxserver
+    underlay_router: false
+
+cvxserver:
+  nodes:
+    - name: dhcp-mgmt-ip-cvx-server-1
+      id: 3
+      mgmt_ip: 192.168.201.118/24
+
+expected_error_message: >-
+  'mgmt_ip' for CVX Server 'dhcp-mgmt-ip-cvx-server-2' must be a static management IP address, 'dhcp' is not supported.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/dhcp-mgmt-ip-cvx-server-2.yml

@@ -0,0 +1,18 @@
+---
+# This host is present in the fabric only to provide peer facts for dhcp-mgmt-ip-cvx-server-1.
+# It is excluded from structured config testing via EOS_DESIGNS_FAILURES_EXCLUDED.
+type: cvxserver
+
+overlay_routing_protocol: CVX
+overlay_cvx_servers: [dhcp-mgmt-ip-cvx-server-1, dhcp-mgmt-ip-cvx-server-2]
+
+node_type_keys:
+  - key: cvxserver
+    type: cvxserver
+    underlay_router: false
+
+cvxserver:
+  nodes:
+    - name: dhcp-mgmt-ip-cvx-server-2
+      id: 4
+      mgmt_ip: dhcp

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/dhcp-mgmt-ip-overlay-cvx-servers.yml

@@ -0,0 +1,27 @@
+---
+type: cvxserver
+
+overlay_routing_protocol: CVX
+overlay_cvx_servers: [dhcp-mgmt-ip-overlay-cvx-servers]
+
+node_type_keys:
+  - key: cvxserver
+    type: cvxserver
+    network_services:
+      l2: true
+      l3: true
+    vtep: true
+    default_ptp_priority1: 30
+
+cvxserver:
+  defaults:
+    loopback_ipv4_pool: 192.168.254.0/24
+    vtep_loopback_ipv4_pool: 192.168.253.0/24
+  nodes:
+    - name: dhcp-mgmt-ip-overlay-cvx-servers
+      bgp_as: 65001
+      id: 2
+      mgmt_ip: dhcp
+
+expected_error_message: >-
+  'mgmt_ip' for CVX Server 'dhcp-mgmt-ip-overlay-cvx-servers' must be a static management IP address, 'dhcp' is not supported.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/digital-twin-act-dhcp-ip-addr.yml

@@ -0,0 +1,19 @@
+---
+type: l2leaf
+
+l2leaf:
+  nodes:
+    - name: digital-twin-act-dhcp-ip-addr
+      platform: vEOS-lab
+      mgmt_ip: dhcp
+
+platform_settings:
+  - platforms: [vEOS-lab]
+    digital_twin:
+      platform: vEOS-lab
+      act_node_type: veos
+
+avd_digital_twin_mode: true
+
+expected_error_message: >-
+  'mgmt_ip: dhcp' is not supported for Digital Twin. A static management IP address is required for host 'digital-twin-act-dhcp-ip-addr'.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/mlag-dhcp-mgmt-ip-1.yml

@@ -0,0 +1,3 @@
+expected_error_message: >-
+  'mgmt_ip: dhcp' is not supported for MLAG peer 'mlag-dhcp-mgmt-ip-2'.
+  MLAG dual-primary detection heartbeat requires a static management IP address.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/mlag-dhcp-mgmt-ip-2.yml

@@ -0,0 +1,3 @@
+expected_error_message: >-
+  'mgmt_ip: dhcp' is not supported for MLAG peer 'mlag-dhcp-mgmt-ip-1'.
+  MLAG dual-primary detection heartbeat requires a static management IP address.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/snmp-settings-dhcp-mgmt-ip.yml

@@ -0,0 +1,14 @@
+---
+type: l2leaf
+
+l2leaf:
+  nodes:
+    - name: snmp-settings-dhcp-mgmt-ip
+      mgmt_ip: dhcp
+
+snmp_settings:
+  compute_local_engineid: true
+  # mgmt_ip is dhcp which is not supported for engine ID computation via use_mgmt_interface
+expected_error_message: >-
+  'snmp_settings.local_engineid_ip' is set to 'use_mgmt_interface' but 'mgmt_ip: dhcp' is not supported.
+  A static management IP address is required for host 'snmp-settings-dhcp-mgmt-ip'.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/snmp-settings-hostname-and-ip-dhcp-mgmt-ip.yml

@@ -0,0 +1,15 @@
+---
+type: l2leaf
+
+l2leaf:
+  nodes:
+    - name: snmp-settings-hostname-and-ip-dhcp-mgmt-ip
+      mgmt_ip: dhcp
+
+snmp_settings:
+  compute_local_engineid: true
+  compute_local_engineid_source: hostname_and_ip
+  # mgmt_ip is dhcp which is not supported for engine ID computation with hostname_and_ip
+expected_error_message: >-
+  'mgmt_ip: dhcp' is not supported for 'snmp_settings.compute_local_engineid_source: hostname_and_ip'.
+  A static management IP address is required for host 'snmp-settings-hostname-and-ip-dhcp-mgmt-ip'.

ansible_collections/arista/avd/extensions/molecule/eos_designs_negative_unit_tests/inventory/hosts.yml

@@ -246,6 +246,9 @@ all:
               hosts:
                 duplicate-ip-address-1:
                 duplicate-ip-address-2:
+            FABRIC_CVX_DHCP_PEER:
+              hosts:
+                dhcp-mgmt-ip-cvx-server-2:
         EOS_DESIGNS_FAILURES_INCLUDED:
           hosts:
             address-locking-missing-dhcp-server-ip-and-locked-address-ipv4-enforcement-disabled:
@@ -266,6 +269,9 @@ all:
             core-interfaces-ipv6-only-include-in-underlay-protocol:
             core-interfaces-missing-id-with-channel-id-algorithm:
             core-interfaces-p2p-links-as:
+            dhcp-mgmt-ip-cvx-server-1:
+            dhcp-mgmt-ip-overlay-cvx-servers:
+            digital-twin-act-dhcp-ip-addr:
             digital-twin-act-missing-ip-addr:
             digital-twin-act-missing-node-type:
             dns-settings-missing-inband-mgmt:
@@ -456,6 +462,8 @@ all:
             sflow-settings-missing-destinations:
             sflow-settings-missing-inband-mgmt-interface:
             sflow-settings-missing-mgmt-ip:
+            snmp-settings-dhcp-mgmt-ip:
+            snmp-settings-hostname-and-ip-dhcp-mgmt-ip:
             snmp-settings-missing-inband-mgmt:
             snmp-settings-missing-ip:
             snmp-settings-missing-mgmt-ip:
@@ -481,6 +489,10 @@ all:
               hosts:
                 missing-ip-address-on-uplink-used-as-wan-lan-ha:
                 missing-ip-address-on-wan-lan-ha-uplink-for-peer:
+            FABRIC_MLAG_DUAL_PRIMARY_DHCP_MGMT_IP:
+              hosts:
+                mlag-dhcp-mgmt-ip-1:
+                mlag-dhcp-mgmt-ip-2:
             INVALID_DUAL_ROUTER_WAN_EVPN_GW:
               hosts:
                 cv-pathfinder-edge-wan-use-evpn-on-lan-1: