Skip to content

Commit ebf6a92

Browse files
authored
feat(argo-rollouts): add controller.createConfigmap flag (#3793)
1 parent 7e69a36 commit ebf6a92

4 files changed

Lines changed: 12 additions & 3 deletions

File tree

charts/argo-rollouts/Chart.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
appVersion: v1.8.4
33
description: A Helm chart for Argo Rollouts
44
name: argo-rollouts
5-
version: 2.40.6
5+
version: 2.40.7
66
home: https://github.com/argoproj/argo-helm
77
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
88
keywords:
@@ -18,5 +18,5 @@ annotations:
1818
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
1919
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
2020
artifacthub.io/changes: |
21-
- kind: changed
22-
description: Bump argo-rollouts to v1.8.4
21+
- kind: added
22+
description: Added flag to optionally disable argo-rollouts-config ConfigMap creation

charts/argo-rollouts/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ For full list of changes please check ArtifactHub [changelog].
9090
| controller.containerPorts.healthz | int | `8080` | Healthz container port |
9191
| controller.containerPorts.metrics | int | `8090` | Metrics container port |
9292
| controller.createClusterRole | bool | `true` | flag to enable creation of cluster controller role (requires cluster RBAC) |
93+
| controller.createConfigmap | bool | `true` | Whether to create the argo-rollouts-config ConfigMap. Set to false when running multiple controller instances in the same namespace (e.g. with different --instance-id values) to avoid Helm ownership conflicts; each secondary instance will read the ConfigMap created by the primary release. |
9394
| controller.deploymentAnnotations | object | `{}` | Annotations to be added to the controller deployment |
9495
| controller.deploymentLabels | object | `{}` | Labels to be added to the controller deployment |
9596
| controller.extraArgs | list | `[]` | Additional command line arguments to pass to rollouts-controller. A list of flags. |

charts/argo-rollouts/templates/controller/configmap.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{- if .Values.controller.createConfigmap }}
12
apiVersion: v1
23
kind: ConfigMap
34
metadata:
@@ -19,3 +20,4 @@ data:
1920
trafficRouterPlugins: |-
2021
{{- toYaml . | nindent 4 }}
2122
{{- end }}
23+
{{- end }}

charts/argo-rollouts/values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,12 @@ controller:
251251
# - name: "argoproj-labs/sample-nginx" # name of the plugin, it must match the name required by the plugin so it can find it's configuration
252252
# location: "file://./my-custom-plugin" # supports http(s):// urls and file://
253253

254+
# -- Whether to create the argo-rollouts-config ConfigMap. Set to false when running multiple
255+
# controller instances in the same namespace (e.g. with different --instance-id values) to
256+
# avoid Helm ownership conflicts; each secondary instance will read the ConfigMap created by
257+
# the primary release.
258+
createConfigmap: true
259+
254260
serviceAccount:
255261
# -- Specifies whether a service account should be created
256262
create: true

0 commit comments

Comments
 (0)