Skip to content

Commit 7791168

Browse files
committed
fix(argocd-image-updater): drop config: section additions per review
Per maintainer feedback (mkilchhofer), drop the new config keys (log.format, interval, max_concurrent_apps, max_concurrent_reconciles, argocd.namespace, webhook.enable, webhook.port, webhook.ratelimit-allowed) from values.yaml. Keep template wiring for new webhook secrets, the metricsSecure/enableHTTP2 controller flags, and health-probe-bind-address. Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com>
1 parent e15026d commit 7791168

3 files changed

Lines changed: 1 addition & 34 deletions

File tree

charts/argocd-image-updater/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ annotations:
1919
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
2020
artifacthub.io/changes: |
2121
- kind: added
22-
description: Add first-class values for missing config keys (log.format, interval, concurrency), webhook support (enable, port, rate-limit, ACR/CloudEvents secrets), controller flags (metricsSecure, enableHTTP2), and health-probe-bind-address wiring
22+
description: Wire ALIYUN_ACR_WEBHOOK_SECRET and CLOUDEVENTS_WEBHOOK_SECRET env vars, add metricsSecure and enableHTTP2 controller flags, and bind --health-probe-bind-address to containerPorts.health

charts/argocd-image-updater/README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,22 +82,14 @@ The `config.registries` value can be used exactly as it looks in the documentati
8282
| authScripts.enabled | bool | `false` | Whether to mount the defined scripts that can be used to authenticate with a registry, the scripts will be mounted at `/scripts` |
8383
| authScripts.name | string | `"argocd-image-updater-authscripts"` | Name of the authentication scripts ConfigMap |
8484
| authScripts.scripts | object | `{}` | Map of key-value pairs where the key consists of the name of the script and the value the contents. |
85-
| config."argocd.namespace" | string | `""` | Namespace where ArgoCD runs in (defaults to the controller namespace) |
8685
| config."git.commit-message-template" | string | `""` | Changing the Git commit message |
8786
| config."git.commit-sign-off" | bool | `false` | Enables sign off on commits |
8887
| config."git.commit-signing-key" | string | `""` | Path to public SSH key mounted in container, or GPG key ID used to sign commits |
8988
| config."git.commit-signing-method" | string | `""` | Method used to sign Git commits. `openpgp` or `ssh` |
9089
| config."git.email" | string | `""` | E-Mail address to use for Git commits |
9190
| config."git.user" | string | `""` | Username to use for Git commits |
9291
| config."kube.events" | bool | `false` | Disable kubernetes events |
93-
| config."log.format" | string | `""` | Argo CD Image Updater log format (`text` or `json`) |
9492
| config."log.level" | string | `"info"` | Argo CD Image Update log level |
95-
| config."webhook.enable" | string | `""` | Enable webhook server for receiving registry events |
96-
| config."webhook.port" | string | `""` | Port to listen on for webhook events |
97-
| config."webhook.ratelimit-allowed" | string | `""` | The number of allowed requests per hour for webhook rate limiting (0 disables) |
98-
| config.interval | string | `""` | Interval for how often to check for updates (e.g. `2m`, `5m`) |
99-
| config.max_concurrent_apps | string | `""` | Maximum number of ArgoCD applications that can be updated concurrently |
100-
| config.max_concurrent_reconciles | string | `""` | Maximum number of concurrent Reconciles which can be run |
10193
| config.name | string | `"argocd-image-updater-config"` | Name of the ConfigMap |
10294
| config.registries | list | `[]` | Argo CD Image Updater registries list configuration. More information [here](https://argocd-image-updater.readthedocs.io/en/stable/configuration/registries/). |
10395
| config.sshConfig.config | string | `""` | Argo CD Image Updater ssh client parameter configuration |

charts/argocd-image-updater/values.yaml

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -159,34 +159,9 @@ config:
159159
# -- Method used to sign Git commits. `openpgp` or `ssh`
160160
git.commit-signing-method: ""
161161

162-
# -- Argo CD Image Updater log format (`text` or `json`)
163-
log.format: ""
164-
165162
# -- Argo CD Image Update log level
166163
log.level: "info"
167164

168-
# -- Interval for how often to check for updates (e.g. `2m`, `5m`)
169-
interval: ""
170-
171-
# -- Maximum number of ArgoCD applications that can be updated concurrently
172-
max_concurrent_apps: ""
173-
174-
# -- Maximum number of concurrent Reconciles which can be run
175-
max_concurrent_reconciles: ""
176-
177-
# -- Namespace where ArgoCD runs in (defaults to the controller namespace)
178-
argocd.namespace: ""
179-
180-
# -- Enable webhook server for receiving registry events
181-
webhook.enable: ""
182-
183-
# -- Port to listen on for webhook events
184-
webhook.port: ""
185-
186-
# -- The number of allowed requests per hour for webhook rate limiting (0 disables)
187-
webhook.ratelimit-allowed: ""
188-
189-
190165
# -- Argo CD Image Updater registries list configuration. More information [here](https://argocd-image-updater.readthedocs.io/en/stable/configuration/registries/).
191166
registries: []
192167
# - name: Docker Hub

0 commit comments

Comments
 (0)