Address PR feedback: simplify provider and improve date validation

- Move provider logic to static method inside DateTimeNormalizationIssue fixture
- Remove separate DateTimeNormalizationIssueProvider class
- Use short class name for provider reference with proper import
- Replace regex validation with DateTime::createFromFormat for better date testing

Co-authored-by: soyuka <[email protected]>

Author: Copilot

tests/Fixtures/TestBundle/ApiResource/DateTimeNormalizationIssue.php

@@ -15,6 +15,7 @@
 
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Get;
+use ApiPlatform\Metadata\Operation;
 
 /**
  * Resource to test DateTimeImmutable normalization priority.
@@ -26,7 +27,7 @@
         new Get(
             uriTemplate: '/datetime_normalization_issues/{id}',
             normalizationContext: ['groups' => ['read']],
-            provider: \ApiPlatform\Tests\Fixtures\TestBundle\State\DateTimeNormalizationIssueProvider::class
+            provider: [self::class, 'provide']
         ),
     ]
 )]
@@ -38,4 +39,15 @@ public function __construct(
         public ?\DateTimeImmutable $updatedAt = null
     ) {
     }
+
+    public static function provide(Operation $operation, array $uriVariables = [], array $context = []): self
+    {
+        $id = $uriVariables['id'] ?? 1;
+
+        return new self(
+            id: (int) $id,
+            name: 'Test Resource',
+            updatedAt: new \DateTimeImmutable('2024-01-15 10:30:00')
+        );
+    }
 }

tests/Fixtures/TestBundle/State/DateTimeNormalizationIssueProvider.php

@@ -62,12 +62,9 @@ public function testDateTimeImmutableIsNormalizedCorrectly(): void
         $this->assertIsString($data['updatedAt']);
         $this->assertStringContainsString('2024-01-15', $data['updatedAt']);
 
-        // Verify it's a valid ISO 8601 datetime string
-        $this->assertMatchesRegularExpression(
-            '/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/',
-            $data['updatedAt'],
-            'updatedAt should be in ISO 8601 format (YYYY-MM-DDTHH:MM:SS)'
-        );
+        // Verify it's a valid ISO 8601 datetime string by parsing it
+        $date = \DateTimeImmutable::createFromFormat(\DateTimeInterface::ATOM, $data['updatedAt']);
+        $this->assertNotFalse($date, 'updatedAt should be in ISO 8601 format');
     }
 
     /**
@@ -88,10 +85,10 @@ public function testDateTimeImmutableIsNormalizedCorrectlyInJson(): void
         $this->assertArrayHasKey('updatedAt', $data);
         $this->assertIsString($data['updatedAt']);
         $this->assertStringContainsString('2024-01-15', $data['updatedAt']);
-        $this->assertMatchesRegularExpression(
-            '/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/',
-            $data['updatedAt']
-        );
+        
+        // Verify it's a valid ISO 8601 datetime string by parsing it
+        $date = \DateTimeImmutable::createFromFormat(\DateTimeInterface::ATOM, $data['updatedAt']);
+        $this->assertNotFalse($date, 'updatedAt should be in ISO 8601 format');
     }
 
     /**
@@ -111,6 +108,10 @@ public function testDateTimeImmutableIsNormalizedCorrectlyInHal(): void
         $this->assertArrayHasKey('updatedAt', $data);
         $this->assertIsString($data['updatedAt']);
         $this->assertStringContainsString('2024-01-15', $data['updatedAt']);
+        
+        // Verify it's a valid ISO 8601 datetime string by parsing it
+        $date = \DateTimeImmutable::createFromFormat(\DateTimeInterface::ATOM, $data['updatedAt']);
+        $this->assertNotFalse($date, 'updatedAt should be in ISO 8601 format');
     }
 
     /**
@@ -132,5 +133,9 @@ public function testDateTimeImmutableIsNormalizedCorrectlyInJsonApi(): void
         $this->assertArrayHasKey('updatedAt', $data['data']['attributes']);
         $this->assertIsString($data['data']['attributes']['updatedAt']);
         $this->assertStringContainsString('2024-01-15', $data['data']['attributes']['updatedAt']);
+        
+        // Verify it's a valid ISO 8601 datetime string by parsing it
+        $date = \DateTimeImmutable::createFromFormat(\DateTimeInterface::ATOM, $data['data']['attributes']['updatedAt']);
+        $this->assertNotFalse($date, 'updatedAt should be in ISO 8601 format');
     }
 }