Skip to content

Commit eb84f50

Browse files
Disable flaky SSH tests on Windows
1 parent 35d28b6 commit eb84f50

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

itests/test/src/test/java/org/apache/karaf/itests/ssh/BundleSshCommandSecurityTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
*/
1414
package org.apache.karaf.itests.ssh;
1515

16+
import org.junit.Assume;
1617
import org.junit.Test;
1718
import org.junit.runner.RunWith;
1819
import org.ops4j.pax.exam.junit.PaxExam;
@@ -32,6 +33,11 @@ public class BundleSshCommandSecurityTest extends SshCommandTestBase {
3233

3334
@Test
3435
public void testBundleCommandSecurityViaSsh() throws Exception {
36+
// Skip on Windows where PTY output can be garbled,
37+
// when upgrading to Junit5, this can be replaced with @DisabledOnOs(OS.WINDOWS)
38+
// TODO: remove this once we have a better solution for PTY output on Windows
39+
Assume.assumeFalse(System.getProperty("os.name", "").toLowerCase().contains("win"));
40+
3541
String manageruser = "man" + System.nanoTime() + "_" + counter++;
3642
String vieweruser = "view" + System.nanoTime() + "_" + counter++;
3743

0 commit comments

Comments
 (0)