Skip to content

Commit 0d5b7c3

Browse files
committed
Simplify enum handling and clean imports
- Remove unnecessary enum-string-enum round-trip conversion for OverAppliedCalculationType - Replace with direct case-insensitive string check (percentage.equalsIgnoreCase) - Remove unused imports: Locale, LoanOverAppliedCalculationType - Maintain exact same behavior while improving maintainability
1 parent 962454c commit 0d5b7c3

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanDisbursementValidator.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,12 @@
1919
package org.apache.fineract.portfolio.loanaccount.serialization;
2020

2121
import java.math.BigDecimal;
22-
import java.util.Locale;
2322
import java.time.LocalDate;
2423
import lombok.RequiredArgsConstructor;
2524
import org.apache.fineract.infrastructure.core.service.DateUtils;
2625
import org.apache.fineract.infrastructure.core.service.MathUtil;
2726
import org.apache.fineract.organisation.monetary.domain.MoneyHelper;
2827
import org.apache.fineract.portfolio.loanaccount.domain.Loan;
29-
import org.apache.fineract.portfolio.loanaccount.domain.LoanOverAppliedCalculationType;
3028
import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
3129
import org.apache.fineract.portfolio.loanaccount.exception.InvalidLoanStateTransitionException;
3230
import org.apache.fineract.portfolio.loanaccount.exception.LoanDisbursalException;
@@ -72,10 +70,8 @@ private BigDecimal calculateMaxAllowedDisbursement(final Loan loan) {
7270

7371
if (loanProduct.getOverAppliedCalculationType() != null && loanProduct.getOverAppliedNumber() != null) {
7472
final BigDecimal overAppliedMax = BigDecimal.valueOf(loanProduct.getOverAppliedNumber());
75-
final LoanOverAppliedCalculationType calculationType = LoanOverAppliedCalculationType
76-
.valueOf(loanProduct.getOverAppliedCalculationType().toUpperCase(Locale.ROOT));
7773

78-
if (calculationType.isPercentage()) {
74+
if ("percentage".equalsIgnoreCase(loanProduct.getOverAppliedCalculationType())) {
7975
final BigDecimal extra = MathUtil.percentageOf(approvedPrincipal, overAppliedMax, MoneyHelper.getMathContext());
8076
maxAllowed = approvedPrincipal.add(extra);
8177
} else {

0 commit comments

Comments
 (0)