Skip to content

Commit ff52988

Browse files
authored
[Improvement-18127][Master] Remove the redundant workflow completion check when handling workflow timeout events (#18128)
1 parent 0cba793 commit ff52988

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
import org.apache.dolphinscheduler.dao.entity.WorkflowInstance;
2121
import org.apache.dolphinscheduler.server.master.engine.ILifecycleEventType;
22-
import org.apache.dolphinscheduler.server.master.engine.graph.IWorkflowExecutionGraph;
2322
import org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.WorkflowLifecycleEventType;
2423
import org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.event.WorkflowTimeoutLifecycleEvent;
2524
import org.apache.dolphinscheduler.server.master.engine.workflow.runnable.IWorkflowExecutionRunnable;
@@ -46,12 +45,6 @@ public WorkflowTimeoutLifecycleEventHandler(final WorkflowAlertManager workflowA
4645
public void handle(final IWorkflowStateAction workflowStateAction,
4746
final IWorkflowExecutionRunnable workflowExecutionRunnable,
4847
final WorkflowTimeoutLifecycleEvent workflowTimeoutLifecycleEvent) {
49-
final IWorkflowExecutionGraph workflowExecutionGraph = workflowExecutionRunnable.getWorkflowExecutionGraph();
50-
if (workflowExecutionGraph.isAllTaskExecutionRunnableChainFinish()) {
51-
// all the TaskExecutionRunnable chain in the graph is finish, means the workflow is already finished.
52-
return;
53-
}
54-
5548
final WorkflowInstance workflowInstance = workflowExecutionRunnable.getWorkflowInstance();
5649
final boolean shouldSendAlert = workflowInstance.getWarningGroupId() != null;
5750

0 commit comments

Comments
 (0)