[Improvement-18056] Clean up unused methods and classes in the dolphinschudler-service module (#18169)

Author: njnu-seafish

dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/cron/CronUtils.java

@@ -18,8 +18,6 @@
 package org.apache.dolphinscheduler.service.cron;
 
 import static com.cronutils.model.CronType.QUARTZ;
-import static org.apache.dolphinscheduler.common.constants.CommandKeyConstants.CMD_PARAM_COMPLEMENT_DATA_SCHEDULE_DATE_LIST;
-import static org.apache.dolphinscheduler.common.constants.Constants.COMMA;
 import static org.apache.dolphinscheduler.service.cron.CycleFactory.day;
 import static org.apache.dolphinscheduler.service.cron.CycleFactory.hour;
 import static org.apache.dolphinscheduler.service.cron.CycleFactory.min;
@@ -35,18 +33,14 @@
 import org.apache.dolphinscheduler.service.exceptions.CronParseException;
 
 import org.apache.commons.collections4.CollectionUtils;
-import org.apache.commons.lang3.StringUtils;
 
-import java.time.ZoneId;
 import java.time.ZonedDateTime;
 import java.util.ArrayList;
 import java.util.Calendar;
 import java.util.Date;
 import java.util.GregorianCalendar;
 import java.util.List;
-import java.util.Map;
 import java.util.Optional;
-import java.util.stream.Collectors;
 
 import lombok.NonNull;
 import lombok.extern.slf4j.Slf4j;
@@ -206,17 +200,6 @@ public static List<ZonedDateTime> getSelfFireDateList(@NonNull ZonedDateTime sta
         return executeTimes;
     }
 
-    public static List<Date> getSelfFireDateList(@NonNull final Date startTime,
-                                                 @NonNull final Date endTime,
-                                                 @NonNull final List<Schedule> schedules) throws CronParseException {
-        ZonedDateTime zonedDateTimeStart = ZonedDateTime.ofInstant(startTime.toInstant(), ZoneId.systemDefault());
-        ZonedDateTime zonedDateTimeEnd = ZonedDateTime.ofInstant(endTime.toInstant(), ZoneId.systemDefault());
-
-        return getSelfFireDateList(zonedDateTimeStart, zonedDateTimeEnd, schedules).stream()
-                .map(zonedDateTime -> new Date(zonedDateTime.toInstant().toEpochMilli()))
-                .collect(Collectors.toList());
-    }
-
     /**
      * gets all scheduled times for a period of time based on self dependency
      * if schedulers is empty then default scheduler = 1 day
@@ -301,22 +284,4 @@ private static Date getEndTime(Date date) {
         return end.getTime();
     }
 
-    /**
-     * get Schedule Date
-     *
-     * @param param
-     * @return date list
-     */
-    public static List<Date> getSelfScheduleDateList(Map<String, String> param) {
-        List<Date> result = new ArrayList<>();
-        String scheduleDates = param.get(CMD_PARAM_COMPLEMENT_DATA_SCHEDULE_DATE_LIST);
-        if (StringUtils.isNotEmpty(scheduleDates)) {
-            for (String stringDate : scheduleDates.split(COMMA)) {
-                result.add(DateUtils.stringToDate(stringDate.trim()));
-            }
-            return result;
-        }
-        return null;
-    }
-
 }

dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/exceptions/CronParseException.java

@@ -19,11 +19,8 @@
 
 public class CronParseException extends Exception {
 
-    public CronParseException(String message) {
-        super(message);
-    }
-
     public CronParseException(String message, Throwable throwable) {
         super(message, throwable);
     }
+
 }

dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java

@@ -64,7 +64,6 @@
 import org.apache.dolphinscheduler.dao.repository.WorkflowInstanceDao;
 import org.apache.dolphinscheduler.plugin.task.api.parameters.SubWorkflowParameters;
 import org.apache.dolphinscheduler.plugin.task.api.parameters.TaskTimeoutParameter;
-import org.apache.dolphinscheduler.service.expand.CuringParamsService;
 import org.apache.dolphinscheduler.service.model.TaskNode;
 import org.apache.dolphinscheduler.service.utils.ClusterConfUtils;
 import org.apache.dolphinscheduler.service.utils.DagHelper;
@@ -156,9 +155,6 @@ public class ProcessServiceImpl implements ProcessService {
     @Autowired
     private ClusterMapper clusterMapper;
 
-    @Autowired
-    private CuringParamsService curingGlobalParamsService;
-
     /**
      * find workflow instance detail by id
      *
@@ -737,7 +733,6 @@ public List<TaskNode> transformTask(List<WorkflowTaskRelation> taskRelationList,
      * @param clusterName clusterName
      * @return datasource
      */
-
     @Override
     public String findConfigYamlByName(String clusterName) {
         if (Strings.isNullOrEmpty(clusterName)) {

dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/command/MessageServiceImplTest.java

@@ -23,7 +23,6 @@
 import org.apache.dolphinscheduler.dao.entity.Command;
 import org.apache.dolphinscheduler.dao.mapper.CommandMapper;
 import org.apache.dolphinscheduler.dao.mapper.ScheduleMapper;
-import org.apache.dolphinscheduler.dao.mapper.WorkflowDefinitionMapper;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -48,9 +47,6 @@ class MessageServiceImplTest {
     @Mock
     private CommandMapper commandMapper;
 
-    @Mock
-    private WorkflowDefinitionMapper processDefineMapper;
-
     @Mock
     private ScheduleMapper scheduleMapper;
 

dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java

@@ -31,15 +31,11 @@
 import org.apache.dolphinscheduler.dao.entity.WorkflowTaskRelationLog;
 import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionLogMapper;
 import org.apache.dolphinscheduler.dao.mapper.TaskDefinitionMapper;
-import org.apache.dolphinscheduler.dao.mapper.TaskGroupQueueMapper;
 import org.apache.dolphinscheduler.dao.mapper.UserMapper;
-import org.apache.dolphinscheduler.dao.mapper.WorkflowDefinitionLogMapper;
 import org.apache.dolphinscheduler.dao.mapper.WorkflowDefinitionMapper;
-import org.apache.dolphinscheduler.dao.mapper.WorkflowInstanceMapper;
 import org.apache.dolphinscheduler.dao.mapper.WorkflowTaskRelationLogMapper;
 import org.apache.dolphinscheduler.dao.repository.TaskDefinitionDao;
 import org.apache.dolphinscheduler.dao.repository.TaskDefinitionLogDao;
-import org.apache.dolphinscheduler.service.expand.CuringParamsService;
 import org.apache.dolphinscheduler.service.model.TaskNode;
 
 import java.util.ArrayList;
@@ -70,12 +66,6 @@ public class ProcessServiceTest {
     @Mock
     private WorkflowDefinitionMapper workflowDefinitionMapper;
 
-    @Mock
-    private WorkflowInstanceMapper workflowInstanceMapper;
-
-    @Mock
-    private WorkflowDefinitionLogMapper workflowDefinitionLogMapper;
-
     @Mock
     private TaskDefinitionDao taskDefinitionDao;
 
@@ -91,12 +81,6 @@ public class ProcessServiceTest {
     @Mock
     private TaskDefinitionMapper taskDefinitionMapper;
 
-    @Mock
-    private TaskGroupQueueMapper taskGroupQueueMapper;
-
-    @Mock
-    CuringParamsService curingGlobalParamsService;
-
     @Test
     public void testGetUserById() {
         User user = new User();