Skip to content

Changes in 0.36 to default select value in ResultSet.pm are not backwards compatible #29

@gliganh

Description

@gliganh

Hi,

This change

  •    select          => ['me.*'],
    
  •    select          => undef,
    

brakes our production code when we have a construct similar to this one :

$dbix->table('table_A)
->left_join('table_B', { data_type_id => "data_type_id" })
->select_also(["table_B.colum_1" => 'extra_info' ])
->search({
id => $id,
})
->select_sql();

This is because select_also makes the select attribute on on the ResultSet not empty, which means 'me.*' will never be added to the query, so the only column returned is "table_B.colum_1"

This worked in 0.35

It's impossible for us to audit our entire code base and make sure we add a select('me.*') in every query that has a join. Can we please restore the 0.35 functionality ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions