Revert "feat: Add multiple service binding support (#1)" (#2)

This reverts commit 9e23c78.

Author: algoyounes

README.md

@@ -32,13 +32,8 @@ composer require algoyounes/bindify
 
 1. Use the `#[BindWith]` attribute to bind an interface to its implementation
 
-> [!TIP]
-> Bind multiple services :
-> ```php
-> #[BindWith([DefaultService::class, ... ], BindType::Singleton)]
-> ```
-
 ```php
+
 namespace App\Contracts;
 
 use AlgoYounes\Bindify\Attributes\BindWith;
@@ -54,6 +49,7 @@ interface ServiceContract
 2. Create the implementation of the interface
 
 ```php
+
 namespace App\Services;
 
 use App\Contracts\ServiceContract;

src/Attributes/BindWith.php

@@ -7,21 +7,13 @@
 #[Attribute(Attribute::TARGET_CLASS)]
 readonly class BindWith
 {
-    /** @param class-string|array<class-string> $concrete */
     public function __construct(
-        public string|array $concrete,
+        public string $concrete,
         public BindType $type = BindType::Transient,
     ) {}
 
-    /**
-     * @return array<class-string>
-     */
-    public function getConcrete(): array
+    public function getConcrete(): string
     {
-        if (is_string($this->concrete)) {
-            return [$this->concrete];
-        }
-
         return $this->concrete;
     }
 

src/Contexts/BindContext.php

@@ -6,22 +6,14 @@
 
 readonly class BindContext
 {
-    /** @param array<class-string> $concrete */
     public function __construct(
         private string $abstract,
-        private array $concrete,
+        private string $concrete,
         private BindType $type,
     ) {}
 
-    /**
-     * @param  class-string|array<class-string>  $concrete
-     */
-    public static function create(string $abstract, string|array $concrete, BindType $type): self
+    public static function create(string $abstract, string $concrete, BindType $type): self
     {
-        if (is_string($concrete)) {
-            $concrete = [$concrete];
-        }
-
         return new self($abstract, $concrete, $type);
     }
 
@@ -30,10 +22,7 @@ public function getAbstract(): string
         return $this->abstract;
     }
 
-    /**
-     * @return array<class-string>
-     */
-    public function getConcrete(): array
+    public function getConcrete(): string
     {
         return $this->concrete;
     }

src/Providers/BindifyServiceProvider.php

@@ -35,13 +35,11 @@ private function beforeResolvingCallback(): Closure
                 return;
             }
 
-            foreach ($binding->getConcrete() as $concrete) {
-                $container->bind(
-                    $binding->getAbstract(),
-                    $concrete,
-                    $binding->isSingleton(),
-                );
-            }
+            $container->bind(
+                $binding->getAbstract(),
+                $binding->getConcrete(),
+                $binding->isSingleton(),
+            );
         };
     }
 }

src/Resolvers/AttributeResolver.php

@@ -28,16 +28,6 @@ public function resolve(string $abstract): ?BindContext
             return null;
         }
 
-        $concretes = array_filter(
-            array_unique($bindWith->getConcrete()),
-            static fn (string $concrete): bool => class_exists($concrete)
-                && is_subclass_of($concrete, $abstract)
-        );
-
-        if ($concretes === []) {
-            return null;
-        }
-
-        return new BindContext($abstract, $concretes, $bindWith->getType());
+        return BindContext::create($abstract, $bindWith->getConcrete(), $bindWith->getType());
     }
 }

tests/Feature/BindifyTest.php

@@ -2,19 +2,16 @@
 
 use AlgoYounes\Bindify\Attributes\BindType;
 use AlgoYounes\Bindify\Contexts\BindContext;
-use Workbench\App\AlternativeImplementationService;
 use Workbench\App\Contracts\DefaultBindTypeContract;
-use Workbench\App\Contracts\InvalidClassBindingsContract;
-use Workbench\App\Contracts\MultiBindContract;
 use Workbench\App\Contracts\MultipleAttributesContract;
 use Workbench\App\Contracts\NoAttributeContract;
 use Workbench\App\Contracts\SingletonBindingContract;
-use Workbench\App\DefaultImplementationService;
+use Workbench\App\DefaultImplementationContract;
 
 it('returns a binding from the interface attribute with the default type', function () {
     $context = BindContext::create(
         DefaultBindTypeContract::class,
-        DefaultImplementationService::class,
+        DefaultImplementationContract::class,
         BindType::Transient
     );
 
@@ -26,7 +23,7 @@
 it('returns a binding from the interface attribute with the singleton type', function () {
     $context = BindContext::create(
         SingletonBindingContract::class,
-        DefaultImplementationService::class,
+        DefaultImplementationContract::class,
         BindType::Singleton
     );
 
@@ -46,29 +43,3 @@
 it('returns null when the interface has more than one attribute', function () {
     $this->assertNull($this->attributeResolver->resolve(MultipleAttributesContract::class));
 });
-
-it('return null when invalid classes binding', function () {
-    $this->assertNull($this->attributeResolver->resolve(InvalidClassBindingsContract::class));
-});
-
-it('binds multiple valid services to the same interface', function () {
-    /** @var BindContext $binding */
-    $binding = $this->attributeResolver->resolve(MultiBindContract::class);
-
-    $expected = BindContext::create(
-        MultiBindContract::class,
-        [
-            DefaultImplementationService::class,
-            AlternativeImplementationService::class,
-        ],
-        BindType::Transient
-    );
-
-    expect($expected)
-        ->toEqual($binding)
-        ->and($binding->getConcrete())
-        ->toBeArray()
-        ->toHaveCount(2)
-        ->and($binding->getConcrete())
-        ->toEqual([DefaultImplementationService::class, AlternativeImplementationService::class]);
-});

workbench/app/AlternativeImplementationService.php

@@ -3,7 +3,7 @@
 namespace Workbench\App\Contracts;
 
 use AlgoYounes\Bindify\Attributes\BindWith;
-use Workbench\App\DefaultImplementationService;
+use Workbench\App\DefaultImplementationContract;
 
-#[BindWith(DefaultImplementationService::class)]
+#[BindWith(DefaultImplementationContract::class)]
 interface DefaultBindTypeContract {}