fix: handle 204 No Content responses across language clients

Add status code and empty body guards to prevent deserialization crashes on HTTP 204:
- JS: response.status === 204 || content.length === 0 in helpers.ts
- Java: restore contentLength() == 0, add response.code() == 204 in HttpRequester
- Scala: response.code == 204 check in HttpRequester
- PHP: 204 === $statusCode || $body === '' before json_decode
- Dart: response.statusCode == 204 ? null : response.body
- Kotlin: response.status.value == 204 || contentLength() == 0L

Author: Fluf22

clients/algoliasearch-client-dart/packages/client_core/lib/src/transport/retry_strategy.dart

@@ -48,7 +48,7 @@ final class RetryStrategy {
         );
 
   /// Run an request and get a response.
-  Future<Map<String, dynamic>> execute({
+  Future<Map<String, dynamic>?> execute({
     required ApiRequest request,
     RequestOptions? options,
   }) async {
@@ -66,7 +66,7 @@ final class RetryStrategy {
         final response = await requester.perform(httpRequest);
         host.reset();
         requester.setConnectTimeout(requesterConnectTimeout);
-        return response.body ?? const {};
+        return response.statusCode == 204 ? null : response.body;
       } on AlgoliaTimeoutException catch (e) {
         host.timedOut();
         errors.add(e);

clients/algoliasearch-client-java/algoliasearch/src/main/java/com/algolia/internal/HttpRequester.java

@@ -93,8 +93,8 @@ private <T> T execute(@Nonnull HttpRequest httpRequest, RequestOptions requestOp
       }
 
       // Return null if there's no content or the return type isn't provided.
-      if (returnType == null || response.body() == null || response.body().contentLength() == 0) {
-        return null; // No need to deserialize, either no content or no type provided
+      if (returnType == null || response.body() == null || response.body().contentLength() == 0 || response.code() == 204) {
+        return null;
       }
 
       // Returns the raw response when using `*WithHTTPInfo` methods.

clients/algoliasearch-client-javascript/packages/client-common/src/transporter/helpers.ts

@@ -75,6 +75,11 @@ export function serializeHeaders(
 }
 
 export function deserializeSuccess<TObject>(response: Response): TObject {
+  // Handle 204 No Content and other empty responses
+  if (response.status === 204 || response.content.length === 0) {
+    return undefined as unknown as TObject;
+  }
+
   try {
     return JSON.parse(response.content);
   } catch (e) {

clients/algoliasearch-client-kotlin/client/src/commonMain/kotlin/com/algolia/client/transport/internal/KtorRequester.kt

@@ -67,7 +67,8 @@ public class KtorRequester(
       requestBuilder.setTimeout(requestOptions, callType, host)
       try {
         val response = httpClient.request(requestBuilder)
-        val body = response.body<T>(returnType)
+        @Suppress("UNCHECKED_CAST")
+        val body: T = if (response.status.value == 204 || response.contentLength() == 0L) null as T else response.body<T>(returnType)
         mutex.withLock { host.reset() }
         return body
       } catch (exception: Throwable) {

clients/algoliasearch-client-php/lib/RetryStrategy/ApiWrapper.php

@@ -284,15 +284,19 @@ private function handleResponse(
             throw new AlgoliaException($statusCode.': '.$response->getReasonPhrase(), $statusCode);
         }
 
-        try {
-            $deserializeStart = microtime(true);
-            $responseArray = Helpers::json_decode($body, true);
-            $deserializeDurationMs = round((microtime(true) - $deserializeStart) * 1000);
-            $this->log(LogLevel::DEBUG, 'Response body deserialized in '.$deserializeDurationMs.'ms');
-        } catch (\InvalidArgumentException $e) {
-            $this->log(LogLevel::ERROR, 'Failed to deserialize response: '.$e->getMessage());
-
-            throw $e;
+        if (204 === $statusCode || $body === '') {
+            $responseArray = null;
+        } else {
+            try {
+                $deserializeStart = microtime(true);
+                $responseArray = Helpers::json_decode($body, true);
+                $deserializeDurationMs = round((microtime(true) - $deserializeStart) * 1000);
+                $this->log(LogLevel::DEBUG, 'Response body deserialized in '.$deserializeDurationMs.'ms');
+            } catch (\InvalidArgumentException $e) {
+                $this->log(LogLevel::ERROR, 'Failed to deserialize response: '.$e->getMessage());
+
+                throw $e;
+            }
         }
 
         if (404 === $statusCode) {

clients/algoliasearch-client-scala/src/main/scala/algoliasearch/internal/HttpRequester.scala

@@ -161,8 +161,8 @@ private[algoliasearch] class HttpRequester private (
       // Handle unsuccessful responses.
       if (!response.isSuccessful)
         throw AlgoliaApiException(message = response.message, httpErrorCode = response.code)
-      // Deserialize and return the response.
-      jsonSerializer.deserialize[T](response.body.byteStream)
+      if (response.code == 204) null.asInstanceOf[T]
+      else jsonSerializer.deserialize[T](response.body.byteStream)
     } catch {
       case exception: IOException => throw AlgoliaClientException(cause = exception)
       case exception: AlgoliaApiException =>