fix(requests): ensure last retry error message is forwarded when raised

Author: Thomas Dalous

lib/algolia/transport/transport.rb

@@ -49,6 +49,8 @@ def write(method, path, body = {}, opts = {})
       # @return [Response] response of the request
       #
       def request(call_type, method, path, body = {}, opts = {})
+        last_retry_error = nil
+
         @retry_strategy.get_tryable_hosts(call_type).each do |host|
           opts[:timeout]         ||= get_timeout(call_type) * (host.retry_count + 1)
           opts[:connect_timeout] ||= @config.connect_timeout * (host.retry_count + 1)
@@ -73,10 +75,14 @@ def request(call_type, method, path, body = {}, opts = {})
             decoded_error = json_to_hash(response.error, @config.symbolize_keys)
             raise AlgoliaHttpError.new(get_option(decoded_error, 'status'), get_option(decoded_error, 'message'))
           end
-          return json_to_hash(response.body, @config.symbolize_keys) unless outcome == RETRY
+          if outcome == RETRY
+            last_retry_error = response.error
+          else
+            return json_to_hash(response.body, @config.symbolize_keys)
+          end
         end
 
-        raise AlgoliaUnreachableHostError, 'Unreachable hosts'
+        raise AlgoliaUnreachableHostError, "Unreachable hosts. Last error: #{last_retry_error}"
       end
 
       private

test/algolia/unit/retry_strategy_test.rb

@@ -82,7 +82,7 @@ def test_failure_when_all_hosts_are_down
         index.save_object({ objectID: 'one' })
       end
 
-      assert_equal 'Unreachable hosts', exception.message
+      assert_includes exception.message, 'Unreachable hosts. Last error: SSL_connect'
     end
   end