feat(x/oracle): return latest prices first by default in prices query

Signed-off-by: Artur Troian <[email protected]>

Author: troian

upgrades/software/v2.1.0/upgrade.go

@@ -106,6 +106,7 @@ func (up *upgrade) UpgradeHandler() upgradetypes.UpgradeHandler {
 				return toVM, fmt.Errorf("failed to set updated fee pool balance: %w", err)
 			}
 		}
+
 		return toVM, err
 	}
 }

x/oracle/keeper/grpc_query.go

@@ -31,6 +31,11 @@ func (k Querier) Prices(ctx context.Context, req *types.QueryPricesRequest) (*ty
 		*pageReq = *req.Pagination
 	}
 
+	// Keys are stored in ascending chronological order.
+	// Invert Reverse so the default returns latest prices first
+	// and Reverse=true returns oldest first.
+	pageReq.Reverse = !pageReq.Reverse
+
 	prices, pageRes, err := query.CollectionFilteredPaginate(
 		ctx,
 		keeper.prices,

x/oracle/keeper/grpc_query_test.go

@@ -121,7 +121,7 @@ func TestGRPCQueryPricesTimestamp(t *testing.T) {
 	require.Len(t, res.Prices, 2)
 }
 
-func TestGRPCQueryPricesPaginationReverse(t *testing.T) {
+func TestGRPCQueryPricesDefaultOrder(t *testing.T) {
 	suite := setupTest(t)
 
 	source := testutil.AccAddress(t)
@@ -145,14 +145,15 @@ func TestGRPCQueryPricesPaginationReverse(t *testing.T) {
 	ctx = addPriceEntry(t, ctx, suite.keeper, source, dataID, 11, ts2, sdkmath.LegacyMustNewDecFromStr("2.0"))
 	ctx = addPriceEntry(t, ctx, suite.keeper, source, dataID, 12, ts3, sdkmath.LegacyMustNewDecFromStr("3.0"))
 
+	// Default order (no Reverse flag) should return latest prices first
 	req := &oracletypes.QueryPricesRequest{
 		Filters: oracletypes.PricesFilter{
 			AssetDenom: sdkutil.DenomAkt,
 			BaseDenom:  sdkutil.DenomUSD,
 			StartTime:  baseTime,
 			EndTime:    baseTime.Add(time.Minute),
 		},
-		Pagination: &sdkquery.PageRequest{Limit: 2, Reverse: true},
+		Pagination: &sdkquery.PageRequest{Limit: 2},
 	}
 
 	res, err := suite.queryClient.Prices(ctx, req)
@@ -163,14 +164,15 @@ func TestGRPCQueryPricesPaginationReverse(t *testing.T) {
 	require.True(t, res.Prices[0].ID.Timestamp.Equal(ts3))
 	require.True(t, res.Prices[1].ID.Timestamp.Equal(ts2))
 
+	// Continue with cursor-based pagination
 	req = &oracletypes.QueryPricesRequest{
 		Filters: oracletypes.PricesFilter{
 			AssetDenom: sdkutil.DenomAkt,
 			BaseDenom:  sdkutil.DenomUSD,
 			StartTime:  baseTime,
 			EndTime:    baseTime.Add(time.Minute),
 		},
-		Pagination: &sdkquery.PageRequest{Key: res.Pagination.NextKey, Limit: 2, Reverse: true},
+		Pagination: &sdkquery.PageRequest{Key: res.Pagination.NextKey, Limit: 2},
 	}
 
 	res, err = suite.queryClient.Prices(ctx, req)
@@ -179,3 +181,64 @@ func TestGRPCQueryPricesPaginationReverse(t *testing.T) {
 	require.Len(t, res.Prices, 1)
 	require.True(t, res.Prices[0].ID.Timestamp.Equal(ts1))
 }
+
+func TestGRPCQueryPricesReverseOrder(t *testing.T) {
+	suite := setupTest(t)
+
+	source := testutil.AccAddress(t)
+	params := oracletypes.DefaultParams()
+	params.Sources = []string{source.String()}
+	params.MinPriceSources = 1
+	params.MaxPriceStalenessPeriod = 1000
+	params.TwapWindow = 10
+	params.MaxPriceDeviationBps = 1000
+	require.NoError(t, suite.keeper.SetParams(suite.ctx, params))
+
+	dataID := oracletypes.DataID{Denom: sdkutil.DenomAkt, BaseDenom: sdkutil.DenomUSD}
+	baseTime := time.Now().UTC().Truncate(time.Nanosecond)
+
+	ts1 := baseTime.Add(10 * time.Second)
+	ts2 := baseTime.Add(11 * time.Second)
+	ts3 := baseTime.Add(12 * time.Second)
+
+	ctx := suite.ctx
+	ctx = addPriceEntry(t, ctx, suite.keeper, source, dataID, 10, ts1, sdkmath.LegacyMustNewDecFromStr("1.0"))
+	ctx = addPriceEntry(t, ctx, suite.keeper, source, dataID, 11, ts2, sdkmath.LegacyMustNewDecFromStr("2.0"))
+	ctx = addPriceEntry(t, ctx, suite.keeper, source, dataID, 12, ts3, sdkmath.LegacyMustNewDecFromStr("3.0"))
+
+	// Reverse=true should return oldest prices first
+	req := &oracletypes.QueryPricesRequest{
+		Filters: oracletypes.PricesFilter{
+			AssetDenom: sdkutil.DenomAkt,
+			BaseDenom:  sdkutil.DenomUSD,
+			StartTime:  baseTime,
+			EndTime:    baseTime.Add(time.Minute),
+		},
+		Pagination: &sdkquery.PageRequest{Limit: 2, Reverse: true},
+	}
+
+	res, err := suite.queryClient.Prices(ctx, req)
+	require.NoError(t, err)
+	require.NotNil(t, res)
+	require.Len(t, res.Prices, 2)
+	require.NotEmpty(t, res.Pagination.NextKey)
+	require.True(t, res.Prices[0].ID.Timestamp.Equal(ts1))
+	require.True(t, res.Prices[1].ID.Timestamp.Equal(ts2))
+
+	// Continue with cursor-based pagination
+	req = &oracletypes.QueryPricesRequest{
+		Filters: oracletypes.PricesFilter{
+			AssetDenom: sdkutil.DenomAkt,
+			BaseDenom:  sdkutil.DenomUSD,
+			StartTime:  baseTime,
+			EndTime:    baseTime.Add(time.Minute),
+		},
+		Pagination: &sdkquery.PageRequest{Key: res.Pagination.NextKey, Limit: 2, Reverse: true},
+	}
+
+	res, err = suite.queryClient.Prices(ctx, req)
+	require.NoError(t, err)
+	require.NotNil(t, res)
+	require.Len(t, res.Prices, 1)
+	require.True(t, res.Prices[0].ID.Timestamp.Equal(ts3))
+}