optimize url::can_parse method (#1106)

* optimize url::can_parse method

* update clang-tools to 22

* create AGENTS.md

* remove unused methods

* update comments & abi-check

* bump SOVERSION to 5 for intentional ABI break

* fix clang-tidy-22 warnings: noexcept-escape, unchecked-optional-access, throwing-static-init

* address fuzzing issues

* fix throwing-static-init false positive and add clang-tidy to run-clangcldocker.sh

* fix docker clang-tidy: generate compile_commands.json on host, run tidy in container

* fix gen_compile_commands: drop -stdlib=libc++ when using host GCC

* wipe stale cmake cache before gen_compile_commands to drop old CXX_FLAGS

* fix docker clang-tidy: install cmake+ninja in container, use clang++-22 to match CI exactly

* wipe build-clang-tidy before docker cmake to avoid generator mismatch

* install clang-22 and libc++-22-dev in docker tidy container

* reduce apt-get verbosity with -qq flag

* add git to docker deps for CPM to clone gtest

* suppress apt/docker verbosity, fix SSL certs, cache CPM downloads on host

* exclude vendored gtest from clang-tidy and update ExcludeHeaderFilterRegex

* scope clang-tidy to src/ only, fix git safe.directory, simplify docker setup

* fix all clang-tidy issues: scope to ada.cpp, NOLINT false positives, fix stringview usage, update AGENTS.md

* remove .cpm-cache from repo, add to .gitignore

* add regression tests for extra-slash fuzzer crashes (ws:///..., ws://////5...)

* fix % in host: return nullopt to defer to full parser; add regression tests for all fuzzer crashes

* fix port leading-zeros: strip zeros before pl>5 check; add regression tests

* fix IPv4 fast path bypassing port validation; add regression test

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt

* add shortcuts for can_parse slow path

* optimize even further (#1111)

* Fix error in optimized can_parse (#1118)

* Improve consistency in optimized can_parse (#1119)

---------

Co-authored-by: Carlos Sousa <40635471+CarlosEduR@users.noreply.github.com>

Author: anonrig

.clang-tidy

@@ -5,12 +5,13 @@ Checks: >
   -bugprone-narrowing-conversions,
   -bugprone-suspicious-include,
   -bugprone-unhandled-exception-at-new,
+  -bugprone-throwing-static-initialization,
   clang-analyzer-*,
   -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
 
 # Turn all the warnings from the checks above into errors.
 WarningsAsErrors: '*'
 # Check first-party (non-system, non-vendored) headers.
 HeaderFilterRegex: '.*'
-ExcludeHeaderFilterRegex: 'build/_deps/'
+ExcludeHeaderFilterRegex: '(build[^/]*/_deps/|\.cpm-cache/|/expected\.h$)'
 SystemHeaders: false

.github/workflows/abi-check.yml

@@ -37,8 +37,21 @@ jobs:
       - name: Find latest release tag
         id: baseline
         run: |
-          # Find the most recent vX.Y.Z tag reachable from the current commit's history
-          LATEST_TAG=$(git tag --list 'v*.*.*' --sort=-version:refname | head -1)
+          # Find the most recent vX.Y.Z tag that does NOT point to the current HEAD.
+          # Excluding HEAD ensures we compare against a previous release even when a
+          # new release tag was just pushed to main alongside this workflow run.
+          CURRENT_SHA=$(git rev-parse HEAD)
+          LATEST_TAG=$(git tag --merged HEAD --list 'v*.*.*' --sort=-version:refname | while IFS= read -r tag; do
+            TAG_SHA=$(git rev-parse "${tag}^{}" 2>/dev/null)
+            if [ "$TAG_SHA" != "$CURRENT_SHA" ]; then
+              echo "$tag"
+              break
+            fi
+          done)
+          if [ -z "$LATEST_TAG" ]; then
+            echo "No previous release tag found — cannot establish a baseline."
+            exit 1
+          fi
           echo "Latest release tag: $LATEST_TAG"
           echo "tag=$LATEST_TAG" >> "$GITHUB_OUTPUT"
 

.github/workflows/lint_and_format_check.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Run clang-format
         uses: jidicula/clang-format-action@654a770daa28443dd111d133e4083e21c1075674 # v4.18.0
         with:
-          clang-format-version: '17'
+          clang-format-version: '22'
           fallback-style: 'Google'
 
       - uses: chartboost/ruff-action@e18ae971ccee1b2d7bbef113930f00c670b78da4 # v1.0.0
@@ -38,11 +38,15 @@ jobs:
           version: 0.6.0
 
       - name: Install clang-tidy and libc++
-        run: sudo apt-get update && sudo apt-get install -y clang-tidy-20 libc++-20-dev libc++abi-20-dev
+        run: |
+          wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
+          echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-22 main" | sudo tee /etc/apt/sources.list.d/llvm.list
+          sudo apt-get update
+          sudo apt-get install -y clang-tidy-22 libc++-22-dev libc++abi-22-dev
 
       - name: Run clang-tidy
         run: >
-          cmake -B build -DADA_TESTING=ON -DADA_USE_UNSAFE_STD_REGEX_PROVIDER=ON -DCMAKE_CXX_CLANG_TIDY=clang-tidy-20 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_CXX_FLAGS="-stdlib=libc++" &&
+          cmake -B build -DADA_TESTING=ON -DADA_USE_UNSAFE_STD_REGEX_PROVIDER=ON -DCMAKE_CXX_CLANG_TIDY=clang-tidy-22 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_CXX_FLAGS="-stdlib=libc++" &&
           cmake --build build -j=4
         env:
-          CXX: clang++-20
+          CXX: clang++-22

.gitignore

@@ -4,6 +4,9 @@ build-*/
 *-build-*
 _fuzz_check/
 
+# CPM package cache (used by tools/run-clangcldocker.sh docker fallback)
+.cpm-cache/
+
 # Python cache
 __pycache__
 venv

CLAUDE.md AGENTS.mdCLAUDE.md renamed to AGENTS.md

@@ -2,6 +2,19 @@
 
 This guide provides instructions for building, testing, and benchmarking the Ada URL parser library using CMake.
 
+## Pre-commit Checklist
+
+Always run the clang-format and clang-tidy script before committing:
+
+```bash
+bash tools/run-clangcldocker.sh
+```
+
+This runs clang-format on all tracked source files and clang-tidy on `src/ada.cpp`
+(the single translation unit that includes all first-party code). The script uses
+the locally installed LLVM 22 toolchain when available, otherwise falls back to the
+`xianpengshen/clang-tools:22` Docker image automatically.
+
 ## Quick Reference
 
 ```bash

benchmarks/bench_protocol.cpp

@@ -21,8 +21,8 @@
 #include "counters/bench.h"
 
 template <class Function1, class Function2>
-counters::event_aggregate shuffle_bench(Function1 &&function1,
-                                        Function2 &&function2,
+counters::event_aggregate shuffle_bench(Function1&& function1,
+                                        Function2&& function2,
                                         size_t min_repeat = 300,
                                         size_t min_time_ns = 400'000'000,
                                         size_t max_repeat = 1000000,
@@ -77,7 +77,7 @@ constexpr uint64_t scheme_keys[] = {
 
 // branchless load of up to 5 characters into a uint64_t, padding with zeros if
 // n < 5
-inline uint64_t branchless_load5(const char *p, size_t n) {
+inline uint64_t branchless_load5(const char* p, size_t n) {
   uint64_t input = (uint8_t)p[0];
   input |= ((uint64_t)(uint8_t)p[n > 1] << 8) & (0 - (uint64_t)(n > 1));
   input |= ((uint64_t)(uint8_t)p[(n > 2) * 2] << 16) & (0 - (uint64_t)(n > 2));
@@ -131,7 +131,7 @@ std::optional<SchemeType> get_scheme_type(std::string_view scheme) noexcept {
   return std::nullopt;
 }
 
-double pretty_print(const std::string &name, size_t num_values,
+double pretty_print(const std::string& name, size_t num_values,
                     counters::event_aggregate agg) {
   printf("%-50s : ", name.c_str());
   printf(" %5.3f ns ", agg.fastest_elapsed_ns() / double(num_values));
@@ -269,7 +269,7 @@ void collect_benchmark_results(size_t number_strings) {
   gen.seed(42);  // reset seed to ensure same shuffle for all benchmarks
 }
 
-int main(int argc, char **argv) {
+int main(int argc, char** argv) {
   if (!counters::has_performance_counters()) {
     printf(
         "Performance counters not available, you may need to run with sudo.\n");

benchmarks/competitors/servo-url/servo_url.h

@@ -16,13 +16,13 @@ struct Url;
 
 extern "C" {
 
-Url *parse_url(const char *raw_input, size_t raw_input_length);
+Url* parse_url(const char* raw_input, size_t raw_input_length);
 
-void free_url(Url *raw);
+void free_url(Url* raw);
 
-const char *parse_url_to_href(const char *raw_input, size_t raw_input_length);
+const char* parse_url_to_href(const char* raw_input, size_t raw_input_length);
 
-void free_string(const char *);
+void free_string(const char*);
 }  // extern "C"
 
 }  // namespace servo_url

fuzz/can_parse.cc

@@ -7,7 +7,7 @@
 #include "ada.cpp"
 #include "ada.h"
 
-extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
+extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   FuzzedDataProvider fdp(data, size);
   std::string source = fdp.ConsumeRandomLengthString(256);
   std::string base_source = fdp.ConsumeRandomLengthString(256);

fuzz/idna.cc

@@ -6,7 +6,7 @@
 #include "ada.cpp"
 #include "ada.h"
 
-extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
+extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   FuzzedDataProvider fdp(data, size);
   std::string source = fdp.ConsumeRandomLengthString(256);
   std::string source2 = fdp.ConsumeRandomLengthString(64);

fuzz/parse.cc

@@ -8,8 +8,8 @@
 #include "ada.cpp"
 #include "ada.h"
 
-bool is_valid_utf8_string(const char *buf, size_t len) {
-  const uint8_t *data = reinterpret_cast<const uint8_t *>(buf);
+bool is_valid_utf8_string(const char* buf, size_t len) {
+  const uint8_t* data = reinterpret_cast<const uint8_t*>(buf);
   uint64_t pos = 0;
   uint32_t code_point = 0;
   while (pos < len) {
@@ -93,7 +93,7 @@ bool is_valid_utf8_string(const char *buf, size_t len) {
 }
 
 // Exercise all getters and boolean predicates on ada::url
-static void exercise_url_predicates(const ada::url &u) {
+static void exercise_url_predicates(const ada::url& u) {
   volatile size_t length = 0;
   length += u.get_href().size();
   length += u.get_origin().size();
@@ -119,7 +119,7 @@ static void exercise_url_predicates(const ada::url &u) {
 }
 
 // Exercise all getters and boolean predicates on ada::url_aggregator
-static void exercise_aggregator_predicates(const ada::url_aggregator &u) {
+static void exercise_aggregator_predicates(const ada::url_aggregator& u) {
   volatile size_t length = 0;
   length += u.get_href().size();
   length += u.get_origin().size();
@@ -150,7 +150,7 @@ static void exercise_aggregator_predicates(const ada::url_aggregator &u) {
   (void)u.to_diagram();
 }
 
-extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
+extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   FuzzedDataProvider fdp(data, size);
   std::string source = fdp.ConsumeRandomLengthString(256);
   std::string base = fdp.ConsumeRandomLengthString(256);