Currently the no_proxy environmental variable combined with checkBypass does not take into account sub domains. I don't know if this is by design, but an example of this is:
process.env['no_proxy'] = 'internal.com'
checkBypass(new Url('https://github.internal.com/path/to/repo')) // false
process.env['no_proxy'] = 'github.internal.com'
checkBypass(new Url('https://github.internal.com/path/to/repo')) // true
The offending line is:
|
if (upperReqHosts.some(x => x === upperNoProxyItem)) { |
I would love to see a more lenient pattern, either respecting wildcards or ignoring sub domains.
Regards
Erik Hughes
Currently the no_proxy environmental variable combined with checkBypass does not take into account sub domains. I don't know if this is by design, but an example of this is:
The offending line is:
http-client/proxy.ts
Line 54 in edadda1
I would love to see a more lenient pattern, either respecting wildcards or ignoring sub domains.
Regards
Erik Hughes