Allow reviewers to download assigned app edits

Closes #820

Author: lberrymage

parcelo/src/main/kotlin/app/accrescent/server/parcelo/security/PermissionService.kt

@@ -71,8 +71,6 @@ class PermissionService @Inject constructor(private val config: ParceloConfig) {
             is HasPermissionRequest.CreateAppEditListing,
             is HasPermissionRequest.DeleteAppEdit,
             is HasPermissionRequest.DeleteAppEditListing,
-            is HasPermissionRequest.DownloadAppEdit,
-            is HasPermissionRequest.DownloadAppEditListingIcons,
             is HasPermissionRequest.ReplaceAppEditListingIcon,
             is HasPermissionRequest.ReplaceAppEditPackage,
             is HasPermissionRequest.SubmitAppEdit,
@@ -85,6 +83,8 @@ class PermissionService @Inject constructor(private val config: ParceloConfig) {
                 .findByAppEditIdAndUserId(request.resourceId, request.subjectId)
                 ?.reviewer == true
 
+            is HasPermissionRequest.DownloadAppEdit,
+            is HasPermissionRequest.DownloadAppEditListingIcons,
             is HasPermissionRequest.ViewAppEditExistence -> {
                 val isOrgOwner = OrganizationRelationshipSet
                     .findByAppEditIdAndUserId(request.resourceId, request.subjectId)

parcelo/src/test/kotlin/app/accrescent/server/parcelo/security/PermissionServiceTest.kt

@@ -172,11 +172,21 @@ class PermissionServiceTest {
                     request = HasPermissionRequest.DownloadAppEdit(TEST_APP_EDIT_ID, TEST_USER_ID),
                     setUpData = { setUpAppEditData() },
                 ),
+                HasPermissionReturnsTrueWhenRequiredParams(
+                    request = HasPermissionRequest
+                        .DownloadAppEdit(TEST_APP_EDIT_ID, TEST_REVIEWER_USER_ID),
+                    setUpData = { setUpAppEditReviewerData() },
+                ),
                 HasPermissionReturnsTrueWhenRequiredParams(
                     request = HasPermissionRequest
                         .DownloadAppEditListingIcons(TEST_APP_EDIT_ID, TEST_USER_ID),
                     setUpData = { setUpAppEditData() },
                 ),
+                HasPermissionReturnsTrueWhenRequiredParams(
+                    request = HasPermissionRequest
+                        .DownloadAppEditListingIcons(TEST_APP_EDIT_ID, TEST_REVIEWER_USER_ID),
+                    setUpData = { setUpAppEditReviewerData() },
+                ),
                 HasPermissionReturnsTrueWhenRequiredParams(
                     request = HasPermissionRequest
                         .ReplaceAppEditListingIcon(TEST_APP_EDIT_ID, TEST_USER_ID),