Skip to content

Commit 4a297d7

Browse files
committed
2.6.4: Remove scope parameter from dependency node, hopefully fix maven-publish now for real
1 parent 1934b6b commit 4a297d7

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
# Change log
22

3-
-Simple Stack 2.6.3 (2022-04-21)
3+
-Simple Stack 2.6.4 (2022-04-21)
44
--------------------------------
55

66
- FIX: Attempt at fixing a crash related to `LinkedHashMap.retainAll()` specifically on Android 6 and Android 6.1 devices (#256).
77

8+
- 2.6.3 had an issue with `maven-publish` and transitive dependencies were missing, and is therefore skipped.
9+
810

911
-Simple Stack 2.6.2 (2021-06-07)
1012
--------------------------------

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ and then, add the dependency to your module's `build.gradle.kts` (or `build.grad
6969

7070
``` kotlin
7171
// build.gradle.kts
72-
implementation("com.github.Zhuinden:simple-stack:2.6.3")
72+
implementation("com.github.Zhuinden:simple-stack:2.6.4")
7373

7474
implementation("com.github.Zhuinden.simple-stack-extensions:core-ktx:2.2.2")
7575
implementation("com.github.Zhuinden.simple-stack-extensions:fragments:2.2.2")
@@ -83,7 +83,7 @@ or
8383

8484
``` groovy
8585
// build.gradle
86-
implementation 'com.github.Zhuinden:simple-stack:2.6.3'
86+
implementation 'com.github.Zhuinden:simple-stack:2.6.4'
8787
8888
implementation 'com.github.Zhuinden.simple-stack-extensions:core-ktx:2.2.2'
8989
implementation 'com.github.Zhuinden.simple-stack-extensions:fragments:2.2.2'

simple-stack/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ afterEvaluate {
7575
register("mavenJava", MavenPublication::class) {
7676
groupId = "com.github.Zhuinden"
7777
artifactId = "simple-stack"
78-
version = "2.6.3"
78+
version = "2.6.4"
7979

8080
from(components["release"])
8181
artifact(sourcesJar.get())
@@ -87,12 +87,12 @@ afterEvaluate {
8787

8888
configurationNames.forEach { configurationName ->
8989
configurations[configurationName].allDependencies.forEach {
90-
if (it.group != null && it.version != "unspecified") {
90+
if (it.group != null) {
9191
val dependencyNode = dependenciesNode.appendNode("dependency")
9292
dependencyNode.appendNode("groupId", it.group)
9393
dependencyNode.appendNode("artifactId", it.name)
9494
dependencyNode.appendNode("version", it.version)
95-
dependencyNode.appendNode("scope", configurationName)
95+
//dependencyNode.appendNode("scope", configurationName)
9696
}
9797
}
9898
}

0 commit comments

Comments
 (0)