Skip to content

Commit fc87c4c

Browse files
author
yggverse
committed
remove extra Uri conversion
1 parent c7a9a62 commit fc87c4c

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/app/browser/window/tab/item/client/driver/gemini.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ fn handle(
152152
) {
153153
const EVENT_COMPLETED: &str = "Completed";
154154
let uri = request.uri().clone();
155+
let url = uri.to_string();
155156
let server_certificate = this
156157
.page
157158
.profile
@@ -161,7 +162,7 @@ fn handle(
161162

162163
this.client
163164
.socket
164-
.set_proxy_resolver(this.page.profile.proxy.matches(&uri).as_ref());
165+
.set_proxy_resolver(this.page.profile.proxy.matches(&url).as_ref());
165166

166167
this.client.request_async(
167168
request,
@@ -172,7 +173,7 @@ fn handle(
172173
this.page
173174
.profile
174175
.identity
175-
.get(&uri.to_string()).map(|identity|identity.to_tls_certificate().unwrap()),
176+
.get(&url).map(|identity|identity.to_tls_certificate().unwrap()),
176177
server_certificate.map(|c|vec![c]),
177178
{
178179
let page = this.page.clone();
@@ -192,7 +193,7 @@ fn handle(
192193
use gtk::prelude::SocketConnectionExt;
193194
let mut i = page.navigation.request.info.borrow_mut();
194195
i
195-
.set_request(Some(uri.to_string()))
196+
.set_request(Some(url))
196197
.set_socket(Some((
197198
connection.socket_connection.local_address().unwrap(),
198199
connection.socket_connection.remote_address().unwrap()

src/app/browser/window/tab/item/client/driver/nex.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ impl Nex {
4343
.set_request(Some(uri.to_string()));
4444
}
4545

46-
let path = uri.path(); // copy once
46+
// copy once
47+
let path = uri.path();
48+
let url = uri.to_string();
4749

4850
if path.is_empty() {
4951
// auto-append trailing slash to the root locations
@@ -67,7 +69,7 @@ impl Nex {
6769
}
6870

6971
let socket = SocketClient::new();
70-
socket.set_proxy_resolver(self.page.profile.proxy.matches(&uri).as_ref());
72+
socket.set_proxy_resolver(self.page.profile.proxy.matches(&url).as_ref());
7173
socket.set_protocol(SocketProtocol::Tcp);
7274
socket.set_timeout(30); // @TODO optional
7375

@@ -118,7 +120,7 @@ impl Nex {
118120
}
119121
});
120122

121-
socket.connect_to_uri_async(&uri.to_string(), 1900, Some(&cancellable.clone()), {
123+
socket.connect_to_uri_async(&url, 1900, Some(&cancellable.clone()), {
122124
let p = self.page.clone();
123125
move |result| match result {
124126
Ok(c) => {

src/app/browser/window/tab/item/page/navigation/request.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ impl Request {
138138
// Indicate proxy connections
139139
{
140140
const C: &str = "accent";
141-
if uri(e).is_some_and(|u| p.proxy.matches(&u).is_some()) {
141+
if p.proxy.matches(&e.text()).is_some() {
142142
e.set_css_classes(&[C])
143143
} else {
144144
e.remove_css_class(C)

src/profile/proxy.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ mod rule;
44

55
use anyhow::Result;
66
use database::Database;
7-
use gtk::{
8-
gio::{ProxyResolver, SimpleProxyResolver},
9-
glib::Uri,
10-
};
7+
use gtk::gio::{ProxyResolver, SimpleProxyResolver};
118
use ignore::Ignore;
129
use r2d2::Pool;
1310
use r2d2_sqlite::SqliteConnectionManager;
@@ -59,11 +56,11 @@ impl Proxy {
5956

6057
// Actions
6158

62-
pub fn matches(&self, request: &Uri) -> Option<ProxyResolver> {
59+
pub fn matches(&self, request: &str) -> Option<ProxyResolver> {
6360
for rule in self.rule.borrow().iter().filter(|r| r.is_enabled) {
6461
if gtk::glib::Regex::match_simple(
6562
&rule.request,
66-
request.to_str(),
63+
request,
6764
gtk::glib::RegexCompileFlags::DEFAULT,
6865
gtk::glib::RegexMatchFlags::DEFAULT,
6966
) {

0 commit comments

Comments
 (0)