fix: lint errors

Author: zoran995

lib/Map/Leaflet/LeafletDataSourceDisplay.ts

@@ -289,7 +289,7 @@ export default class LeafletDataSourceDisplay {
     const tmp = new BoundingSphere();
 
     let count = 0;
-    let state = BoundingSphereState.DONE;
+    let state: BoundingSphereState;
     const visualizers = dataSource.visualizers;
     const visualizersLength = visualizers.length;
 

lib/Map/Vector/Protomaps/mapboxStyleJsonToProtomaps.ts

@@ -171,6 +171,7 @@ export function getFont(obj: any, fontSubMap: Record<string, FontSub>) {
   }
   if (text_size.stops) {
     let base = 1.4;
+    // eslint-disable-next-line no-useless-assignment
     if (text_size.base) base = text_size.base;
     else text_size.base = base;
     const t = numberFn(text_size);

lib/Models/ItemSearchProviders/IndexedItemSearchProvider.ts

@@ -109,7 +109,8 @@ export default class IndexedItemSearchProvider extends ItemSearchProvider {
     } catch (parseError) {
       console.warn(parseError);
       throw new Error(
-        t("indexedItemSearchProvider.errorParsingIndexRoot", { indexRootUrl })
+        t("indexedItemSearchProvider.errorParsingIndexRoot", { indexRootUrl }),
+        { cause: parseError }
       );
     }
   }

lib/ReactViews/Clipboard.tsx

@@ -34,6 +34,7 @@ const Clipboard: FC<ClipboardProps> = (props) => {
 
   useEffect(() => {
     if (createdMessage && !prevTextRef.current && text) {
+      // eslint-disable-next-line react-hooks/set-state-in-effect
       setShowCreatedMessage(true);
     }
     prevTextRef.current = text;

lib/ReactViews/Map/MapNavigation/MapNavigation.tsx

@@ -181,7 +181,6 @@ class MapNavigationBase extends Component<PropTypes> {
       .reverse();
 
     // Ensure we are not showing more composites than we have height for
-    let overflows = false;
     let maxVisible = itemsToShow.length;
     let size = 0;
     if (this.overflows) {
@@ -209,7 +208,7 @@ class MapNavigationBase extends Component<PropTypes> {
       //there is nothing else we can do, we have to show the rest of items as it is.
       return;
     }
-    overflows = itemsToShow.length > maxVisible;
+    const overflows = itemsToShow.length > maxVisible;
     const itemsToCollapseId: string[] = [];
     const activeCollapsible: string[] = [];
     if (overflows) {
@@ -218,7 +217,6 @@ class MapNavigationBase extends Component<PropTypes> {
         size += OVERFLOW_ACTION_SIZE;
         this.overflows = true;
       }
-      maxVisible = maxVisible - pinnedItems.length;
       // first try to collapse inactive items and then active ones if needed
       for (let i = 0; i < possibleToCollapse.length; i++) {
         const item = possibleToCollapse[i];

lib/ReactViews/Map/Panels/SharePanel/SharePanelContent.tsx

@@ -46,6 +46,9 @@ export const SharePanelContent: FC<ISharePanelContentProps> = ({
     });
   }, [terria]);
 
+  // eslint-disable-next-line react-hooks/refs
+  const shareUrl = shareUrlRef?.current;
+
   return (
     <Box paddedRatio={3} column>
       <Text semiBold medium>
@@ -89,7 +92,7 @@ export const SharePanelContent: FC<ISharePanelContentProps> = ({
       <Spacing bottom={4} />
       <PrintSection viewState={viewState} />
       <Spacing bottom={4} />
-      <EmbedSection shareUrl={shareUrlRef?.current} />
+      <EmbedSection shareUrl={shareUrl} />
     </Box>
   );
 };

lib/ReactViews/Tour/TourPortal.jsx

@@ -43,7 +43,7 @@ import TourProgressDot from "./TourProgressDot.jsx";
  * Fill in indicator dot depending on progress determined from count & max count
  */
 const TourProgress = ({ max, step, setTourIndex }) => {
-  const countArray = Array.from(Array(max).keys()).map((e) => e++);
+  const countArray = Array.from(Array(max).keys()).map((e) => e + 1);
   const countStep = step;
   return (
     <Box centered>