[TAStudio] Rerecords do not count if working with analog controls

[EZGames69]

So I was working with the recent bizhawk dolphin build forked by CasualPokePlayer and noticed my re-record count was low, it turns out this is because the rerecord counts only work when changes to inputs happen, but not changes to Analog controls, when working in TAStudio

[vadosnaprimer]

Rerecord increment is explicitly disabled while drawing, it only counts when the initial mouse down event happens. However one may start drawing below current frame (no invalidation, no rerecord) and then paint input up to above the current frame (invalidation but no rerecord).

Counting rerecords while painting was likely disabled because it'd previously count on every new invalidated frame when drawing up, or something. Obviously we want it to only count one draw up as 1 rerecord if anything was invalidated before mouse up.

[vadosnaprimer]

Turns out this is fixed now.

[vadosnaprimer]

Actually no, painting still doesn't add rerecords. But making it count rerecords is kinda tricky because we only need it to fire on mouse up like autorestore does. Which is now controlled by FrameEdited(). And adding rerecord increment to that kinda works, but then we need to make a bunch of other operations to stop adding rerecords, while for others it needs to be added, like branch loading, explicitly.

@SuuperW can you think of a neat way to solve this?

[SuuperW]

Stop caring about rerecords is my preferred solution.

then we need to make a bunch of other operations to stop adding rerecords

You mean just remove rerecord counting logic in places is already exists, so it won't be double-counted by FrameEdited? That seems like a good and neat solution.

[vadosnaprimer]

Removal will mostly just be from InvalidateAfter, which used to be a reliable reference for rerecords except for the cases in this issue. And then whoever needs it will have to increment them manually instead of relying on InvalidateAfter.

Stop caring about rerecords is my preferred solution.

Too late, they've been there for too long XD

[SuuperW]

Actually, I think rerecords can be counted well from within the TasMovie. They shouldn't be incremented in InvalidateAfter, because you may get InvalidateAfter(10) then InvalidateAfter(5) without having re-played past frame 10 after the first one: a rerecord should only count if the invalidated frames were re-recorded, right? And the movie knows when they get re-recorded thanks to the lag log.

Too late, they've been there for too long XD

Sure, but they've also been useless for too long to bother much with.

[vadosnaprimer]

Yeah I forgot all of that code, which is why I'm asking.

[SuuperW]

I took a peek at some code for Basic Bot and found it turns off rerecord counting. 🙃

[vadosnaprimer]

Botted rerecords are traditionally not counted (from lua too iirc).